b152bb75f8
When calling the `bitmap(chunk)` method of the various *MarkingState accessors we would receive a raw `Bitmap` pointer which does not tell you if accesses to markbits should be made atomically or not. As a result, we would default to doing atomic operation when in fact it may not be necessary. Here we're introducing a templated `ConcurrentBitmap` class that wraps operations done on the markbits and allows them to be made non-atomic. Additionaly, some of the `Bitmap` methods were only used to verify the heap and in the tests so they do not need atomic implementations. Using them in a concurrent context should now fail to link to make sure they're not mis-used in the future. Change-Id: Ifb55f8522c8bf0c87d65da9227864ee428d21bbd Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Reviewed-on: https://chromium-review.googlesource.com/c/1482916 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#59836}
64 lines
2.1 KiB
C++
64 lines
2.1 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include "src/globals.h"
|
|
#include "src/heap/marking.h"
|
|
#include "test/unittests/heap/bitmap-test-utils.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
template <typename T>
|
|
using MarkingTest = TestWithBitmap<T>;
|
|
|
|
TYPED_TEST_SUITE(MarkingTest, BitmapTypes);
|
|
|
|
TYPED_TEST(MarkingTest, TransitionWhiteBlackWhite) {
|
|
auto bitmap = this->bitmap();
|
|
const int kLocationsSize = 3;
|
|
int position[kLocationsSize] = {
|
|
Bitmap::kBitsPerCell - 2, Bitmap::kBitsPerCell - 1, Bitmap::kBitsPerCell};
|
|
for (int i = 0; i < kLocationsSize; i++) {
|
|
MarkBit mark_bit = bitmap->MarkBitFromIndex(position[i]);
|
|
CHECK(Marking::IsWhite(mark_bit));
|
|
CHECK(!Marking::IsImpossible(mark_bit));
|
|
Marking::WhiteToBlack<AccessMode::NON_ATOMIC>(mark_bit);
|
|
CHECK(Marking::IsBlack(mark_bit));
|
|
CHECK(!Marking::IsImpossible(mark_bit));
|
|
Marking::MarkWhite(mark_bit);
|
|
CHECK(Marking::IsWhite(mark_bit));
|
|
CHECK(!Marking::IsImpossible(mark_bit));
|
|
}
|
|
}
|
|
|
|
TYPED_TEST(MarkingTest, TransitionWhiteGreyBlack) {
|
|
auto bitmap = this->bitmap();
|
|
const int kLocationsSize = 3;
|
|
int position[kLocationsSize] = {
|
|
Bitmap::kBitsPerCell - 2, Bitmap::kBitsPerCell - 1, Bitmap::kBitsPerCell};
|
|
for (int i = 0; i < kLocationsSize; i++) {
|
|
MarkBit mark_bit = bitmap->MarkBitFromIndex(position[i]);
|
|
CHECK(Marking::IsWhite(mark_bit));
|
|
CHECK(!Marking::IsBlackOrGrey(mark_bit));
|
|
CHECK(!Marking::IsImpossible(mark_bit));
|
|
Marking::WhiteToGrey<AccessMode::NON_ATOMIC>(mark_bit);
|
|
CHECK(Marking::IsGrey(mark_bit));
|
|
CHECK(Marking::IsBlackOrGrey(mark_bit));
|
|
CHECK(!Marking::IsImpossible(mark_bit));
|
|
Marking::GreyToBlack<AccessMode::NON_ATOMIC>(mark_bit);
|
|
CHECK(Marking::IsBlack(mark_bit));
|
|
CHECK(Marking::IsBlackOrGrey(mark_bit));
|
|
CHECK(!Marking::IsImpossible(mark_bit));
|
|
Marking::MarkWhite(mark_bit);
|
|
CHECK(Marking::IsWhite(mark_bit));
|
|
CHECK(!Marking::IsImpossible(mark_bit));
|
|
}
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|