dc18b82221
This is a reland of0ba115e6a9Changes: - Also allow second parameter influenced by --cache to be reassigned. - Fix --stress-opt to only --always-opt in the last iteration as before. Original change's description: > Reland^2 "[flags] warn about contradictory flags" > > This is a reland ofd8f8a7e210> Change compared to last reland: > - Do not check for d8 flag contradictions in the presence of --fuzzing > - Allow identical re-declaration of --cache=* > > Original change's description: > > Reland "[flags] warn about contradictory flags" > > > > This is a reland ofb8f9166664> > Difference to previous CL: Additional functionality to specify > > incompatible flags based on GN variables and extra-flags, used > > to fix the issues that came up on the waterfall. > > > > This also changes the rules regarding repeated flags: While > > explicitly repeated flags are allowed for boolean values as long > > as they are identical, repeated flags or explicit flags in the > > presence of an active implication are disallowed for non-boolean > > flags. The latter simplifies specifying conflict rules in > > variants.py. Otherwise a rule like > > > > INCOMPATIBLE_FLAGS_PER_EXTRA_FLAG = { > > "--gc-interval=*": ["--gc-interval=*"], > > } > > > > wouldn't work because specifying the same GC interval twice > > wouldn't actually count as a conflict. This was an issue with > > test/mjsunit/wasm/gc-buffer.js, which specifies > > --gc-interval=500 exactly like the extra flag by the stress bot. > > > > Also, this now expands contradictory flags checking to d8 flags > > for consistency. > > > > Original change's description: > > > [flags] warn about contradictory flags > > > > > > Design Doc: https://docs.google.com/document/d/1lkvu8crkK7Ei39qjkPCFijpNyxWXsOktG9GB-7K34jM/ > > > > > > Bug: v8:10577 > > > Change-Id: Ib9cfdffa401c48c895bf31caed5ee03545beddab > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154792 > > > Reviewed-by: Clemens Backes <clemensb@chromium.org> > > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > > Reviewed-by: Georg Neis <neis@chromium.org> > > > Reviewed-by: Tamer Tas <tmrts@chromium.org> > > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#68168} > > > > Bug: v8:10577 > > Change-Id: I268e590ee18a535b13dee14eeb15ddd0a9ee8341 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235115 > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > > Reviewed-by: Tamer Tas <tmrts@chromium.org> > > Reviewed-by: Clemens Backes <clemensb@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#68989} > > Bug: v8:10577 > Change-Id: I31d2794d4f9ff630f3444210100c64d67d881276 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339464 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69339} Bug: v8:10577 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Change-Id: I4a69dc57a102782cb453144323e3752ac8278624 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352770 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#69433}
131 lines
5.2 KiB
Plaintext
131 lines
5.2 KiB
Plaintext
# Copyright 2016 the V8 project authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
[
|
|
##############################################################################
|
|
[ALWAYS, {
|
|
# https://crbug.com/v8/7932
|
|
'runtime/command-line-api-without-side-effects': [SKIP],
|
|
|
|
# Require optimization, so can't be run on Lite mode.
|
|
'cpu-profiler/coverage-block': [PASS, ['lite_mode == True', SKIP]],
|
|
'cpu-profiler/coverage': [PASS, ['lite_mode == True', SKIP]],
|
|
|
|
# https://crbug.com/v8/9029
|
|
'debugger/script-on-after-compile-snapshot': [SKIP],
|
|
|
|
# https://crbug.com/v8/10356
|
|
# This test worked in the wasm interpreter, but fails when using Liftoff for
|
|
# debugging.
|
|
'debugger/wasm-externref-global': [FAIL],
|
|
}], # ALWAYS
|
|
|
|
##############################################################################
|
|
['system == android', {
|
|
# https://crbug.com/v8/8197
|
|
'debugger/get-possible-breakpoints-class-fields': [SKIP],
|
|
}], # 'system == android'
|
|
|
|
##############################################################################
|
|
['variant != default', {
|
|
# Issue 6167.
|
|
'debugger/eval-scopes': [PASS, FAIL],
|
|
'debugger/scope-skip-variables-with-empty-name': [PASS, FAIL],
|
|
'debugger/update-call-frame-scopes': [PASS, FAIL],
|
|
'debugger/side-effect-free-debug-evaluate': [PASS, FAIL],
|
|
'debugger/evaluate-on-call-frame-in-module': [PASS, FAIL],
|
|
}], # variant != default
|
|
|
|
##############################################################################
|
|
['lite_mode or variant == jitless', {
|
|
# Lite mode does not allocate feedback vector.
|
|
'type-profiler/type-profile-start-stop': [SKIP],
|
|
'type-profiler/type-profile': [SKIP],
|
|
'type-profiler/type-profile-with-to-string-tag': [SKIP],
|
|
'type-profiler/type-profile-with-classes': [SKIP],
|
|
'type-profiler/type-profile-disable': [SKIP],
|
|
|
|
# TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
|
|
'debugger/asm-js-stack': [SKIP],
|
|
'debugger/asm-js-breakpoint-before-exec': [SKIP],
|
|
'debugger/asm-js-breakpoint-during-exec': [SKIP],
|
|
'debugger/wasm-*': [SKIP],
|
|
'cpu-profiler/console-profile-wasm': [SKIP],
|
|
}], # 'lite_mode or variant == jitless'
|
|
|
|
##############################################################################
|
|
['variant == jitless', {
|
|
# https://crbug.com/v8/7777
|
|
'cpu-profiler/coverage': [SKIP],
|
|
'cpu-profiler/coverage-block': [SKIP],
|
|
}], # variant == jitless
|
|
|
|
##############################################################################
|
|
['(arch == arm or arch == arm64) and simulator_run', {
|
|
# Slow tests: https://crbug.com/v8/7783
|
|
'runtime/console-messages-limits': [PASS, NO_VARIANTS, ['mode == debug', SKIP]],
|
|
}], # (arch == arm or arch == arm64) and simulator_run
|
|
|
|
##############################################################################
|
|
['variant == no_wasm_traps', {
|
|
'*': [SKIP],
|
|
}], # variant == no_wasm_traps
|
|
|
|
##############################################################################
|
|
['arch == ppc or arch == ppc64', {
|
|
# Liftoff needs to be enabled before running these tests.
|
|
'debugger/wasm-*': [SKIP],
|
|
}], # 'arch == ppc or arch == ppc64'
|
|
|
|
##############################################################################
|
|
['arch == s390 or arch == s390x', {
|
|
# Stack manipulations in LiveEdit is not implemented for this arch.
|
|
'debugger/set-script-source-stack-padding': [SKIP],
|
|
# Liftoff needs to be enabled before running these tests.
|
|
'debugger/wasm-*': [SKIP],
|
|
}], # 'arch == s390 or arch == s390x'
|
|
|
|
################################################################################
|
|
['variant == stress_snapshot', {
|
|
'*': [SKIP], # only relevant for mjsunit tests.
|
|
}],
|
|
|
|
################################################################################
|
|
['variant == stress', {
|
|
'*': [SKIP], # only relevant for mjsunit tests.
|
|
}],
|
|
|
|
##############################################################################
|
|
['tsan == True', {
|
|
# TSan handles SIGPROF incorrectly (https://crbug.com/v8/9869).
|
|
'cpu-profiler/console-profile-wasm': [SKIP],
|
|
}], # 'tsan == True'
|
|
|
|
##############################################################################
|
|
['gc_stress or gc_fuzzer or variant == stress_incremental_marking', {
|
|
# Skip tests that fail with GC stress: https://crbug.com/v8/10748
|
|
'debugger/get-possible-breakpoints': [SKIP],
|
|
'debugger/get-possible-breakpoints-array-literal': [SKIP],
|
|
'debugger/get-possible-breakpoints-master': [SKIP],
|
|
'debugger/regression-424142': [SKIP],
|
|
'debugger/return-break-locations': [SKIP],
|
|
'debugger/set-breakpoint-at-last-line': [SKIP],
|
|
'debugger/set-breakpoint-breaks-on-first-breakable-location': [SKIP],
|
|
'runtime-call-stats/collection': [SKIP],
|
|
'runtime/internal-properties-entries': [SKIP],
|
|
'type-profiler/type-profile-start-stop': [SKIP],
|
|
}], # gc_stress
|
|
|
|
##############################################################################
|
|
['variant == stress_js_bg_compile_wasm_code_gc', {
|
|
# Skip tests that fail with GC stress: https://crbug.com/v8/10748
|
|
'debugger/wasm-debug-command': [SKIP],
|
|
'debugger/wasm-global-names': [SKIP],
|
|
'debugger/wasm-set-breakpoint-liftoff': [SKIP],
|
|
'debugger/wasm-source': [SKIP],
|
|
'debugger/wasm-stepping-with-skiplist': [SKIP],
|
|
}], # stress_js_bg_compile_wasm_code_gc
|
|
|
|
]
|