df6f5f6b69
It is not legal for destructuring patterns and identifiers in declarations
to be in parentheses. This includes nested patterns/identifiers inside
another pattern.
We were checking sub-patterns for parentheses when parsing possible
sub-patterns, but this check missed sub-patterns with a default
initialiser (e.g. [({x:y})=1] = {}), as the AssignmentExpression hid
the pattern.
So, we now additionally record declaration/pattern errors of an assignment
LHS when parsing the assignment cover grammar.
Bug: v8:8630
Change-Id: Ia5a97003671fc1da7f68d7fb15943928ce9496e3
Reviewed-on: https://chromium-review.googlesource.com/c/1404452
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58743}
33 lines
1.2 KiB
JavaScript
33 lines
1.2 KiB
JavaScript
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
|
|
// Parameters can't have parentheses (both patterns and identifiers)
|
|
assertThrows("( ({x: 1}) ) => {};", SyntaxError);
|
|
assertThrows("( (x) ) => {}", SyntaxError);
|
|
assertThrows("( ({x: 1}) = y ) => {}", SyntaxError);
|
|
assertThrows("( (x) = y ) => {}", SyntaxError);
|
|
|
|
// Declarations can't have parentheses (both patterns and identifiers)
|
|
assertThrows("let [({x: 1})] = [];", SyntaxError);
|
|
assertThrows("let [(x)] = [];", SyntaxError);
|
|
assertThrows("let [({x: 1}) = y] = [];", SyntaxError);
|
|
assertThrows("let [(x) = y] = [];", SyntaxError);
|
|
assertThrows("var [({x: 1})] = [];", SyntaxError);
|
|
assertThrows("var [(x)] = [];", SyntaxError);
|
|
assertThrows("var [({x: 1}) = y] = [];", SyntaxError);
|
|
assertThrows("var [(x) = y] = [];", SyntaxError);
|
|
|
|
// Patterns in can't have parentheses in assignments either
|
|
assertThrows("[({x: 1}) = y] = [];", SyntaxError);
|
|
|
|
// Parentheses are fine around identifiers in assignments though, even inside a
|
|
// pattern
|
|
var x;
|
|
[(x)] = [2];
|
|
assertEquals(x, 2);
|
|
[(x) = 3] = [];
|
|
assertEquals(x, 3);
|