Patrick Thier c0fd89c3c0 Reland "Reland "Reland "Improve error messages for property access on null/undefined""" ... This is a reland of 819c3ae2f8 Original change's description: > Reland "Reland "Improve error messages for property access on null/undefined"" > > This is a reland of 8b18c5e6a5 > > Original change's description: > > Reland "Improve error messages for property access on null/undefined" > > > > This is a reland of 24c626c1f7 > > > > Original change's description: > > > Improve error messages for property access on null/undefined > > > > > > Only print the property name when accessing null/undefined if we can > > > convert it to a string without causing side effects. > > > If we can't, omit the property name in the error message. > > > This should avoid confusion when the key is an object with toString(). > > > E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object > > > Object]' anymore, which was misleading since the property accessed would > > > be 'a', but we can't evaluate the key without side effects. > > > > > > Bug: v8:11365 > > > Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211 > > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > > Commit-Queue: Patrick Thier <pthier@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#75250} > > > > Bug: v8:11365 > > Change-Id: Ie2312337f4f1915faa31528a728d90833d80dbd1 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979599 > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Commit-Queue: Patrick Thier <pthier@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#75571} > > Bug: v8:11365 > Change-Id: I90360641ecd870bd93247aa6d91dfb0ad049cfb8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008219 > Auto-Submit: Patrick Thier <pthier@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75604} Bug: v8:11365 Change-Id: I002b537144f328ccbbdcd655e26e5dc87c49c6f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3013935 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#75645}		2021-07-08 14:31:27 +00:00
..
bytecode_expectations	Reland "Reland "Reland "Improve error messages for property access on null/undefined"""	2021-07-08 14:31:27 +00:00
bytecode-expectations-printer.cc	Remove one-shot function optimizations.	2021-05-21 12:38:18 +00:00
bytecode-expectations-printer.h	Remove one-shot function optimizations.	2021-05-21 12:38:18 +00:00
generate-bytecode-expectations.cc	Remove one-shot function optimizations.	2021-05-21 12:38:18 +00:00
interpreter-tester.cc	[runtime] Move string table off-heap	2020-08-06 12:27:18 +00:00
interpreter-tester.h	[cleanup] Remove DISALLOW_COPY_AND_ASSIGN in test/{cctest,fuzzer,inspector}	2020-11-10 01:24:43 +00:00
source-position-matcher.cc	Fix most instances of -Wunreachable-code-aggressive.	2021-07-01 03:03:25 +00:00
source-position-matcher.h	Move remaining files in src/	2019-05-24 18:24:36 +00:00
test-bytecode-generator.cc	Remove one-shot function optimizations.	2021-05-21 12:38:18 +00:00
test-interpreter-intrinsics.cc	[interpreter] Remove %_Call	2021-06-17 15:16:41 +00:00
test-interpreter.cc	[interpreter] Remove unused interpreter intrinsics	2021-06-17 13:43:41 +00:00
test-source-positions.cc	[TurboFan] Templatize GetBytecodeArray	2020-12-17 16:46:53 +00:00