f774d8c56f
Once we enabled --turbo by default we need to turn all the implications off with --no-turbo as well. Chrome sets flags in V8 using SetFlagFromString, which enforces the implications each time it is called. Therefore, if --turbo is enabled by default, and an unrelated flag is set, the turbo implications are enabled but not later disabled if we set --no-turbo. To fix this, add negative implications as well. BUG=chromium:692409 Change-Id: Iadb0ca542f49ba65c7419cda8c7a03636a8d5ba9 Reviewed-on: https://chromium-review.googlesource.com/451320 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#43655}
110 lines
2.1 KiB
JavaScript
110 lines
2.1 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --ignition --turbo
|
|
|
|
Debug = debug.Debug
|
|
|
|
var exception = null;
|
|
|
|
var o = { p : 1 };
|
|
|
|
var successes = [
|
|
[45,
|
|
`(function() {
|
|
var sum = 0;
|
|
for (var i = 0; i < 10; i++) sum += i;
|
|
return sum;
|
|
})()`
|
|
],
|
|
["0012",
|
|
`(function() {
|
|
var sum = 0;
|
|
for (var i in [1, 2, 3]) sum += i;
|
|
return sum;
|
|
})()`
|
|
],
|
|
[15,
|
|
`(function() {
|
|
var sum = 1;
|
|
while (sum < 12) sum += sum + 1;
|
|
return sum;
|
|
})()`
|
|
],
|
|
[15,
|
|
`(function() {
|
|
var sum = 1;
|
|
do { sum += sum + 1; } while (sum < 12);
|
|
return sum;
|
|
})()`
|
|
],
|
|
["023",
|
|
`(function() {
|
|
var sum = "";
|
|
for (var i = 0; i < 4; i++) {
|
|
switch (i) {
|
|
case 0:
|
|
case 1:
|
|
if (i == 0) sum += i;
|
|
break;
|
|
default:
|
|
case 3:
|
|
sum += i;
|
|
break;
|
|
}
|
|
}
|
|
return sum;
|
|
})()`
|
|
],
|
|
["oups",
|
|
`(function() {
|
|
try {
|
|
if (Math.sin(1) < 1) throw new Error("oups");
|
|
} catch (e) {
|
|
return e.message;
|
|
}
|
|
})()`
|
|
],
|
|
];
|
|
|
|
var fails = [
|
|
`(function() { // Iterator.prototype.next performs stores.
|
|
var sum = 0;
|
|
for (let i of [1, 2, 3]) sum += i;
|
|
return sum;
|
|
})()`,
|
|
`(function() { // Store to scope object.
|
|
with (o) {
|
|
p = 2;
|
|
}
|
|
})()`,
|
|
];
|
|
|
|
function listener(event, exec_state, event_data, data) {
|
|
if (event != Debug.DebugEvent.Break) return;
|
|
try {
|
|
successes.forEach(function ([expectation, source]) {
|
|
assertEquals(expectation,
|
|
exec_state.frame(0).evaluate(source, true).value());
|
|
});
|
|
fails.forEach(function (test) {
|
|
assertThrows(() => exec_state.frame(0).evaluate(test, true), EvalError);
|
|
});
|
|
} catch (e) {
|
|
exception = e;
|
|
print(e, e.stack);
|
|
};
|
|
};
|
|
|
|
// Add the debug event listener.
|
|
Debug.setListener(listener);
|
|
|
|
function f() {
|
|
debugger;
|
|
};
|
|
|
|
f();
|
|
|
|
assertNull(exception);
|