fb922b1764
We don't currently inline array builtins if we detect any side effects between the load of the receiver map and the call to the builtin. The introduction of a map check allows us to be more permissive. Bug: v8:7250 Change-Id: I6b3f9243f6506eff45c0d727c47a7e8cb8765640 Reviewed-on: https://chromium-review.googlesource.com/849005 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#50620}
38 lines
1.2 KiB
JavaScript
38 lines
1.2 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
(() => {
|
|
|
|
// Make sure we inline the callback, pick up all possible TurboFan
|
|
// optimizations.
|
|
function RunOptFastSome(multiple) {
|
|
// Use of variable multiple in the callback function forces
|
|
// context creation without escape analysis.
|
|
//
|
|
// Also, the arrow function requires inlining based on
|
|
// SharedFunctionInfo.
|
|
result = array.some((v, i, a) => multiple !== 3);
|
|
}
|
|
|
|
// Don't optimize because I want to optimize RunOptFastMap with a parameter
|
|
// to be used in the callback.
|
|
%NeverOptimizeFunction(OptFastSome);
|
|
function OptFastSome() { RunOptFastSome(3); }
|
|
|
|
function side_effect(a) { return a; }
|
|
%NeverOptimizeFunction(side_effect);
|
|
function OptUnreliableSome() {
|
|
result = array.some(func, side_effect(array));
|
|
}
|
|
|
|
DefineHigherOrderTests([
|
|
// name, test function, setup function, user callback
|
|
"DoubleSome", mc("some"), DoubleSetup, v => v < 0.0,
|
|
"SmiSome", mc("some"), SmiSetup, v => v === 34343,
|
|
"FastSome", mc("some"), FastSetup, v => v === 'hi',
|
|
"OptFastSome", OptFastSome, FastSetup, undefined,
|
|
"OptUnreliableSome", OptUnreliableSome, FastSetup, v => v === 'hi'
|
|
]);
|
|
|
|
})();
|