3e7e3ed726
* Add a sibling interface to InterpreterAssembler called CodeStubAssembler which provides a wrapper around the RawMachineAssembler and is intented to make it easy to build efficient cross-platform code stubs. Much of the implementation of CodeStubAssembler is shamelessly stolen from the InterpreterAssembler, and the idea is to eventually merge the two interfaces somehow, probably moving the InterpreterAssembler interface over to use the CodeStubAssembler. Short-term, however, the two interfaces shall remain decoupled to increase our velocity developing the two systems in parallel. * Implement the StringLength stub in TurboFan with the new CodeStubAssembler. Replace and remove the old Hydrogen-stub version. * Remove a whole slew of machinery to support JavaScript-style code stub generation, since it ultimately proved unwieldy, brittle and baroque. This cleanup includes removing the shared code stub context, several example stubs and a tangle of build file changes. BUG=v8:4587 LOG=n Review URL: https://codereview.chromium.org/1475953002 Cr-Commit-Position: refs/heads/master@{#32508}
73 lines
2.6 KiB
C++
73 lines
2.6 KiB
C++
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// TODO(jochen): Remove this after the setting is turned on globally.
|
|
#define V8_IMMINENT_DEPRECATION_WARNINGS
|
|
|
|
#include "src/bootstrapper.h"
|
|
#include "src/code-stubs.h"
|
|
#include "src/compiler/common-operator.h"
|
|
#include "src/compiler/graph.h"
|
|
#include "src/compiler/js-graph.h"
|
|
#include "src/compiler/js-operator.h"
|
|
#include "src/compiler/linkage.h"
|
|
#include "src/compiler/machine-operator.h"
|
|
#include "src/compiler/pipeline.h"
|
|
#include "src/parsing/parser.h"
|
|
#include "test/cctest/compiler/function-tester.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace compiler {
|
|
|
|
|
|
TEST(RunStringLengthStub) {
|
|
HandleAndZoneScope scope;
|
|
Isolate* isolate = scope.main_isolate();
|
|
Zone* zone = scope.main_zone();
|
|
|
|
// Create code and an accompanying descriptor.
|
|
StringLengthStub stub(isolate);
|
|
Handle<Code> code = stub.GenerateCode();
|
|
CompilationInfo info(&stub, isolate, zone);
|
|
CallDescriptor* descriptor = Linkage::ComputeIncoming(zone, &info);
|
|
|
|
// Create a function to call the code using the descriptor.
|
|
Graph graph(zone);
|
|
CommonOperatorBuilder common(zone);
|
|
// FunctionTester (ab)uses a 4-argument function
|
|
Node* start = graph.NewNode(common.Start(6));
|
|
// Parameter 0 is the receiver
|
|
Node* receiverParam = graph.NewNode(common.Parameter(1), start);
|
|
Node* nameParam = graph.NewNode(common.Parameter(2), start);
|
|
Node* slotParam = graph.NewNode(common.Parameter(3), start);
|
|
Node* vectorParam = graph.NewNode(common.Parameter(4), start);
|
|
Node* theCode = graph.NewNode(common.HeapConstant(code));
|
|
Node* dummyContext = graph.NewNode(common.NumberConstant(0.0));
|
|
Node* call =
|
|
graph.NewNode(common.Call(descriptor), theCode, receiverParam, nameParam,
|
|
slotParam, vectorParam, dummyContext, start, start);
|
|
Node* ret = graph.NewNode(common.Return(), call, call, start);
|
|
Node* end = graph.NewNode(common.End(1), ret);
|
|
graph.SetStart(start);
|
|
graph.SetEnd(end);
|
|
FunctionTester ft(&graph, 4);
|
|
|
|
// Actuall call through to the stub, verifying its result.
|
|
const char* testString = "Und das Lamm schrie HURZ!";
|
|
Handle<JSReceiver> receiverArg =
|
|
Object::ToObject(isolate, ft.Val(testString)).ToHandleChecked();
|
|
Handle<String> nameArg = ft.Val("length");
|
|
Handle<Object> slot = ft.Val(0.0);
|
|
Handle<Object> vector = ft.Val(0.0);
|
|
Handle<Object> result =
|
|
ft.Call(receiverArg, nameArg, slot, vector).ToHandleChecked();
|
|
CHECK_EQ(static_cast<int>(strlen(testString)), Smi::cast(*result)->value());
|
|
}
|
|
|
|
|
|
} // namespace compiler
|
|
} // namespace internal
|
|
} // namespace v8
|