Ben L. Titzer df8e617772 "Reland x3 [arraybuffer] Rearchitect backing store ownership" ... This is a reland of bc33f5aeba Original change's description: > [arraybuffer] Rearchitect backing store ownership > > This CL completely rearchitects the ownership of array buffer backing stores, > consolidating ownership into a {BackingStore} C++ object that is tracked > throughout V8 using unique_ptr and shared_ptr where appropriate. > > Overall, lifetime management is simpler and more explicit. The numerous > ways that array buffers were initialized have been streamlined to one > Attach() method on JSArrayBuffer. The array buffer tracker in the > GC implementation now manages std::shared_ptr<BackingStore> pointers, > and the construction and destruction of the BackingStore object itself > handles the underlying page or embedder-allocated memory. > > The embedder API remains unchanged for now. We use the > v8::ArrayBuffer::Contents struct to hide an additional shared_ptr to > keep the backing store alive properly, even in the case of aliases > from live heap objects. Thus the embedder has a lower chance of making > a mistake. Long-term, we should move the embedder to a model where they > manage backing stores using shared_ptr to an opaque backing store object. R=mlippautz@chromium.org BUG=v8:9380,v8:9221,chromium:986318 TBR=ulan@chromium.org Change-Id: I6c49e2425029b5664ef1c68dab8b5146f4ed0ff2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1719191 Reviewed-by: Ben Titzer <titzer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#63007}		2019-07-31 14:13:59 +00:00
..
arm	[cleanup] Replace function typedefs by using declarations	2019-05-28 08:35:08 +00:00
arm64	[ptr-compr][arm64] Use correct immediate range for kArchStoreWithBarrier.	2019-07-23 07:57:14 +00:00
backend	[csa] block cloning to optimize branch on phi	2019-07-30 10:30:29 +00:00
ia32	[cleanup] Replace simple typedefs by using	2019-05-27 12:39:49 +00:00
mips	Move architecture dependent files	2019-05-28 14:02:15 +00:00
mips64	Move architecture dependent files	2019-05-28 14:02:15 +00:00
ppc	Move code generation related files to src/codegen	2019-05-21 10:33:39 +00:00
regalloc	[regalloc] Rename --trace-alloc to --trace-turbo-alloc	2019-07-05 12:47:41 +00:00
s390	Move architecture dependent files	2019-05-28 14:02:15 +00:00
x64	[cleanup] Replace function typedefs by using declarations	2019-05-28 08:35:08 +00:00
branch-elimination-unittest.cc	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
bytecode-analysis-unittest.cc	[turbofan] Move bytecode analysis to the serializer	2019-07-15 12:41:57 +00:00
checkpoint-elimination-unittest.cc	[cleanup] Refactor compiler to use default members.	2018-09-17 12:12:21 +00:00
code-assembler-unittest.cc	Move more relevant files to src/objects	2019-05-23 08:52:30 +00:00
code-assembler-unittest.h	[cleanup] Refactor compiler to use default members.	2018-09-17 12:12:21 +00:00
common-operator-reducer-unittest.cc	[turbofan] Disentangle header include chains	2019-07-05 14:26:05 +00:00
common-operator-unittest.cc	test: Replace _TEST_CASE_ with _TEST_SUITE_.	2019-02-18 21:36:56 +00:00
compiler-test-utils.h
constant-folding-reducer-unittest.cc	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
control-equivalence-unittest.cc	Move utility code to src/utils	2019-05-23 14:13:34 +00:00
control-flow-optimizer-unittest.cc	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
dead-code-elimination-unittest.cc	[cleanup] Refactor compiler to use default members.	2018-09-17 12:12:21 +00:00
decompression-elimination-unittest.cc	[cleanup][ptr-compr][turbofan] DecompressionElimination test cleanup	2019-06-24 21:35:06 +00:00
diamond-unittest.cc	[cleanup] [compiler] Fix (D)CHECK macros	2017-09-25 10:21:34 +00:00
effect-control-linearizer-unittest.cc	[ptr-compr][cleanup] Removing the optimized map checks	2019-05-28 09:39:23 +00:00
graph-reducer-unittest.cc	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
graph-reducer-unittest.h
graph-trimmer-unittest.cc
graph-unittest.cc	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
graph-unittest.h	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
int64-lowering-unittest.cc	Move more relevant files to src/objects	2019-05-23 08:52:30 +00:00
js-call-reducer-unittest.cc	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
js-create-lowering-unittest.cc	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
js-intrinsic-lowering-unittest.cc	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
js-native-context-specialization-unittest.cc	Move number related files to src/numbers	2019-05-15 19:34:44 +00:00
js-operator-unittest.cc	test: Replace _TEST_CASE_ with _TEST_SUITE_.	2019-02-18 21:36:56 +00:00
js-typed-lowering-unittest.cc	"Reland x3 [arraybuffer] Rearchitect backing store ownership"	2019-07-31 14:13:59 +00:00
linkage-tail-call-unittest.cc	Reland "[arm64] Preparation for padding of arguments"	2017-12-20 13:50:36 +00:00
load-elimination-unittest.cc	Retire PretenureFlag and use AllocationType everywhere.	2019-03-12 08:10:44 +00:00
loop-peeling-unittest.cc	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
machine-operator-reducer-unittest.cc	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
machine-operator-unittest.cc	[cleanup] Replace simple typedefs by using	2019-05-27 12:39:49 +00:00
node-cache-unittest.cc	[cleanup] Replace simple typedefs by using	2019-05-27 12:39:49 +00:00
node-matchers-unittest.cc	[cleanup] Refactor compiler to use default members.	2018-09-17 12:12:21 +00:00
node-properties-unittest.cc	[jumbo] add unittests jumbo support	2017-09-28 22:19:40 +00:00
node-test-utils.cc	Reland "[csa] Tweak CSA pipeline to eliminate more redundant checks"	2019-06-17 09:40:29 +00:00
node-test-utils.h	Reland "[csa] Tweak CSA pipeline to eliminate more redundant checks"	2019-06-17 09:40:29 +00:00
node-unittest.cc	[cleanup] Replace simple typedefs by using	2019-05-27 12:39:49 +00:00
opcodes-unittest.cc	[ubsan][compiler] Avoid out-of-range casts to IrOpcode::Value	2019-01-25 20:55:25 +00:00
persistent-unittest.cc	[ubsan] Fix numerical overflows in the compiler	2019-01-10 11:17:37 +00:00
redundancy-elimination-unittest.cc	[ptr-compr] Add CheckedInt32ToCompressedSigned and use it	2019-07-23 13:19:55 +00:00
schedule-unittest.cc	[cleanup] Replace simple typedefs by using	2019-05-27 12:39:49 +00:00
scheduler-rpo-unittest.cc	[cleanup] Refactor compiler to use default members.	2018-09-17 12:12:21 +00:00
scheduler-unittest.cc	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
simplified-lowering-unittest.cc	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
simplified-operator-reducer-unittest.cc	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
simplified-operator-unittest.cc	[ptr-compr] Specialize CompressedSigned -> Word32 conversion	2019-07-08 12:21:58 +00:00
state-values-utils-unittest.cc	Move utility code to src/utils	2019-05-23 14:13:34 +00:00
typed-optimization-unittest.cc	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
typer-unittest.cc	[turbofan] Disentangle header include chains	2019-07-05 14:26:05 +00:00
value-numbering-reducer-unittest.cc	[jumbo] fix another set of unittest compilation errors	2017-10-19 09:15:44 +00:00
zone-stats-unittest.cc	[cleanup] Don't use virtual inheritance in gtest fixtures	2018-10-30 06:28:42 +00:00