6956c02c8e
This reverts commit f8962ae1a2.
Reason for revert: breaks Arm bots, e.g. https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Arm/9655, task: https://chromium-swarm.appspot.com/task?d=true&id=431dfa503db16d10
Original change's description:
> Preparing v8 to use with python3 /test
>
> There are now less that 400 days until the end of life
> of Python 2(aka _legacy_ Python) https://pythonclock.org/ .
> The code compatibility check for python2 and python3
> used the following tools: futurize, flake8
> You can see the reports here: https://travis-ci.com/bmsdave/v8/builds
>
> This CL was uploaded by git cl split.
>
> Bug: v8:8594
> Change-Id: Idbf467daf629a4e808345a6a88036c2a3f259138
> Reviewed-on: https://chromium-review.googlesource.com/c/1470121
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59679}
TBR=machenbach@chromium.org,sergiyb@chromium.org,herhut@chromium.org,bmsdave@gmail.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: v8:8594
Change-Id: I17a0a7b203fa2c0ab0f965240ee1415b7513e1cf
Reviewed-on: https://chromium-review.googlesource.com/c/1478692
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59725}
83 lines
2.2 KiB
Python
83 lines
2.2 KiB
Python
# Copyright 2017 the V8 project authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
import os
|
|
|
|
from testrunner.local import command
|
|
from testrunner.local import utils
|
|
from testrunner.local import testsuite
|
|
from testrunner.objects import testcase
|
|
|
|
|
|
class VariantsGenerator(testsuite.VariantsGenerator):
|
|
def _get_variants(self, test):
|
|
return self._standard_variant
|
|
|
|
|
|
class TestLoader(testsuite.TestLoader):
|
|
def _list_test_filenames(self):
|
|
shell = os.path.abspath(
|
|
os.path.join(self.test_config.shell_dir, "unittests"))
|
|
if utils.IsWindows():
|
|
shell += ".exe"
|
|
|
|
output = None
|
|
for i in xrange(3): # Try 3 times in case of errors.
|
|
cmd = command.Command(
|
|
cmd_prefix=self.test_config.command_prefix,
|
|
shell=shell,
|
|
args=['--gtest_list_tests'] + self.test_config.extra_flags)
|
|
output = cmd.execute()
|
|
if output.exit_code == 0:
|
|
break
|
|
|
|
print "Test executable failed to list the tests (try %d).\n\nCmd:" % i
|
|
print cmd
|
|
print "\nStdout:"
|
|
print output.stdout
|
|
print "\nStderr:"
|
|
print output.stderr
|
|
print "\nExit code: %d" % output.exit_code
|
|
else:
|
|
raise Exception("Test executable failed to list the tests.")
|
|
|
|
# TODO create an ExecutableTestLoader for refactoring this similar to
|
|
# JSTestLoader.
|
|
test_names = []
|
|
for line in output.stdout.splitlines():
|
|
test_desc = line.strip().split()[0]
|
|
if test_desc.endswith('.'):
|
|
test_case = test_desc
|
|
elif test_case and test_desc:
|
|
test_names.append(test_case + test_desc)
|
|
|
|
return sorted(test_names)
|
|
|
|
|
|
class TestSuite(testsuite.TestSuite):
|
|
def _test_loader_class(self):
|
|
return TestLoader
|
|
|
|
def _test_class(self):
|
|
return TestCase
|
|
|
|
def _variants_gen_class(self):
|
|
return VariantsGenerator
|
|
|
|
|
|
class TestCase(testcase.TestCase):
|
|
def _get_suite_flags(self):
|
|
return (
|
|
["--gtest_filter=" + self.path] +
|
|
["--gtest_random_seed=%s" % self.random_seed] +
|
|
["--gtest_print_time=0"]
|
|
)
|
|
|
|
def get_shell(self):
|
|
return self.suite.name
|
|
|
|
|
|
def GetSuite(*args, **kwargs):
|
|
return TestSuite(*args, **kwargs)
|