4fc90a2597
This CL refactors the existing trap handler code for Linux to allow a cleaner extension to Windows. 1) The CL extracts platform-specific code into separate files, see https://docs.google.com/document/d/1HCgKIpdjy_CEodTLvZ5VuykDI6gGTHrTtau2j0zwm28. Specifically this means: * Move posix-specific API functions from v8.h to v8-wasm-trap-handler-posix.h. Deprecate the existing TryHandleSignal API function. * Move posix-specific function declarations from trap-handler-internal.h to handler-inside-posix.h * Move posix-specific function definitions from handler-shared.cc to handler-outside-posix.cc 2) The CL changes filenames from *-linux.* to *-posix.*. I expect that most of the implementation for MacOS will be the same as for Linux. Bug: v8:6743 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I4bb7f199564a2f01042084d15a82311d11a93c7b Reviewed-on: https://chromium-review.googlesource.com/c/1280324 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#57028}
71 lines
2.0 KiB
C++
71 lines
2.0 KiB
C++
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/trap-handler/trap-handler.h"
|
|
#include "include/v8.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
#if V8_OS_POSIX
|
|
#include <setjmp.h>
|
|
#include <signal.h>
|
|
#endif
|
|
|
|
namespace {
|
|
|
|
#if V8_TRAP_HANDLER_SUPPORTED
|
|
|
|
void CrashOnPurpose() { *reinterpret_cast<volatile int*>(42); }
|
|
|
|
// When using V8::RegisterDefaultSignalHandler, we save the old one to fall back
|
|
// on if V8 doesn't handle the signal. This allows tools like ASan to register a
|
|
// handler early on during the process startup and still generate stack traces
|
|
// on failures.
|
|
class SignalHandlerFallbackTest : public ::testing::Test {
|
|
protected:
|
|
void SetUp() override {
|
|
struct sigaction action;
|
|
action.sa_sigaction = SignalHandler;
|
|
sigemptyset(&action.sa_mask);
|
|
action.sa_flags = SA_SIGINFO;
|
|
sigaction(SIGSEGV, &action, &old_segv_action_);
|
|
sigaction(SIGBUS, &action, &old_bus_action_);
|
|
}
|
|
|
|
void TearDown() override {
|
|
// be a good citizen and restore the old signal handler.
|
|
sigaction(SIGSEGV, &old_segv_action_, nullptr);
|
|
sigaction(SIGBUS, &old_bus_action_, nullptr);
|
|
}
|
|
|
|
static sigjmp_buf continuation_;
|
|
|
|
private:
|
|
static void SignalHandler(int signal, siginfo_t* info, void*) {
|
|
siglongjmp(continuation_, 1);
|
|
}
|
|
struct sigaction old_segv_action_;
|
|
struct sigaction old_bus_action_; // We get SIGBUS on Mac sometimes.
|
|
};
|
|
sigjmp_buf SignalHandlerFallbackTest::continuation_;
|
|
|
|
TEST_F(SignalHandlerFallbackTest, DoTest) {
|
|
const int save_sigs = 1;
|
|
if (!sigsetjmp(continuation_, save_sigs)) {
|
|
constexpr bool use_default_signal_handler = true;
|
|
CHECK(v8::V8::EnableWebAssemblyTrapHandler(use_default_signal_handler));
|
|
CrashOnPurpose();
|
|
FAIL();
|
|
} else {
|
|
// Our signal handler ran.
|
|
v8::internal::trap_handler::RemoveTrapHandler();
|
|
SUCCEED();
|
|
return;
|
|
}
|
|
FAIL();
|
|
}
|
|
|
|
#endif
|
|
|
|
} // namespace
|