v8/default-parameter-tdz-arrow.out at e17ea8ddf2b1d4e45d8d010638684850460b2e47 - v8 - Reeces Git

AuroraMiddleware/v8

adamk b6e9f625c1 [es6] Self-assignment in a default parameter initializer should throw

The first bug was that there are two different "initialization positions"
passed into PatternRewriter::DeclareAndInitializeVariables, and we weren't
setting them all properly for this case.

After further code review, it became clear that we weren't even recording
the correct position (the end of the initializer expression).

The combination of those two bugs caused the hole check elimination code
in full-codegen to skip emitting a hole check.

This patch takes care of both of those things. A follow-up will try
to reduce the number of "initializer positions" we track in the
variable declaration code.

R=littledan@chromium.org
BUG=v8:4568
LOG=n

Review URL: https://codereview.chromium.org/1468143004

Cr-Commit-Position: refs/heads/master@{#32237}

2015-11-25 01:30:39 +00:00

7 lines

160 B

Plaintext

Raw Blame History

 *%(basename)s:7: ReferenceError: a is not defined
 ((a=-a) => { })();
      ^
 ReferenceError: a is not defined
     at *%(basename)s:7:6
     at *%(basename)s:7:16