16b0767adc
In case there's no exact match for the breakable location in SetBreakpoint(), don't try to find the syntactically closest break location, but rather find the first possible break location in bytecode order. In particular when trying to set a breakpoint in a line with for-of or an array destruction, there's no point in going for the syntactically closest to the beginning of the line, but rather go for the semantically first, as the intiution for setting a breakpoint on a line is that the debugger stops before it executes anything on said line. In the example ``` var [^a, ^b] = ^func(); ``` there are three possible break locations, and the correct one is the last one as the call to func will happen first at runtime. For generators that's currently broken because of the implicit initial yield, and same with modules (see crbug.com/901819), so we keep the previous behavior of finding the closest breakable location, and will fix that independently in a follow up CL. Bug: chromium:901819 Fixed: chromium:782461 Also-By: yangguo@chromium.org Change-Id: Ie724c5cb08e5f4edd90a450d99e001dff06bbe7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2696586 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#72813}
48 lines
1.5 KiB
JavaScript
48 lines
1.5 KiB
JavaScript
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
let {session, contextGroup, Protocol} =
|
|
InspectorTest.start('Tests breakable locations in destructuring.');
|
|
|
|
let source = `
|
|
function testFunction() {
|
|
function func() {
|
|
return [1, 2];
|
|
}
|
|
|
|
var [a, b] = func();
|
|
}
|
|
//# sourceURL=test.js`;
|
|
|
|
contextGroup.addScript(source);
|
|
session.setupScriptMap();
|
|
|
|
InspectorTest.runAsyncTestSuite([
|
|
async function testBreakLocations() {
|
|
Protocol.Debugger.enable();
|
|
let {params:{scriptId}} = await Protocol.Debugger.onceScriptParsed();
|
|
let {result:{locations}} = await Protocol.Debugger.getPossibleBreakpoints({
|
|
start: {lineNumber: 0, columnNumber : 0, scriptId}});
|
|
await session.logBreakLocations(locations);
|
|
},
|
|
|
|
async function testSetBreakpoint() {
|
|
const SOURCE_LOCATIONS = [
|
|
{lineNumber: 6, columnNumber: 0},
|
|
{lineNumber: 6, columnNumber: 7},
|
|
{lineNumber: 6, columnNumber: 10},
|
|
{lineNumber: 6, columnNumber: 15},
|
|
];
|
|
for (const {lineNumber, columnNumber} of SOURCE_LOCATIONS) {
|
|
const url = 'test.js';
|
|
InspectorTest.log(`Setting breakpoint at ${url}:${lineNumber}:${columnNumber}`);
|
|
const {result: {breakpointId, locations}} = await Protocol.Debugger.setBreakpointByUrl({
|
|
lineNumber, columnNumber, url
|
|
});
|
|
locations.forEach(location => session.logSourceLocation(location));
|
|
await Protocol.Debugger.removeBreakpoint({breakpointId});
|
|
}
|
|
}
|
|
]);
|