5e2c23e2d3
For desrtucturing assignments from null/undefined, we throw an error
that references the destructuring object literal's property name, e.g.
for
var { x } = null;
we report that we cannot destructure 'x' from null.
Rather than calculating this property during bytecode generation (and
including it in the bytecode as an argument to the type error
constructor), we can calculate it at exception throwing time, by
re-parsing the source in a similar way to the existing call site
rendering.
This slightly decreases bytecode size and slightly decreases the amount
of work the bytecode compiler needs to do. In the future, it could also
allow us to give more detailed error messages, as we now have access to
the entire AST and are on the slow path anyway.
Bug: v8:6499
Change-Id: Icdbd4667db548b4e5e62ef97797a3771b5c1bf72
Reviewed-on: https://chromium-review.googlesource.com/c/1396080
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58706}
|
||
|---|---|---|
| .. | ||
| bytecode_expectations | ||
| bytecode-expectations-printer.cc | ||
| bytecode-expectations-printer.h | ||
| generate-bytecode-expectations.cc | ||
| interpreter-tester.cc | ||
| interpreter-tester.h | ||
| source-position-matcher.cc | ||
| source-position-matcher.h | ||
| test-bytecode-generator.cc | ||
| test-interpreter-intrinsics.cc | ||
| test-interpreter.cc | ||
| test-source-positions.cc | ||