aa4ee8d534
Currently, feedback vectors are allocated on a fixed budget of 1024. In some cases it might be beneficial to allocate feedback vectors based on invocation count rather than fixed budget. For example, if we have a large function that is only run once. This cl adds an option to use interrupt budget based on the bytecode size. It kind of mimics invocation count. We would allocate feedback vectors early when we have loops which is also required. This flag is turned off by default. In followup cl, we will enable it and if the memory / performance tradeoff is good we might make it default. Change-Id: I9f7231119b5fd65fb3268e665e2e315fb2625e1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584960 Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#72371}
88 lines
3.4 KiB
JavaScript
88 lines
3.4 KiB
JavaScript
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// Flags: --allow-natives-syntax --opt --noalways-opt
|
|
|
|
function check(func, input, expected) {
|
|
%PrepareFunctionForOptimization(func);
|
|
func(-1);
|
|
func(-1);
|
|
%OptimizeFunctionOnNextCall(func);
|
|
assertEquals(expected, func(input));
|
|
assertOptimized(func);
|
|
}
|
|
|
|
function mul_by_neg_1(a) { return a * -1; }
|
|
function mul_by_0(a) { return a * 0; }
|
|
function mul_by_1(a) { return a * 1; }
|
|
function mul_by_2(a) { return a * 2; }
|
|
|
|
check(mul_by_neg_1, 2, -2);
|
|
check(mul_by_0, 2, 0);
|
|
check(mul_by_1, 2, 2);
|
|
check(mul_by_2, 2, 4);
|
|
|
|
function limit_range(a) {
|
|
// Limit the range of 'a' to enable no-overflow optimizations.
|
|
return Math.max(Math.min(a | 0, 10), -10);
|
|
}
|
|
%EnsureFeedbackVectorForFunction(limit_range);
|
|
|
|
function mul_by_neg_127(a) { return limit_range(a) * -127; }
|
|
function mul_by_neg_128(a) { return limit_range(a) * -128; }
|
|
function mul_by_neg_129(a) { return limit_range(a) * -129; }
|
|
function mul_by_1023(a) { return limit_range(a) * 1023; }
|
|
function mul_by_1024(a) { return limit_range(a) * 1024; }
|
|
function mul_by_1025(a) { return limit_range(a) * 1025; }
|
|
|
|
check(mul_by_neg_127, 2, -254);
|
|
check(mul_by_neg_128, 2, -256);
|
|
check(mul_by_neg_129, 2, -258);
|
|
check(mul_by_1023, 2, 2046);
|
|
check(mul_by_1024, 2, 2048);
|
|
check(mul_by_1025, 2, 2050);
|
|
|
|
// Deopt on minus zero.
|
|
assertEquals(-0, mul_by_neg_128(0));
|
|
assertUnoptimized(mul_by_neg_128);
|
|
assertEquals(-0, mul_by_2(-0));
|
|
assertUnoptimized(mul_by_2);
|
|
|
|
// Deopt on overflow.
|
|
|
|
// -2^30 is in Smi range on most configurations, +2^30 is not.
|
|
var two_30 = 1 << 30;
|
|
assertEquals(two_30, mul_by_neg_1(-two_30));
|
|
|
|
// For good measure, check that overflowing int32 range (or Smi range
|
|
// without pointer compression) works too.
|
|
var two_31 = two_30 * 2;
|
|
assertEquals(two_31, mul_by_neg_1(-two_31));
|
|
|
|
// One of the two situations deoptimized the code.
|
|
assertUnoptimized(mul_by_neg_1);
|