822be9b238
This patch normalizes the casing of hexadecimal digits in escape sequences of the form `\xNN` and integer literals of the form `0xNNNN`. Previously, the V8 code base used an inconsistent mixture of uppercase and lowercase. Google’s C++ style guide uses uppercase in its examples: https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters Moreover, uppercase letters more clearly stand out from the lowercase `x` (or `u`) characters at the start, as well as lowercase letters elsewhere in strings. BUG=v8:7109 TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org NOPRESUBMIT=true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6 Reviewed-on: https://chromium-review.googlesource.com/804294 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49810}
33 lines
924 B
C
33 lines
924 B
C
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_CCTEST_UNICODE_HELPERS_H_
|
|
#define V8_CCTEST_UNICODE_HELPERS_H_
|
|
|
|
#include "src/unicode.h"
|
|
|
|
static int Ucs2CharLength(unibrow::uchar c) {
|
|
if (c == unibrow::Utf8::kIncomplete || c == unibrow::Utf8::kBufferEmpty) {
|
|
return 0;
|
|
} else if (c < 0xFFFF) {
|
|
return 1;
|
|
} else {
|
|
return 2;
|
|
}
|
|
}
|
|
|
|
static int Utf8LengthHelper(const char* s) {
|
|
unibrow::Utf8::Utf8IncrementalBuffer buffer(unibrow::Utf8::kBufferEmpty);
|
|
int length = 0;
|
|
for (; *s != '\0'; s++) {
|
|
unibrow::uchar tmp = unibrow::Utf8::ValueOfIncremental(*s, &buffer);
|
|
length += Ucs2CharLength(tmp);
|
|
}
|
|
unibrow::uchar tmp = unibrow::Utf8::ValueOfIncrementalFinish(&buffer);
|
|
length += Ucs2CharLength(tmp);
|
|
return length;
|
|
}
|
|
|
|
#endif // V8_CCTEST_UNICODE_HELPERS_H_
|