5696b52624
We currently have a BitVector implementation which is used a lot by the two (mid-tier and top-tier) register allocators. Their size is the number of virtual registers or the number of blocks in the function. If one of those numbers gets huge, the BitVector does not perform well any more, and it consumes huge amounts of memory (we see up to several GBs for huge Wasm functions). This CL introduces a SparseBitVector implementation with a compatible interface, meant to replace the BitVector implementation. Usages will be introduced in follow-up CLs, first for the mid-tier allocator, then top-tier. This will allow us to assess performance changes better, and revert individual usages. R=mslekova@chromium.org Bug: chromium:1313379, v8:12780 Change-Id: I804311e0c188526961f70e88a43dd1ea26497cda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3634780 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#80546}
97 lines
2.9 KiB
C++
97 lines
2.9 KiB
C++
// Copyright 2022 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/utils/sparse-bit-vector.h"
|
|
|
|
#include <vector>
|
|
|
|
#include "test/unittests/test-utils.h"
|
|
#include "testing/gmock-support.h"
|
|
#include "testing/gtest-support.h"
|
|
|
|
namespace v8::internal {
|
|
|
|
using ::testing::ElementsAre;
|
|
|
|
namespace {
|
|
class SparseBitVectorBuilder {
|
|
public:
|
|
MOVE_ONLY_NO_DEFAULT_CONSTRUCTOR(SparseBitVectorBuilder);
|
|
|
|
explicit SparseBitVectorBuilder(Zone* zone) : vector_(zone) {}
|
|
|
|
template <typename... Ts>
|
|
SparseBitVectorBuilder& Add(Ts... values) {
|
|
(vector_.Add(values), ...);
|
|
return *this;
|
|
}
|
|
|
|
template <typename... Ts>
|
|
SparseBitVectorBuilder& Remove(Ts... values) {
|
|
(vector_.Remove(values), ...);
|
|
return *this;
|
|
}
|
|
|
|
std::vector<int> ToStdVector() const {
|
|
return std::vector<int>(vector_.begin(), vector_.end());
|
|
}
|
|
|
|
SparseBitVector get() { return std::move(vector_); }
|
|
|
|
private:
|
|
SparseBitVector vector_;
|
|
};
|
|
} // namespace
|
|
|
|
class SparseBitVectorTest : public TestWithZone {
|
|
public:
|
|
SparseBitVectorBuilder B() { return SparseBitVectorBuilder{zone()}; }
|
|
|
|
template <typename... Ts>
|
|
SparseBitVector Make(Ts... values) {
|
|
return B().Add(values...).get();
|
|
}
|
|
|
|
template <typename... Ts>
|
|
std::vector<int> VectorOf(Ts... values) {
|
|
return B().Add(values...).ToStdVector();
|
|
}
|
|
};
|
|
|
|
TEST_F(SparseBitVectorTest, ConstructionAndIteration) {
|
|
EXPECT_THAT(VectorOf(0, 2, 4), ElementsAre(0, 2, 4));
|
|
EXPECT_THAT(VectorOf(2000, 8000, 6000, 10000),
|
|
ElementsAre(2000, 6000, 8000, 10000));
|
|
EXPECT_THAT(VectorOf(0, 2, 2, 0, 4, 2, 4), ElementsAre(0, 2, 4));
|
|
EXPECT_THAT(VectorOf(7, 15, 31, 63, 127, 255),
|
|
ElementsAre(7, 15, 31, 63, 127, 255));
|
|
EXPECT_THAT(VectorOf(255, 127, 63, 31, 15, 7),
|
|
ElementsAre(7, 15, 31, 63, 127, 255));
|
|
}
|
|
|
|
TEST_F(SparseBitVectorTest, Contains) {
|
|
EXPECT_TRUE(Make(0, 2, 4).Contains(0));
|
|
EXPECT_FALSE(Make(0, 2, 4).Contains(1));
|
|
EXPECT_TRUE(Make(0, 2, 4).Contains(2));
|
|
EXPECT_FALSE(Make(0, 2, 4).Contains(3));
|
|
EXPECT_TRUE(Make(0, 2, 4).Contains(4));
|
|
EXPECT_TRUE(Make(2000, 8000, 6000, 10000).Contains(6000));
|
|
}
|
|
|
|
TEST_F(SparseBitVectorTest, Remove) {
|
|
EXPECT_THAT(B().Add(0, 2, 4).Remove(0).ToStdVector(), ElementsAre(2, 4));
|
|
EXPECT_THAT(B().Add(0, 2, 4).Remove(1).ToStdVector(), ElementsAre(0, 2, 4));
|
|
EXPECT_THAT(B().Add(0, 2, 4).Remove(2).ToStdVector(), ElementsAre(0, 4));
|
|
EXPECT_THAT(B().Add(0, 2, 4).Remove(3).ToStdVector(), ElementsAre(0, 2, 4));
|
|
EXPECT_THAT(B().Add(0, 2, 4).Remove(4).ToStdVector(), ElementsAre(0, 2));
|
|
EXPECT_THAT(B().Add(2000, 8000, 6000).Remove(kMaxInt).ToStdVector(),
|
|
ElementsAre(2000, 6000, 8000));
|
|
EXPECT_THAT(B().Add(2000, 8000, 6000).Remove(8000).ToStdVector(),
|
|
ElementsAre(2000, 6000));
|
|
EXPECT_THAT(B().Add(2000, 8000, 6000).Remove(2000).ToStdVector(),
|
|
ElementsAre(6000, 8000));
|
|
}
|
|
|
|
} // namespace v8::internal
|