0ea5b5248d
When looking for private members in an object for the inspector, we check if that object is a class constructor with the a bit has_static_private_methods set on its SFI. If it is, we look for any variables in the context locals with a VariableMode associated with private methods or accessors and a IsStaticFlag being kStatic. This patch also filters out static private methods when inspecting instances. Design doc: https://docs.google.com/document/d/1N91LObhQexnB0eE7EvGe57HsvNMFX16CaWu-XCTnnmY/edit See also: https://docs.google.com/document/d/14maU596YbHcWR7XR-_iXM_ANhAAmiuRlJZysM61lqaE/edit Bug: v8:9839, v8:8330 Change-Id: Idad15349c983898de2ce632c38b0174da10e639d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955664 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/master@{#66636}
64 lines
1.8 KiB
JavaScript
64 lines
1.8 KiB
JavaScript
// Copyright 2020 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --harmony-private-methods
|
|
|
|
let { session, contextGroup, Protocol } = InspectorTest.start(
|
|
"Test static private class methods"
|
|
);
|
|
|
|
const script = `
|
|
function run() {
|
|
class A {
|
|
static #method() {
|
|
debugger;
|
|
}
|
|
static test() {
|
|
class B {
|
|
static test() { debugger; }
|
|
}
|
|
A.#method(); // reference #method so it shows up
|
|
B.test();
|
|
}
|
|
}
|
|
A.test();
|
|
}`;
|
|
|
|
contextGroup.addScript(script);
|
|
|
|
InspectorTest.runAsyncTestSuite([
|
|
async function testScopesPaused() {
|
|
Protocol.Debugger.enable();
|
|
|
|
// Do not await here, instead oncePaused should be awaited.
|
|
Protocol.Runtime.evaluate({ expression: 'run()' });
|
|
|
|
InspectorTest.log('privateProperties on class A');
|
|
let {
|
|
params: { callFrames }
|
|
} = await Protocol.Debugger.oncePaused(); // inside A.#method()
|
|
// TODO(joyee): make it possible to desugar the brand check, which requires
|
|
// the class variable to be saved, even when the static private
|
|
// methods/accessors are not referenced in the class body.
|
|
let frame = callFrames[0];
|
|
let { result } = await Protocol.Runtime.getProperties({
|
|
objectId: frame.this.objectId
|
|
});
|
|
InspectorTest.logObject(result.privateProperties);
|
|
Protocol.Debugger.resume();
|
|
|
|
({ params: { callFrames } } = await Protocol.Debugger.oncePaused()); // B.test();
|
|
frame = callFrames[0];
|
|
|
|
InspectorTest.log('privateProperties on class B');
|
|
({ result } = await Protocol.Runtime.getProperties({
|
|
objectId: frame.this.objectId
|
|
}));
|
|
InspectorTest.logObject(result.privateProperties);
|
|
|
|
Protocol.Debugger.resume();
|
|
Protocol.Debugger.disable();
|
|
}
|
|
]);
|