e8dd6981ca
The Tracing split CL https://codereview.chromium.org/1707563002 mostly moved the location of the TRACE call, but it added 2 very high frequency calls related to tracking V8.External. In most benchmark and devices the added overhead is negligible except on N6 where it gets amplified. This CL removes those 2 calls until more efficient tracing or a different technique is used. BUG=588137 LOG=N Review URL: https://codereview.chromium.org/1765673003 Cr-Commit-Position: refs/heads/master@{#34499}
93 lines
2.5 KiB
C++
93 lines
2.5 KiB
C++
// Copyright 2010 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_VM_STATE_INL_H_
|
|
#define V8_VM_STATE_INL_H_
|
|
|
|
#include "src/vm-state.h"
|
|
#include "src/log.h"
|
|
#include "src/simulator.h"
|
|
#include "src/tracing/trace-event.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
//
|
|
// VMState class implementation. A simple stack of VM states held by the
|
|
// logger and partially threaded through the call stack. States are pushed by
|
|
// VMState construction and popped by destruction.
|
|
//
|
|
inline const char* StateToString(StateTag state) {
|
|
switch (state) {
|
|
case JS:
|
|
return "JS";
|
|
case GC:
|
|
return "GC";
|
|
case COMPILER:
|
|
return "COMPILER";
|
|
case OTHER:
|
|
return "OTHER";
|
|
case EXTERNAL:
|
|
return "EXTERNAL";
|
|
default:
|
|
UNREACHABLE();
|
|
return NULL;
|
|
}
|
|
}
|
|
|
|
|
|
template <StateTag Tag>
|
|
VMState<Tag>::VMState(Isolate* isolate)
|
|
: isolate_(isolate), previous_tag_(isolate->current_vm_state()) {
|
|
if (FLAG_log_timer_events && previous_tag_ != EXTERNAL && Tag == EXTERNAL) {
|
|
LOG(isolate_, TimerEvent(Logger::START, TimerEventExternal::name()));
|
|
}
|
|
isolate_->set_current_vm_state(Tag);
|
|
}
|
|
|
|
|
|
template <StateTag Tag>
|
|
VMState<Tag>::~VMState() {
|
|
if (FLAG_log_timer_events && previous_tag_ != EXTERNAL && Tag == EXTERNAL) {
|
|
LOG(isolate_, TimerEvent(Logger::END, TimerEventExternal::name()));
|
|
}
|
|
isolate_->set_current_vm_state(previous_tag_);
|
|
}
|
|
|
|
ExternalCallbackScope::ExternalCallbackScope(Isolate* isolate, Address callback)
|
|
: isolate_(isolate),
|
|
callback_(callback),
|
|
previous_scope_(isolate->external_callback_scope()),
|
|
timer_(&isolate->counters()->runtime_call_stats()->ExternalCallback,
|
|
isolate->counters()->runtime_call_stats()->current_timer()) {
|
|
#ifdef USE_SIMULATOR
|
|
scope_address_ = Simulator::current(isolate)->get_sp();
|
|
#endif
|
|
isolate_->set_external_callback_scope(this);
|
|
if (FLAG_runtime_call_stats) {
|
|
isolate_->counters()->runtime_call_stats()->Enter(&timer_);
|
|
}
|
|
}
|
|
|
|
ExternalCallbackScope::~ExternalCallbackScope() {
|
|
if (FLAG_runtime_call_stats) {
|
|
isolate_->counters()->runtime_call_stats()->Leave(&timer_);
|
|
}
|
|
isolate_->set_external_callback_scope(previous_scope_);
|
|
}
|
|
|
|
Address ExternalCallbackScope::scope_address() {
|
|
#ifdef USE_SIMULATOR
|
|
return scope_address_;
|
|
#else
|
|
return reinterpret_cast<Address>(this);
|
|
#endif
|
|
}
|
|
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif // V8_VM_STATE_INL_H_
|