9f04d73350
Address http://code.google.com/p/chromium/issues/detail?id=69187 by instead ignoring getters on ReferenceError.prototype.name in Error.prototype.toString. And while we're at it, do the same for SyntaxError and TypeError, and the properties "message", "type", and "arguments" on all of them, which potentially have similar issues. R=danno@chromium.org BUG=69187 TEST= Review URL: https://chromiumcodereview.appspot.com/10234004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11529 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
118 lines
4.9 KiB
JavaScript
118 lines
4.9 KiB
JavaScript
// Copyright 2011 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
|
|
// Check that message and name are not enumerable on Error objects.
|
|
var desc = Object.getOwnPropertyDescriptor(Error.prototype, 'name');
|
|
assertFalse(desc['enumerable']);
|
|
desc = Object.getOwnPropertyDescriptor(Error.prototype, 'message');
|
|
assertFalse(desc['enumerable']);
|
|
|
|
var e = new Error("foobar");
|
|
desc = Object.getOwnPropertyDescriptor(e, 'message');
|
|
assertFalse(desc['enumerable']);
|
|
desc = Object.getOwnPropertyDescriptor(e, 'arguments');
|
|
assertFalse(desc['enumerable']);
|
|
desc = Object.getOwnPropertyDescriptor(e, 'type');
|
|
assertFalse(desc['enumerable']);
|
|
desc = Object.getOwnPropertyDescriptor(e, 'stack');
|
|
assertFalse(desc['enumerable']);
|
|
|
|
var e = new Error();
|
|
assertFalse(e.hasOwnProperty('message'));
|
|
|
|
// name is not tested above, but in addition we should have no enumerable
|
|
// properties, so we simply assert that.
|
|
for (var v in e) {
|
|
assertUnreachable();
|
|
}
|
|
|
|
// Check that error construction does not call setters for the
|
|
// properties on error objects in prototypes.
|
|
function fail() { assertUnreachable(); };
|
|
ReferenceError.prototype.__defineSetter__('name', fail);
|
|
ReferenceError.prototype.__defineSetter__('message', fail);
|
|
ReferenceError.prototype.__defineSetter__('type', fail);
|
|
ReferenceError.prototype.__defineSetter__('arguments', fail);
|
|
ReferenceError.prototype.__defineSetter__('stack', fail);
|
|
|
|
var e = new ReferenceError();
|
|
assertTrue(e.hasOwnProperty('stack'));
|
|
assertTrue(e.hasOwnProperty('type'));
|
|
assertTrue(e.hasOwnProperty('arguments'));
|
|
|
|
var e = new ReferenceError('123');
|
|
assertTrue(e.hasOwnProperty('message'));
|
|
assertTrue(e.hasOwnProperty('stack'));
|
|
assertTrue(e.hasOwnProperty('type'));
|
|
assertTrue(e.hasOwnProperty('arguments'));
|
|
|
|
var e = %MakeReferenceError("my_test_error", [0, 1]);
|
|
assertTrue(e.hasOwnProperty('stack'));
|
|
assertTrue(e.hasOwnProperty('type'));
|
|
assertTrue(e.hasOwnProperty('arguments'));
|
|
assertEquals("my_test_error", e.type)
|
|
|
|
// Check that intercepting property access from toString is prevented for
|
|
// compiler errors. This is not specified, but allowing interception
|
|
// through a getter can leak error objects from different
|
|
// script tags in the same context in a browser setting.
|
|
var errors = [SyntaxError, ReferenceError, TypeError];
|
|
for (var i in errors) {
|
|
var name = errors[i].prototype.toString();
|
|
// Monkey-patch prototype.
|
|
var props = ["name", "message", "type", "arguments", "stack"];
|
|
for (var j in props) {
|
|
errors[i].prototype.__defineGetter__(props[j], fail);
|
|
}
|
|
// String conversion should not invoke monkey-patched getters on prototype.
|
|
var e = new errors[i];
|
|
assertEquals(name, e.toString());
|
|
// Custom getters in actual objects are welcome.
|
|
e.__defineGetter__("name", function() { return "mine"; });
|
|
assertEquals("mine", e.toString());
|
|
}
|
|
|
|
// Monkey-patching non-static errors should still be observable.
|
|
function MyError() {}
|
|
MyError.prototype = new Error;
|
|
var errors = [Error, RangeError, EvalError, URIError, MyError];
|
|
for (var i in errors) {
|
|
errors[i].prototype.__defineGetter__("name", function() { return "my"; });
|
|
errors[i].prototype.__defineGetter__("message", function() { return "moo"; });
|
|
var e = new errors[i];
|
|
assertEquals("my: moo", e.toString());
|
|
}
|
|
|
|
|
|
Error.prototype.toString = Object.prototype.toString;
|
|
assertEquals("[object Error]", Error.prototype.toString());
|
|
assertEquals(Object.prototype, Error.prototype.__proto__);
|
|
var e = new Error("foo");
|
|
assertEquals("[object Error]", e.toString());
|