3329cbc8eb
This flag enables feedback allocation heuristics to be based on the function size. The threshold for feedback allocation is set to 12 * bytecode size to roughly mimic the allocation after 12 invocations. We tried 4 * bytecode size earlier and there were few memory regressions on real world pages. Speedometer improved by ~1% [1, 2]. This time trying with a higher factor this time to see if we still have speedometer improvements without any memory regressions. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1177124 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=1177241 Change-Id: I39c7d4aaf90b948b07419e4598e2193b8355c067 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752150 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#73369}
78 lines
2.5 KiB
JavaScript
78 lines
2.5 KiB
JavaScript
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --opt --no-lazy-feedback-allocation
|
|
|
|
var global;
|
|
|
|
function TestSetWithCustomIterator(ctor) {
|
|
const k1 = {};
|
|
const k2 = {};
|
|
const entries = [k1];
|
|
let callCount = 0;
|
|
entries[Symbol.iterator] = () => ({
|
|
next: () =>
|
|
callCount++ === 0
|
|
? { value: k2, done: false }
|
|
: { done: true }
|
|
});
|
|
const set = new ctor(entries);
|
|
assertFalse(set.has(k1));
|
|
assertTrue(set.has(k2));
|
|
assertEquals(2, callCount);
|
|
// Keep entries alive to avoid collection of the weakly held map in optimized
|
|
// code which causes the code to deopt.
|
|
global = entries;
|
|
}
|
|
%PrepareFunctionForOptimization(TestSetWithCustomIterator);
|
|
TestSetWithCustomIterator(Set);
|
|
TestSetWithCustomIterator(Set);
|
|
TestSetWithCustomIterator(Set);
|
|
%OptimizeFunctionOnNextCall(TestSetWithCustomIterator);
|
|
TestSetWithCustomIterator(Set);
|
|
assertOptimized(TestSetWithCustomIterator);
|
|
|
|
TestSetWithCustomIterator(WeakSet);
|
|
%PrepareFunctionForOptimization(TestSetWithCustomIterator);
|
|
TestSetWithCustomIterator(WeakSet);
|
|
TestSetWithCustomIterator(WeakSet);
|
|
%OptimizeFunctionOnNextCall(TestSetWithCustomIterator);
|
|
TestSetWithCustomIterator(WeakSet);
|
|
assertOptimized(TestSetWithCustomIterator);
|
|
|
|
function TestMapWithCustomIterator(ctor) {
|
|
const k1 = {};
|
|
const k2 = {};
|
|
const entries = [[k1, 1]];
|
|
let callCount = 0;
|
|
entries[Symbol.iterator] = () => ({
|
|
next: () =>
|
|
callCount++ === 0
|
|
? { value: [k2, 2], done: false }
|
|
: { done: true }
|
|
});
|
|
const map = new ctor(entries);
|
|
assertFalse(map.has(k1));
|
|
assertEquals(2, map.get(k2));
|
|
assertEquals(2, callCount);
|
|
// Keep entries alive to avoid collection of the weakly held map in optimized
|
|
// code which causes the code to deopt.
|
|
global = entries;
|
|
}
|
|
%PrepareFunctionForOptimization(TestMapWithCustomIterator);
|
|
TestMapWithCustomIterator(Map);
|
|
TestMapWithCustomIterator(Map);
|
|
TestMapWithCustomIterator(Map);
|
|
%OptimizeFunctionOnNextCall(TestMapWithCustomIterator);
|
|
TestMapWithCustomIterator(Map);
|
|
assertOptimized(TestMapWithCustomIterator);
|
|
|
|
TestMapWithCustomIterator(WeakMap);
|
|
%PrepareFunctionForOptimization(TestMapWithCustomIterator);
|
|
TestMapWithCustomIterator(WeakMap);
|
|
TestMapWithCustomIterator(WeakMap);
|
|
%OptimizeFunctionOnNextCall(TestMapWithCustomIterator);
|
|
TestMapWithCustomIterator(WeakMap);
|
|
assertOptimized(TestMapWithCustomIterator);
|