ec06bb6ce5
This is a reland of d1b27019d3
Fixes include:
Adding missing file to bazel build
Forward-declaring classing before friend-classing them to fix win/gcc
Add missing v8-isolate.h include for vtune builds
Original change's description:
> [include] Split out v8.h
>
> This moves every single class/function out of include/v8.h into a
> separate header in include/, which v8.h then includes so that
> externally nothing appears to have changed.
>
> Every include of v8.h from inside v8 has been changed to a more
> fine-grained include.
>
> Previously inline functions defined at the bottom of v8.h would call
> private non-inline functions in the V8 class. Since that class is now
> in v8-initialization.h and is rarely included (as that would create
> dependency cycles), this is not possible and so those methods have been
> moved out of the V8 class into the namespace v8::api_internal.
>
> None of the previous files in include/ now #include v8.h, which means
> if embedders were relying on this transitive dependency then it will
> give compile failures.
>
> v8-inspector.h does depend on v8-scripts.h for the time being to ensure
> that Chrome continue to compile but that change will be reverted once
> those transitive #includes in chrome are changed to include it directly.
>
> Full design:
> https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
>
> Bug: v8:11965
> Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Dan Elphick <delphick@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#76424}
Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit
Bug: v8:11965
Change-Id: I99f5d3a73bf8fe25b650adfaf9567dc4e44a09e6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113629
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76460}
104 lines
3.5 KiB
C++
104 lines
3.5 KiB
C++
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "include/v8-exception.h"
|
|
#include "include/v8-local-handle.h"
|
|
#include "include/v8-object.h"
|
|
#include "include/v8-primitive.h"
|
|
#include "include/v8-template.h"
|
|
#include "src/api/api.h"
|
|
#include "src/objects/objects-inl.h"
|
|
#include "test/unittests/test-utils.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
namespace v8 {
|
|
namespace debug {
|
|
namespace {
|
|
|
|
using DebugPropertyIteratorTest = TestWithContext;
|
|
|
|
TEST_F(DebugPropertyIteratorTest, WalksPrototypeChain) {
|
|
TryCatch try_catch(isolate());
|
|
|
|
Local<Object> object = Object::New(isolate());
|
|
|
|
ASSERT_TRUE(object
|
|
->CreateDataProperty(
|
|
context(),
|
|
String::NewFromUtf8Literal(isolate(), "own_property"),
|
|
Number::New(isolate(), 42))
|
|
.FromMaybe(false));
|
|
|
|
Local<Object> prototype = Object::New(isolate());
|
|
ASSERT_TRUE(object->SetPrototype(context(), prototype).FromMaybe(false));
|
|
ASSERT_TRUE(prototype
|
|
->CreateDataProperty(context(),
|
|
String::NewFromUtf8Literal(
|
|
isolate(), "prototype_property"),
|
|
Number::New(isolate(), 21))
|
|
.FromMaybe(false));
|
|
|
|
auto iterator = PropertyIterator::Create(context(), object);
|
|
ASSERT_NE(iterator, nullptr);
|
|
ASSERT_FALSE(iterator->Done());
|
|
EXPECT_TRUE(iterator->is_own());
|
|
char name_buffer[100];
|
|
iterator->name().As<v8::String>()->WriteUtf8(isolate(), name_buffer);
|
|
EXPECT_EQ("own_property", std::string(name_buffer));
|
|
ASSERT_TRUE(iterator->Advance().FromMaybe(false));
|
|
|
|
ASSERT_FALSE(iterator->Done());
|
|
EXPECT_TRUE(iterator->is_own());
|
|
iterator->name().As<v8::String>()->WriteUtf8(isolate(), name_buffer);
|
|
EXPECT_EQ("own_property", std::string(name_buffer));
|
|
ASSERT_TRUE(iterator->Advance().FromMaybe(false));
|
|
|
|
ASSERT_FALSE(iterator->Done());
|
|
EXPECT_FALSE(iterator->is_own());
|
|
iterator->name().As<v8::String>()->WriteUtf8(isolate(), name_buffer);
|
|
EXPECT_EQ("prototype_property", std::string(name_buffer));
|
|
ASSERT_TRUE(iterator->Advance().FromMaybe(false));
|
|
|
|
ASSERT_FALSE(iterator->Done());
|
|
}
|
|
|
|
bool may_access = true;
|
|
|
|
bool AccessCheck(Local<Context> accessing_context,
|
|
Local<Object> accessed_object, Local<Value> data) {
|
|
return may_access;
|
|
}
|
|
|
|
TEST_F(DebugPropertyIteratorTest, DoestWalksPrototypeChainIfInaccesible) {
|
|
TryCatch try_catch(isolate());
|
|
|
|
Local<ObjectTemplate> object_template = ObjectTemplate::New(isolate());
|
|
object_template->SetAccessCheckCallback(AccessCheck);
|
|
|
|
Local<Object> object =
|
|
object_template->NewInstance(context()).ToLocalChecked();
|
|
ASSERT_TRUE(object
|
|
->CreateDataProperty(
|
|
context(),
|
|
String::NewFromUtf8Literal(isolate(), "own_property"),
|
|
Number::New(isolate(), 42))
|
|
.FromMaybe(false));
|
|
|
|
auto iterator = PropertyIterator::Create(context(), object);
|
|
may_access = false;
|
|
ASSERT_NE(iterator, nullptr);
|
|
ASSERT_FALSE(iterator->Done());
|
|
EXPECT_TRUE(iterator->is_own());
|
|
char name_buffer[100];
|
|
iterator->name().As<v8::String>()->WriteUtf8(isolate(), name_buffer);
|
|
EXPECT_EQ("own_property", std::string(name_buffer));
|
|
ASSERT_TRUE(iterator->Advance().FromMaybe(false));
|
|
|
|
ASSERT_TRUE(iterator->Done());
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace debug
|
|
} // namespace v8
|