4a2d9b1b20
This is a partial revert of: https://crrev.com/c/890938 and https://crrev.com/c/893982 Before this CL, the test runner blocked on ongoing tests in order to process their results after an internal timeout. However, the logic required for this feature was overly complicated and prevented an acceptable implementation for fast aborts. Furthermore, also the fuzzers suffered from timeouts on swarming due to hanging tests. Instead, we now abort immediately on internal timeout (used on fuzzers), SIGINT (Ctrl-C) and SIGTERM. Ongoing tests are immediately terminated and their results are disregarded. On SIGTERM and SIGINT, we return with non-zero exit codes, and zero on internal timeout. This will also properly return json output, when the external hard timeout is reached on swarming (causes SIGTERM). TBR=sergiyb@chromium.org Bug: v8:7423, chromium:813065 Change-Id: Ib20f835f58a0970693bdd3b21dc5d766d8e115d8 Reviewed-on: https://chromium-review.googlesource.com/924852 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51399}
32 lines
990 B
Python
32 lines
990 B
Python
# Copyright 2018 the V8 project authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
import signal
|
|
|
|
from . import base
|
|
from testrunner.local import utils
|
|
|
|
|
|
class SignalProc(base.TestProcObserver):
|
|
def __init__(self):
|
|
super(SignalProc, self).__init__()
|
|
self.exit_code = utils.EXIT_CODE_PASS
|
|
|
|
def setup(self, *args, **kwargs):
|
|
super(SignalProc, self).setup(*args, **kwargs)
|
|
# It should be called after processors are chained together to not loose
|
|
# catched signal.
|
|
signal.signal(signal.SIGINT, self._on_ctrlc)
|
|
signal.signal(signal.SIGTERM, self._on_sigterm)
|
|
|
|
def _on_ctrlc(self, _signum, _stack_frame):
|
|
print '>>> Ctrl-C detected, early abort...'
|
|
self.exit_code = utils.EXIT_CODE_INTERRUPTED
|
|
self.stop()
|
|
|
|
def _on_sigterm(self, _signum, _stack_frame):
|
|
print '>>> SIGTERM received, early abort...'
|
|
self.exit_code = utils.EXIT_CODE_TERMINATED
|
|
self.stop()
|