v8/test/mjsunit/optimized-reduce.js
Mike Stanton 03efbd4cd4 [TurboFan] Array.prototype.reduce[Right] was missing a deopt point
We need a deopt point for the case when we fail to find an initial
element from which to begin the reduction step.

Bug: v8:7384
Change-Id: I5e476ddc433be690577677b018639c4c0c70809b
Reviewed-on: https://chromium-review.googlesource.com/906508
Reviewed-by: Michael Stanton <mvstanton@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Michael Stanton <mvstanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51146}
2018-02-07 14:20:37 +00:00

50 lines
1.3 KiB
JavaScript

// Copyright 2018 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax --expose-gc --turbo-inline-array-builtins
// Flags: --opt --no-always-opt
// Make sure we gracefully handle the case of an empty array in
// optimized code.
(function() {
var nothingThere = function(only_holes) {
var a = [1,2,,3]; // holey smi array.
if (only_holes) {
a = [,,,]; // also a holey smi array.
}
return a.reduce((r,v,i,o)=>r+v);
}
nothingThere();
nothingThere();
%OptimizeFunctionOnNextCall(nothingThere);
assertThrows(() => nothingThere(true));
})();
// An error generated inside the callback includes reduce in it's
// stack trace.
(function() {
var re = /Array\.reduce/;
var alwaysThrows = function() {
var b = [,,,];
var result = 0;
var callback = function(r,v,i,o) {
return r + v;
};
b.reduce(callback);
}
try {
alwaysThrows();
} catch (e) {
assertTrue(re.exec(e.stack) !== null);
}
try { alwaysThrows(); } catch (e) {}
try { alwaysThrows(); } catch (e) {}
%OptimizeFunctionOnNextCall(alwaysThrows);
try {
alwaysThrows();
} catch (e) {
assertTrue(re.exec(e.stack) !== null);
}
})();