ec06bb6ce5
This is a reland of d1b27019d3
Fixes include:
Adding missing file to bazel build
Forward-declaring classing before friend-classing them to fix win/gcc
Add missing v8-isolate.h include for vtune builds
Original change's description:
> [include] Split out v8.h
>
> This moves every single class/function out of include/v8.h into a
> separate header in include/, which v8.h then includes so that
> externally nothing appears to have changed.
>
> Every include of v8.h from inside v8 has been changed to a more
> fine-grained include.
>
> Previously inline functions defined at the bottom of v8.h would call
> private non-inline functions in the V8 class. Since that class is now
> in v8-initialization.h and is rarely included (as that would create
> dependency cycles), this is not possible and so those methods have been
> moved out of the V8 class into the namespace v8::api_internal.
>
> None of the previous files in include/ now #include v8.h, which means
> if embedders were relying on this transitive dependency then it will
> give compile failures.
>
> v8-inspector.h does depend on v8-scripts.h for the time being to ensure
> that Chrome continue to compile but that change will be reverted once
> those transitive #includes in chrome are changed to include it directly.
>
> Full design:
> https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
>
> Bug: v8:11965
> Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Dan Elphick <delphick@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#76424}
Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit
Bug: v8:11965
Change-Id: I99f5d3a73bf8fe25b650adfaf9567dc4e44a09e6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113629
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76460}
44 lines
1.2 KiB
C++
44 lines
1.2 KiB
C++
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef INCLUDE_V8_MEMORY_SPAN_H_
|
|
#define INCLUDE_V8_MEMORY_SPAN_H_
|
|
|
|
#include <stddef.h>
|
|
|
|
#include "v8config.h" // NOLINT(build/include_directory)
|
|
|
|
namespace v8 {
|
|
|
|
/**
|
|
* Points to an unowned continous buffer holding a known number of elements.
|
|
*
|
|
* This is similar to std::span (under consideration for C++20), but does not
|
|
* require advanced C++ support. In the (far) future, this may be replaced with
|
|
* or aliased to std::span.
|
|
*
|
|
* To facilitate future migration, this class exposes a subset of the interface
|
|
* implemented by std::span.
|
|
*/
|
|
template <typename T>
|
|
class V8_EXPORT MemorySpan {
|
|
public:
|
|
/** The default constructor creates an empty span. */
|
|
constexpr MemorySpan() = default;
|
|
|
|
constexpr MemorySpan(T* data, size_t size) : data_(data), size_(size) {}
|
|
|
|
/** Returns a pointer to the beginning of the buffer. */
|
|
constexpr T* data() const { return data_; }
|
|
/** Returns the number of elements that the buffer holds. */
|
|
constexpr size_t size() const { return size_; }
|
|
|
|
private:
|
|
T* data_ = nullptr;
|
|
size_t size_ = 0;
|
|
};
|
|
|
|
} // namespace v8
|
|
#endif // INCLUDE_V8_MEMORY_SPAN_H_
|