ededfcd212
This patch expands scope analysis to skip hole initialization
when it can be determined statically that no hole checks will
be generated at runtime.
Two conditions must be met to safely eliminate hole initialization:
- There must not exist a VariableProxy referencing this Variable
whose HoleCheckMode is kRequired
- The Variable must be stack allocated; any other allocation implies
that it may be accessed from not-yet-analyzed scopes (other modules,
inner functions, or eval code) and that code may require
hole checks.
The new logic required removing debug code in full-codegen which is
now incorrect in some cases.
Also fixed Variable's bitfield helpers to take no more space than needed.
Bug: chromium:651637
Change-Id: Ie5ac326af4e05b7a5c3c37cd4d0afba6a51a504d
Reviewed-on: https://chromium-review.googlesource.com/494006
Commit-Queue: Adam Klein <adamk@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45170}
149 lines
4.0 KiB
Plaintext
149 lines
4.0 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: no
|
|
test function name: test
|
|
|
|
---
|
|
snippet: "
|
|
var test;
|
|
(function() {
|
|
class A {
|
|
constructor(...args) { this.baseArgs = args; }
|
|
}
|
|
class B extends A {}
|
|
test = new B(1, 2, 3).constructor;
|
|
})();
|
|
"
|
|
frame size: 4
|
|
parameter count: 1
|
|
bytecode array length: 23
|
|
bytecodes: [
|
|
B(CreateRestParameter),
|
|
B(Star), R(2),
|
|
B(Mov), R(closure), R(1),
|
|
B(Mov), R(new_target), R(0),
|
|
B(Ldar), R(new_target),
|
|
/* 93 E> */ B(StackCheck),
|
|
/* 93 S> */ B(Ldar), R(1),
|
|
B(GetSuperConstructor), R(3),
|
|
B(Ldar), R(0),
|
|
/* 93 E> */ B(ConstructWithSpread), R(3), R(2), U8(1),
|
|
/* 93 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var test;
|
|
(function() {
|
|
class A {
|
|
constructor(...args) { this.baseArgs = args; }
|
|
}
|
|
class B extends A {
|
|
constructor(...args) { super(1, ...args); }
|
|
}
|
|
test = new B(1, 2, 3).constructor;
|
|
})();
|
|
"
|
|
frame size: 7
|
|
parameter count: 1
|
|
bytecode array length: 58
|
|
bytecodes: [
|
|
B(CreateRestParameter),
|
|
B(Star), R(2),
|
|
B(Mov), R(closure), R(1),
|
|
B(Mov), R(new_target), R(0),
|
|
B(Ldar), R(new_target),
|
|
/* 128 E> */ B(StackCheck),
|
|
B(Mov), R(2), R(3),
|
|
/* 140 S> */ B(Ldar), R(1),
|
|
B(GetSuperConstructor), R(4),
|
|
B(LdaSmi), I8(1),
|
|
B(Star), R(5),
|
|
B(Ldar), R(0),
|
|
B(Mov), R(2), R(6),
|
|
/* 140 E> */ B(ConstructWithSpread), R(4), R(5), U8(2),
|
|
B(Star), R(4),
|
|
B(Ldar), R(this),
|
|
B(JumpIfNotHole), U8(4),
|
|
B(Jump), U8(7),
|
|
/* 140 E> */ B(CallRuntime), U16(Runtime::kThrowSuperAlreadyCalledError), R(0), U8(0),
|
|
B(Mov), R(4), R(this),
|
|
B(Ldar), R(this),
|
|
B(JumpIfNotHole), U8(7),
|
|
B(CallRuntime), U16(Runtime::kThrowSuperNotCalled), R(0), U8(0),
|
|
/* 159 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var test;
|
|
(function() {
|
|
class A {
|
|
constructor(...args) { this.baseArgs = args; }
|
|
}
|
|
class B extends A {
|
|
constructor(...args) { super(1, ...args, 1); }
|
|
}
|
|
test = new B(1, 2, 3).constructor;
|
|
})();
|
|
"
|
|
frame size: 10
|
|
parameter count: 1
|
|
bytecode array length: 91
|
|
bytecodes: [
|
|
B(CreateRestParameter),
|
|
B(Star), R(2),
|
|
B(Mov), R(closure), R(1),
|
|
B(Mov), R(new_target), R(0),
|
|
B(Ldar), R(new_target),
|
|
/* 128 E> */ B(StackCheck),
|
|
B(Mov), R(2), R(3),
|
|
/* 140 S> */ B(LdaUndefined),
|
|
B(Star), R(4),
|
|
/* 140 E> */ B(CallRuntime), U16(Runtime::k_GetSuperConstructor), R(1), U8(1),
|
|
B(Star), R(5),
|
|
B(LdaUndefined),
|
|
B(Star), R(6),
|
|
B(CreateArrayLiteral), U8(0), U8(3), U8(17),
|
|
B(Star), R(7),
|
|
B(LdaUndefined),
|
|
B(Star), R(8),
|
|
B(Mov), R(2), R(9),
|
|
/* 152 E> */ B(CallJSRuntime), U8(%spread_iterable), R(8), U8(2),
|
|
B(Star), R(8),
|
|
B(CreateArrayLiteral), U8(1), U8(4), U8(17),
|
|
B(Star), R(9),
|
|
B(CallJSRuntime), U8(%spread_arguments), R(6), U8(4),
|
|
B(Star), R(6),
|
|
B(Mov), R(0), R(7),
|
|
/* 140 E> */ B(CallJSRuntime), U8(%reflect_construct), R(4), U8(4),
|
|
B(Star), R(4),
|
|
B(Ldar), R(this),
|
|
B(JumpIfNotHole), U8(4),
|
|
B(Jump), U8(7),
|
|
/* 140 E> */ B(CallRuntime), U16(Runtime::kThrowSuperAlreadyCalledError), R(0), U8(0),
|
|
B(Mov), R(4), R(this),
|
|
B(Ldar), R(this),
|
|
B(JumpIfNotHole), U8(7),
|
|
B(CallRuntime), U16(Runtime::kThrowSuperNotCalled), R(0), U8(0),
|
|
/* 162 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
TUPLE2_TYPE,
|
|
TUPLE2_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|