ee1db48cc3
This reverts commit 7a9cc70492.
Reason for revert: Changes layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/15882
This is about:
inspector/sources/debugger/source-frame-inline-breakpoint-decorations.html
Original change's description:
> [inspector] moved var initialization break location before init expression
>
> This CL improves break locations for expressions like 'var a = <expr>'. Without CL we use <expr> position as break location for initialization statement, with this CL we use position of first character after '=' as position.
> Benefits (see test for details):
> - only one break in expressions which includes mix of property lookup and calls, e.g. var p = Promise.resolve().then(x => x * 2),
> - removed redundant break location for expressions like: let { x, y } = { x: 1, y: 2}.
>
> Bug: v8:5909
> Change-Id: I039d911903a2826c9859710a63ab0462c992e11b
> Reviewed-on: https://chromium-review.googlesource.com/513926
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Reviewed-by: Marja Hölttä <marja@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#45530}
TBR=dgozman@chromium.org,marja@chromium.org,kozyatinskiy@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: v8:5909
Change-Id: Ibf84401e8050d3c84db219d983de2c6bba0f697f
Reviewed-on: https://chromium-review.googlesource.com/518102
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45547}
57 lines
1.2 KiB
JavaScript
57 lines
1.2 KiB
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
var Debug = debug.Debug;
|
|
var step_count = 0;
|
|
|
|
function listener(event, execState, eventData, data) {
|
|
if (event != Debug.DebugEvent.Break) return;
|
|
try {
|
|
var line = execState.frame(0).sourceLineText();
|
|
print(line);
|
|
var [match, expected_count, step] = /\/\/ B(\d) (\w+)$/.exec(line);
|
|
assertEquals(step_count++, parseInt(expected_count));
|
|
if (step != "Continue") execState.prepareStep(Debug.StepAction[step]);
|
|
} catch (e) {
|
|
print(e, e.stack);
|
|
quit(1);
|
|
}
|
|
}
|
|
|
|
Debug.setListener(listener);
|
|
|
|
var late_resolve;
|
|
|
|
function g() {
|
|
return new Promise( // B4 StepOut
|
|
function(res, rej) {
|
|
late_resolve = res;
|
|
}
|
|
);
|
|
}
|
|
|
|
async function f1() {
|
|
var a = 1;
|
|
debugger; // B0 StepNext
|
|
a += // B1 StepNext
|
|
await // B6 StepNext
|
|
f2(); // B2 StepIn
|
|
return a; // B7 StepNext
|
|
} // B8 Continue
|
|
|
|
async function f2() {
|
|
var b =
|
|
await // B5 StepOut
|
|
g(); // B3 StepIn
|
|
return b;
|
|
}
|
|
|
|
f1();
|
|
|
|
late_resolve(3);
|
|
|
|
%RunMicrotasks();
|
|
|
|
assertEquals(9, step_count);
|