8b1a5681de
Bill kindly pointed out to me that v8windbg was not handling bit_field2 correctly. The issue was that the constexpr type for ElementsKind was, somewhat unsurprisingly, "ElementsKind", but v8windbg expected a fully- qualified type name like "v8::internal::ElementsKind". This change addresses the problem in two ways: 1. Update v8windbg's type resolution logic to resolve type names as if they were used in the v8::internal namespace. This makes it more consistent with how those type names are used in other generated Torque code, reducing surprises and the number of times we have to write `v8::internal::` in .tq files. 2. Add compile-time verification that any constexpr type name used as a string in class-debug-readers-tq.cc can also resolve as a type name. Bug: v8:9376 Change-Id: I349cd6ab586fd8345a1fa8bfc3989bb8e6376ab8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2063769 Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#66633}
90 lines
3.1 KiB
C++
90 lines
3.1 KiB
C++
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "heap-constants.h"
|
|
#include "src/common/globals.h"
|
|
|
|
namespace d = v8::debug_helper;
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace debug_helper_internal {
|
|
|
|
std::string FindKnownObject(uintptr_t address,
|
|
const d::HeapAddresses& heap_addresses) {
|
|
uintptr_t containing_page = address & ~i::kPageAlignmentMask;
|
|
uintptr_t offset_in_page = address & i::kPageAlignmentMask;
|
|
|
|
// If there's a match with a known page, then search only that page.
|
|
if (containing_page == heap_addresses.map_space_first_page) {
|
|
return FindKnownObjectInMapSpace(offset_in_page);
|
|
}
|
|
if (containing_page == heap_addresses.old_space_first_page) {
|
|
return FindKnownObjectInOldSpace(offset_in_page);
|
|
}
|
|
if (containing_page == heap_addresses.read_only_space_first_page) {
|
|
return FindKnownObjectInReadOnlySpace(offset_in_page);
|
|
}
|
|
|
|
// For any unknown pages, compile a list of things this object might be.
|
|
std::string result;
|
|
if (heap_addresses.map_space_first_page == 0) {
|
|
std::string sub_result = FindKnownObjectInMapSpace(offset_in_page);
|
|
if (!sub_result.empty()) {
|
|
result += "maybe " + sub_result;
|
|
}
|
|
}
|
|
if (heap_addresses.old_space_first_page == 0) {
|
|
std::string sub_result = FindKnownObjectInOldSpace(offset_in_page);
|
|
if (!sub_result.empty()) {
|
|
result = (result.empty() ? "" : result + ", ") + "maybe " + sub_result;
|
|
}
|
|
}
|
|
if (heap_addresses.read_only_space_first_page == 0) {
|
|
std::string sub_result = FindKnownObjectInReadOnlySpace(offset_in_page);
|
|
if (!sub_result.empty()) {
|
|
result = (result.empty() ? "" : result + ", ") + "maybe " + sub_result;
|
|
}
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
KnownInstanceType FindKnownMapInstanceTypes(
|
|
uintptr_t address, const d::HeapAddresses& heap_addresses) {
|
|
uintptr_t containing_page = address & ~i::kPageAlignmentMask;
|
|
uintptr_t offset_in_page = address & i::kPageAlignmentMask;
|
|
|
|
// If there's a match with a known page, then search only that page.
|
|
if (containing_page == heap_addresses.map_space_first_page) {
|
|
return KnownInstanceType(
|
|
FindKnownMapInstanceTypeInMapSpace(offset_in_page));
|
|
}
|
|
if (containing_page == heap_addresses.read_only_space_first_page) {
|
|
return KnownInstanceType(
|
|
FindKnownMapInstanceTypeInReadOnlySpace(offset_in_page));
|
|
}
|
|
|
|
// For any unknown pages, compile a list of things this object might be.
|
|
KnownInstanceType result;
|
|
if (heap_addresses.map_space_first_page == 0) {
|
|
int sub_result = FindKnownMapInstanceTypeInMapSpace(offset_in_page);
|
|
if (sub_result >= 0) {
|
|
result.types.push_back(static_cast<i::InstanceType>(sub_result));
|
|
}
|
|
}
|
|
if (heap_addresses.read_only_space_first_page == 0) {
|
|
int sub_result = FindKnownMapInstanceTypeInReadOnlySpace(offset_in_page);
|
|
if (sub_result >= 0) {
|
|
result.types.push_back(static_cast<i::InstanceType>(sub_result));
|
|
}
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
} // namespace debug_helper_internal
|
|
} // namespace internal
|
|
} // namespace v8
|