63a2836076
We should only tier to Sparkplug from Ignition. Previously, the '!ActiveTierIsSparkplug' condition was correct since only Ignition (and Sparkplug itself) entered the TieringManager. But now that Maglev is also present, the condition must be clarified to 'ActiveTierIsIgnition'. Bug: v8:7700 Change-Id: Ic7ea898facf9ce65407d09cead35e0181e49db31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3835562 Commit-Queue: Jakob Linke <jgruber@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#82519}
45 lines
1.1 KiB
JavaScript
45 lines
1.1 KiB
JavaScript
// Copyright 2022 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
//
|
|
// Flags: --allow-natives-syntax --maglev --no-stress-opt
|
|
// Flags: --no-baseline-batch-compilation
|
|
|
|
function f(x) {
|
|
var y = 0;
|
|
for (var i = 0; i < x; i++) {
|
|
y = 1;
|
|
}
|
|
return y;
|
|
}
|
|
|
|
let keep_going = 100000; // A counter to avoid test hangs on failure.
|
|
|
|
function g() {
|
|
// Test that normal tiering (without OptimizeFooOnNextCall) works.
|
|
// We test the entire pipeline, i.e. Ignition-SP-ML-TF.
|
|
|
|
f(10);
|
|
|
|
if (%IsSparkplugEnabled()) {
|
|
while (!%ActiveTierIsSparkplug(f) && --keep_going) f(10);
|
|
assertTrue(%ActiveTierIsSparkplug(f));
|
|
}
|
|
|
|
if (%IsMaglevEnabled()) {
|
|
while (!%ActiveTierIsMaglev(f) && --keep_going) f(10);
|
|
assertTrue(%ActiveTierIsMaglev(f));
|
|
}
|
|
|
|
if (%IsTurbofanEnabled()) {
|
|
while (!%ActiveTierIsTurbofan(f) && --keep_going) f(10);
|
|
assertTrue(%ActiveTierIsTurbofan(f));
|
|
|
|
f(10);
|
|
assertTrue(%ActiveTierIsTurbofan(f));
|
|
}
|
|
}
|
|
%NeverOptimizeFunction(g);
|
|
|
|
g();
|