16d948312f
MSVC does not implicitly convert the std::array iterator to a char*,
hence explicitly use the {data()} accessor instead of {begin()}, which
is cleaner anyway.
R=mlippautz@chromium.org
Bug: chromium:1323177
Change-Id: I65c6836889eb57a18b655cb9e6c98008a8fbcaac
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3644794
Auto-Submit: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80533}
89 lines
3.1 KiB
C++
89 lines
3.1 KiB
C++
// Copyright 2022 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/base/string-format.h"
|
|
|
|
#include "testing/gmock/include/gmock/gmock.h"
|
|
#include "testing/gtest-support.h"
|
|
|
|
namespace v8::base {
|
|
|
|
// Some hard-coded assumptions.
|
|
constexpr int kMaxPrintedIntLen = 11;
|
|
constexpr int kMaxPrintedSizetLen = sizeof(size_t) == 4 ? 10 : 20;
|
|
|
|
TEST(FormattedStringTest, Empty) {
|
|
auto empty = FormattedString{};
|
|
EXPECT_EQ("", decltype(empty)::kFormat);
|
|
EXPECT_EQ(1, decltype(empty)::kMaxLen);
|
|
EXPECT_EQ('\0', empty.PrintToArray()[0]);
|
|
}
|
|
|
|
TEST(FormattedStringTest, SingleString) {
|
|
auto message = FormattedString{} << "foo";
|
|
EXPECT_EQ("%s", decltype(message)::kFormat);
|
|
|
|
constexpr std::array<char, 4> kExpectedOutput{'f', 'o', 'o', '\0'};
|
|
EXPECT_EQ(kExpectedOutput, message.PrintToArray());
|
|
}
|
|
|
|
TEST(FormattedStringTest, Int) {
|
|
auto message = FormattedString{} << 42;
|
|
EXPECT_EQ("%d", decltype(message)::kFormat);
|
|
// +1 for null-termination.
|
|
EXPECT_EQ(kMaxPrintedIntLen + 1, decltype(message)::kMaxLen);
|
|
|
|
EXPECT_THAT(message.PrintToArray().data(), ::testing::StrEq("42"));
|
|
}
|
|
|
|
TEST(FormattedStringTest, MaxInt) {
|
|
auto message = FormattedString{} << std::numeric_limits<int>::max();
|
|
auto result_arr = message.PrintToArray();
|
|
// We *nearly* used the full reserved array size (the minimum integer is still
|
|
// one character longer)..
|
|
EXPECT_EQ(size_t{decltype(message)::kMaxLen}, result_arr.size());
|
|
EXPECT_THAT(result_arr.data(), ::testing::StrEq("2147483647"));
|
|
}
|
|
|
|
TEST(FormattedStringTest, MinInt) {
|
|
auto message = FormattedString{} << std::numeric_limits<int>::min();
|
|
auto result_arr = message.PrintToArray();
|
|
// We used the full reserved array size.
|
|
EXPECT_EQ(size_t{decltype(message)::kMaxLen}, result_arr.size());
|
|
EXPECT_THAT(result_arr.data(), ::testing::StrEq("-2147483648"));
|
|
}
|
|
|
|
TEST(FormattedStringTest, SizeT) {
|
|
auto message = FormattedString{} << size_t{42};
|
|
EXPECT_EQ("%zu", decltype(message)::kFormat);
|
|
// +1 for null-termination.
|
|
EXPECT_EQ(kMaxPrintedSizetLen + 1, decltype(message)::kMaxLen);
|
|
|
|
EXPECT_THAT(message.PrintToArray().data(), ::testing::StrEq("42"));
|
|
}
|
|
|
|
TEST(FormattedStringTest, MaxSizeT) {
|
|
auto message = FormattedString{} << std::numeric_limits<size_t>::max();
|
|
auto result_arr = message.PrintToArray();
|
|
// We used the full reserved array size.
|
|
EXPECT_EQ(size_t{decltype(message)::kMaxLen}, result_arr.size());
|
|
constexpr const char* kMaxSizeTStr =
|
|
sizeof(size_t) == 4 ? "4294967295" : "18446744073709551615";
|
|
EXPECT_THAT(result_arr.data(), ::testing::StrEq(kMaxSizeTStr));
|
|
}
|
|
|
|
TEST(FormattedStringTest, Combination) {
|
|
auto message = FormattedString{} << "Expected " << 11 << " got " << size_t{42}
|
|
<< "!";
|
|
EXPECT_EQ("%s%d%s%zu%s", decltype(message)::kFormat);
|
|
size_t expected_array_len =
|
|
strlen("Expected got !") + kMaxPrintedIntLen + kMaxPrintedSizetLen + 1;
|
|
EXPECT_EQ(expected_array_len, size_t{decltype(message)::kMaxLen});
|
|
|
|
EXPECT_THAT(message.PrintToArray().data(),
|
|
::testing::StrEq("Expected 11 got 42!"));
|
|
}
|
|
|
|
} // namespace v8::base
|