AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
f0cf0b2862
v8/test/mkgrokdump
History
Clemens Hammacher 6832f29250 Revert "[heap] Skip ro-space from heap iterators, add CombinedHeapIterator." 
This reverts commit 3d1d8eae77.

Reason for revert: Speculative revert; seems to break all nosnap bots, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20nosnap/25240

Original change's description:
> [heap] Skip ro-space from heap iterators, add CombinedHeapIterator.
> 
> Read-only space sharing requires an iterator independent of heap. This
> also enables future removal of read-only space from heap.
> 
> Bug: v8:7464
> Change-Id: Ia07a9369494ea2c547d12c01ffa1d7b8b6bbeabc
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552795
> Commit-Queue: Maciej Goszczycki <goszczycki@google.com>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Dan Elphick <delphick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#60819}

TBR=ulan@chromium.org,hpayer@chromium.org,delphick@chromium.org,goszczycki@google.com

Change-Id: I64b58b1b0c5eb073a6d2cfae81bb4de65f0511bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7464
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565895
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60825}
2019-04-12 16:38:00 +00:00
..
BUILD.gn Remove manual references to exe_and_shlib_deps 2018-06-04 18:35:43 +00:00
DEPS Introduce mkgrokdump to update tools/v8heapconst.py. 2017-04-20 06:15:02 +00:00
mkgrokdump.cc Revert "[heap] Skip ro-space from heap iterators, add CombinedHeapIterator." 2019-04-12 16:38:00 +00:00
mkgrokdump.status [test] Don't test jitless without embedded-builtins 2019-02-26 14:33:01 +00:00
README [test] Add README to test/mkgrokdump, containing rebaseline instruction. 2017-05-16 16:53:47 +00:00
testcfg.py [test] migrate mkgrokdump suite to TestLoader 2019-02-12 12:59:43 +00:00

README 

If you change the heap layout, expect this test to fail (in CQ). You will then
need to build x64 release and run `<outdir>/mkgrokdump > tools/v8heapconst.py`
to rebaseline.