822be9b238
This patch normalizes the casing of hexadecimal digits in escape sequences of the form `\xNN` and integer literals of the form `0xNNNN`. Previously, the V8 code base used an inconsistent mixture of uppercase and lowercase. Google’s C++ style guide uses uppercase in its examples: https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters Moreover, uppercase letters more clearly stand out from the lowercase `x` (or `u`) characters at the start, as well as lowercase letters elsewhere in strings. BUG=v8:7109 TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org NOPRESUBMIT=true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6 Reviewed-on: https://chromium-review.googlesource.com/804294 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49810}
258 lines
9.1 KiB
C++
258 lines
9.1 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "test/fuzzer/wasm-fuzzer-common.h"
|
|
|
|
#include "include/v8.h"
|
|
#include "src/isolate.h"
|
|
#include "src/objects-inl.h"
|
|
#include "src/wasm/module-compiler.h"
|
|
#include "src/wasm/wasm-api.h"
|
|
#include "src/wasm/wasm-module-builder.h"
|
|
#include "src/wasm/wasm-module.h"
|
|
#include "src/zone/accounting-allocator.h"
|
|
#include "src/zone/zone.h"
|
|
#include "test/common/wasm/flag-utils.h"
|
|
#include "test/common/wasm/wasm-module-runner.h"
|
|
#include "test/fuzzer/fuzzer-support.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace wasm {
|
|
namespace fuzzer {
|
|
|
|
static constexpr const char* kNameString = "name";
|
|
static constexpr size_t kNameStringLength = 4;
|
|
|
|
int FuzzWasmSection(SectionCode section, const uint8_t* data, size_t size) {
|
|
v8_fuzzer::FuzzerSupport* support = v8_fuzzer::FuzzerSupport::Get();
|
|
v8::Isolate* isolate = support->GetIsolate();
|
|
i::Isolate* i_isolate = reinterpret_cast<Isolate*>(isolate);
|
|
|
|
// Clear any pending exceptions from a prior run.
|
|
i_isolate->clear_pending_exception();
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate);
|
|
v8::HandleScope handle_scope(isolate);
|
|
v8::Context::Scope context_scope(support->GetContext());
|
|
v8::TryCatch try_catch(isolate);
|
|
|
|
AccountingAllocator allocator;
|
|
Zone zone(&allocator, ZONE_NAME);
|
|
|
|
ZoneBuffer buffer(&zone);
|
|
buffer.write_u32(kWasmMagic);
|
|
buffer.write_u32(kWasmVersion);
|
|
if (section == kNameSectionCode) {
|
|
buffer.write_u8(kUnknownSectionCode);
|
|
buffer.write_size(size + kNameStringLength + 1);
|
|
buffer.write_u8(kNameStringLength);
|
|
buffer.write(reinterpret_cast<const uint8_t*>(kNameString),
|
|
kNameStringLength);
|
|
buffer.write(data, size);
|
|
} else {
|
|
buffer.write_u8(section);
|
|
buffer.write_size(size);
|
|
buffer.write(data, size);
|
|
}
|
|
|
|
ErrorThrower thrower(i_isolate, "decoder");
|
|
|
|
std::unique_ptr<const WasmModule> module(testing::DecodeWasmModuleForTesting(
|
|
i_isolate, &thrower, buffer.begin(), buffer.end(), kWasmOrigin));
|
|
|
|
return 0;
|
|
}
|
|
|
|
void InterpretAndExecuteModule(i::Isolate* isolate,
|
|
Handle<WasmModuleObject> module_object) {
|
|
ScheduledErrorThrower thrower(isolate, "WebAssembly Instantiation");
|
|
// Try to instantiate and interpret the module_object.
|
|
MaybeHandle<WasmInstanceObject> maybe_instance =
|
|
SyncInstantiate(isolate, &thrower, module_object,
|
|
Handle<JSReceiver>::null(), // imports
|
|
MaybeHandle<JSArrayBuffer>()); // memory
|
|
Handle<WasmInstanceObject> instance;
|
|
if (!maybe_instance.ToHandle(&instance)) return;
|
|
if (!testing::InterpretWasmModuleForTesting(isolate, instance, "main", 0,
|
|
nullptr)) {
|
|
return;
|
|
}
|
|
|
|
// Instantiate and execute the module_object.
|
|
maybe_instance = SyncInstantiate(isolate, &thrower, module_object,
|
|
Handle<JSReceiver>::null(), // imports
|
|
MaybeHandle<JSArrayBuffer>()); // memory
|
|
if (!maybe_instance.ToHandle(&instance)) return;
|
|
|
|
testing::RunWasmModuleForTesting(isolate, instance, 0, nullptr);
|
|
}
|
|
|
|
int WasmExecutionFuzzer::FuzzWasmModule(const uint8_t* data, size_t size,
|
|
bool require_valid) {
|
|
// Save the flag so that we can change it and restore it later.
|
|
bool generate_test = FLAG_wasm_code_fuzzer_gen_test;
|
|
if (generate_test) {
|
|
OFStream os(stdout);
|
|
|
|
os << "// Copyright 2017 the V8 project authors. All rights reserved."
|
|
<< std::endl;
|
|
os << "// Use of this source code is governed by a BSD-style license that "
|
|
"can be"
|
|
<< std::endl;
|
|
os << "// found in the LICENSE file." << std::endl;
|
|
os << std::endl;
|
|
os << "load(\"test/mjsunit/wasm/wasm-constants.js\");" << std::endl;
|
|
os << "load(\"test/mjsunit/wasm/wasm-module-builder.js\");" << std::endl;
|
|
os << std::endl;
|
|
os << "(function() {" << std::endl;
|
|
os << " var builder = new WasmModuleBuilder();" << std::endl;
|
|
os << " builder.addMemory(16, 32, false);" << std::endl;
|
|
os << " builder.addFunction(\"test\", kSig_i_iii)" << std::endl;
|
|
os << " .addBodyWithEnd([" << std::endl;
|
|
}
|
|
v8_fuzzer::FuzzerSupport* support = v8_fuzzer::FuzzerSupport::Get();
|
|
v8::Isolate* isolate = support->GetIsolate();
|
|
i::Isolate* i_isolate = reinterpret_cast<Isolate*>(isolate);
|
|
|
|
// Clear any pending exceptions from a prior run.
|
|
i_isolate->clear_pending_exception();
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate);
|
|
v8::HandleScope handle_scope(isolate);
|
|
v8::Context::Scope context_scope(support->GetContext());
|
|
v8::TryCatch try_catch(isolate);
|
|
HandleScope scope(i_isolate);
|
|
|
|
AccountingAllocator allocator;
|
|
Zone zone(&allocator, ZONE_NAME);
|
|
|
|
ZoneBuffer buffer(&zone);
|
|
int32_t num_args = 0;
|
|
std::unique_ptr<WasmValue[]> interpreter_args;
|
|
std::unique_ptr<Handle<Object>[]> compiler_args;
|
|
if (!GenerateModule(i_isolate, &zone, data, size, buffer, num_args,
|
|
interpreter_args, compiler_args)) {
|
|
return 0;
|
|
}
|
|
|
|
testing::SetupIsolateForWasmModule(i_isolate);
|
|
|
|
ErrorThrower interpreter_thrower(i_isolate, "Interpreter");
|
|
ModuleWireBytes wire_bytes(buffer.begin(), buffer.end());
|
|
|
|
// Compile with Turbofan here. Liftoff will be tested later.
|
|
MaybeHandle<WasmModuleObject> compiled_module;
|
|
{
|
|
FlagScope<bool> no_liftoff(&FLAG_liftoff, false);
|
|
compiled_module = SyncCompile(i_isolate, &interpreter_thrower, wire_bytes);
|
|
}
|
|
// Clear the flag so that the WebAssembly code is not printed twice.
|
|
FLAG_wasm_code_fuzzer_gen_test = false;
|
|
bool compiles = !compiled_module.is_null();
|
|
|
|
if (generate_test) {
|
|
OFStream os(stdout);
|
|
os << " ])" << std::endl
|
|
<< " .exportFunc();" << std::endl;
|
|
if (compiles) {
|
|
os << " var module = builder.instantiate();" << std::endl
|
|
<< " module.exports.test(1, 2, 3);" << std::endl;
|
|
} else {
|
|
OFStream os(stdout);
|
|
os << " assertThrows(function() { builder.instantiate(); });"
|
|
<< std::endl;
|
|
}
|
|
os << "})();" << std::endl;
|
|
}
|
|
|
|
bool validates = SyncValidate(i_isolate, wire_bytes);
|
|
|
|
CHECK_EQ(compiles, validates);
|
|
CHECK_IMPLIES(require_valid, validates);
|
|
|
|
if (!compiles) return 0;
|
|
|
|
int32_t result_interpreter;
|
|
bool possible_nondeterminism = false;
|
|
{
|
|
MaybeHandle<WasmInstanceObject> interpreter_instance = SyncInstantiate(
|
|
i_isolate, &interpreter_thrower, compiled_module.ToHandleChecked(),
|
|
MaybeHandle<JSReceiver>(), MaybeHandle<JSArrayBuffer>());
|
|
|
|
// Ignore instantiation failure.
|
|
if (interpreter_thrower.error()) {
|
|
return 0;
|
|
}
|
|
|
|
result_interpreter = testing::InterpretWasmModule(
|
|
i_isolate, interpreter_instance.ToHandleChecked(), &interpreter_thrower,
|
|
0, interpreter_args.get(), &possible_nondeterminism);
|
|
}
|
|
|
|
// Do not execute the generated code if the interpreter did not finished after
|
|
// a bounded number of steps.
|
|
if (interpreter_thrower.error()) {
|
|
return 0;
|
|
}
|
|
|
|
bool expect_exception =
|
|
result_interpreter == static_cast<int32_t>(0xDEADBEEF);
|
|
|
|
int32_t result_turbofan;
|
|
{
|
|
ErrorThrower compiler_thrower(i_isolate, "Turbofan");
|
|
MaybeHandle<WasmInstanceObject> compiled_instance = SyncInstantiate(
|
|
i_isolate, &compiler_thrower, compiled_module.ToHandleChecked(),
|
|
MaybeHandle<JSReceiver>(), MaybeHandle<JSArrayBuffer>());
|
|
|
|
DCHECK(!compiler_thrower.error());
|
|
result_turbofan = testing::CallWasmFunctionForTesting(
|
|
i_isolate, compiled_instance.ToHandleChecked(), &compiler_thrower,
|
|
"main", num_args, compiler_args.get());
|
|
}
|
|
|
|
// The WebAssembly spec allows the sign bit of NaN to be non-deterministic.
|
|
// This sign bit may cause result_interpreter to be different than
|
|
// result_turbofan. Therefore we do not check the equality of the results
|
|
// if the execution may have produced a NaN at some point.
|
|
if (!possible_nondeterminism) {
|
|
CHECK_EQ(expect_exception, i_isolate->has_pending_exception());
|
|
|
|
if (!expect_exception) CHECK_EQ(result_interpreter, result_turbofan);
|
|
}
|
|
|
|
// Clear any pending exceptions for the next run.
|
|
i_isolate->clear_pending_exception();
|
|
|
|
int32_t result_liftoff;
|
|
{
|
|
FlagScope<bool> liftoff(&FLAG_liftoff, true);
|
|
ErrorThrower compiler_thrower(i_isolate, "Liftoff");
|
|
// Re-compile with Liftoff.
|
|
MaybeHandle<WasmInstanceObject> compiled_instance =
|
|
SyncCompileAndInstantiate(i_isolate, &compiler_thrower, wire_bytes,
|
|
MaybeHandle<JSReceiver>(),
|
|
MaybeHandle<JSArrayBuffer>());
|
|
DCHECK(!compiler_thrower.error());
|
|
result_liftoff = testing::CallWasmFunctionForTesting(
|
|
i_isolate, compiled_instance.ToHandleChecked(), &compiler_thrower,
|
|
"main", num_args, compiler_args.get());
|
|
}
|
|
if (!possible_nondeterminism) {
|
|
CHECK_EQ(expect_exception, i_isolate->has_pending_exception());
|
|
|
|
if (!expect_exception) CHECK_EQ(result_interpreter, result_liftoff);
|
|
}
|
|
|
|
// Cleanup any pending exception.
|
|
i_isolate->clear_pending_exception();
|
|
return 0;
|
|
}
|
|
|
|
} // namespace fuzzer
|
|
} // namespace wasm
|
|
} // namespace internal
|
|
} // namespace v8
|