f12e8d64ab
While crrev.com/c/1520721 tried to avoid collecting source positions when throw exceptions, it failed because they were still collected in Isolate::CaptureStackTrace. This removes that collection point and lets SetStackFrameCacheCommon bail out when trying to set the stack frame cache for a bytecode that doesn't have source positions. It also adds tests that ensure source positions are not collected when an exception is thrown (although one is disabled as it does not yet work). Bug: v8:8510 Change-Id: Id5caf579dda549d637fa9b3129c419d524be5ff2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565898 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#60847} |
||
---|---|---|
.. | ||
bytecode_expectations | ||
bytecode-expectations-printer.cc | ||
bytecode-expectations-printer.h | ||
generate-bytecode-expectations.cc | ||
interpreter-tester.cc | ||
interpreter-tester.h | ||
source-position-matcher.cc | ||
source-position-matcher.h | ||
test-bytecode-generator.cc | ||
test-interpreter-intrinsics.cc | ||
test-interpreter.cc | ||
test-source-positions.cc |