ed7bef5b91
Modify the Bytecode Register Optimizer to be an independent component rather than part of the BytecodePipeline. This means the BytecodeArrayBuilder can explicitly call it with register operands when outputting a bytecode and the Bytecode Register Optimizer doesn't need to work out which operands are register operands. This also means we don't need to build BytecodeNodes for Ldar / Star / Mov bytecodes unless they are actually emitted by the optimizer. This change also modifies the way the BytecodeArrayBuilder converts operands to make use of the OperandTypes specified in bytecodes.h. This avoids having to individually convert operands to their raw output value before calling Output(...). BUG=v8:4280 Review-Url: https://codereview.chromium.org/2393683004 Cr-Commit-Position: refs/heads/master@{#40543}
169 lines
5.5 KiB
C++
169 lines
5.5 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/v8.h"
|
|
|
|
#include "src/interpreter/bytecode-pipeline.h"
|
|
#include "src/interpreter/bytecode-register-allocator.h"
|
|
#include "src/isolate.h"
|
|
#include "test/unittests/test-utils.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace interpreter {
|
|
|
|
using BytecodeNodeTest = TestWithIsolateAndZone;
|
|
|
|
TEST(BytecodeSourceInfo, Operations) {
|
|
BytecodeSourceInfo x(0, true);
|
|
CHECK_EQ(x.source_position(), 0);
|
|
CHECK_EQ(x.is_statement(), true);
|
|
CHECK_EQ(x.is_valid(), true);
|
|
x.set_invalid();
|
|
CHECK_EQ(x.is_statement(), false);
|
|
CHECK_EQ(x.is_valid(), false);
|
|
|
|
x.MakeStatementPosition(1);
|
|
BytecodeSourceInfo y(1, true);
|
|
CHECK(x == y);
|
|
CHECK(!(x != y));
|
|
|
|
x.set_invalid();
|
|
CHECK(!(x == y));
|
|
CHECK(x != y);
|
|
|
|
y.MakeStatementPosition(1);
|
|
CHECK_EQ(y.source_position(), 1);
|
|
CHECK_EQ(y.is_statement(), true);
|
|
|
|
y.MakeStatementPosition(2);
|
|
CHECK_EQ(y.source_position(), 2);
|
|
CHECK_EQ(y.is_statement(), true);
|
|
|
|
y.set_invalid();
|
|
y.MakeExpressionPosition(3);
|
|
CHECK_EQ(y.source_position(), 3);
|
|
CHECK_EQ(y.is_statement(), false);
|
|
|
|
y.MakeStatementPosition(3);
|
|
CHECK_EQ(y.source_position(), 3);
|
|
CHECK_EQ(y.is_statement(), true);
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, Constructor1) {
|
|
BytecodeNode node(Bytecode::kLdaZero);
|
|
CHECK_EQ(node.bytecode(), Bytecode::kLdaZero);
|
|
CHECK_EQ(node.operand_count(), 0);
|
|
CHECK(!node.source_info().is_valid());
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, Constructor2) {
|
|
uint32_t operands[] = {0x11};
|
|
BytecodeNode node(Bytecode::kJumpIfTrue, operands[0]);
|
|
CHECK_EQ(node.bytecode(), Bytecode::kJumpIfTrue);
|
|
CHECK_EQ(node.operand_count(), 1);
|
|
CHECK_EQ(node.operand(0), operands[0]);
|
|
CHECK(!node.source_info().is_valid());
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, Constructor3) {
|
|
uint32_t operands[] = {0x11};
|
|
BytecodeNode node(Bytecode::kLdaGlobal, operands[0]);
|
|
CHECK_EQ(node.bytecode(), Bytecode::kLdaGlobal);
|
|
CHECK_EQ(node.operand_count(), 1);
|
|
CHECK_EQ(node.operand(0), operands[0]);
|
|
CHECK(!node.source_info().is_valid());
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, Constructor4) {
|
|
uint32_t operands[] = {0x11, 0x22, 0x33};
|
|
BytecodeNode node(Bytecode::kLdaNamedProperty, operands[0], operands[1],
|
|
operands[2]);
|
|
CHECK_EQ(node.operand_count(), 3);
|
|
CHECK_EQ(node.bytecode(), Bytecode::kLdaNamedProperty);
|
|
CHECK_EQ(node.operand(0), operands[0]);
|
|
CHECK_EQ(node.operand(1), operands[1]);
|
|
CHECK_EQ(node.operand(2), operands[2]);
|
|
CHECK(!node.source_info().is_valid());
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, Constructor5) {
|
|
uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
|
|
BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
|
|
operands[3]);
|
|
CHECK_EQ(node.operand_count(), 4);
|
|
CHECK_EQ(node.bytecode(), Bytecode::kForInNext);
|
|
CHECK_EQ(node.operand(0), operands[0]);
|
|
CHECK_EQ(node.operand(1), operands[1]);
|
|
CHECK_EQ(node.operand(2), operands[2]);
|
|
CHECK_EQ(node.operand(3), operands[3]);
|
|
CHECK(!node.source_info().is_valid());
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, Equality) {
|
|
uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
|
|
BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
|
|
operands[3]);
|
|
CHECK_EQ(node, node);
|
|
BytecodeNode other(Bytecode::kForInNext, operands[0], operands[1],
|
|
operands[2], operands[3]);
|
|
CHECK_EQ(node, other);
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, EqualityWithSourceInfo) {
|
|
uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
|
|
BytecodeSourceInfo first_source_info(3, true);
|
|
BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
|
|
operands[3], first_source_info);
|
|
CHECK_EQ(node, node);
|
|
BytecodeSourceInfo second_source_info(3, true);
|
|
BytecodeNode other(Bytecode::kForInNext, operands[0], operands[1],
|
|
operands[2], operands[3], second_source_info);
|
|
CHECK_EQ(node, other);
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, NoEqualityWithDifferentSourceInfo) {
|
|
uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
|
|
BytecodeSourceInfo source_info(77, true);
|
|
BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
|
|
operands[3], source_info);
|
|
BytecodeNode other(Bytecode::kForInNext, operands[0], operands[1],
|
|
operands[2], operands[3]);
|
|
CHECK_NE(node, other);
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, SetBytecode0) {
|
|
uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
|
|
BytecodeSourceInfo source_info(77, false);
|
|
BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
|
|
operands[3], source_info);
|
|
CHECK_EQ(node.source_info(), source_info);
|
|
|
|
BytecodeNode clone(Bytecode::kIllegal);
|
|
clone = node;
|
|
clone.set_bytecode(Bytecode::kNop);
|
|
CHECK_EQ(clone.bytecode(), Bytecode::kNop);
|
|
CHECK_EQ(clone.operand_count(), 0);
|
|
CHECK_EQ(clone.source_info(), source_info);
|
|
}
|
|
|
|
TEST_F(BytecodeNodeTest, SetBytecode1) {
|
|
uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
|
|
BytecodeSourceInfo source_info(77, false);
|
|
BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
|
|
operands[3], source_info);
|
|
|
|
BytecodeNode clone(Bytecode::kIllegal);
|
|
clone = node;
|
|
clone.set_bytecode(Bytecode::kJump, 0x01aabbcc);
|
|
CHECK_EQ(clone.bytecode(), Bytecode::kJump);
|
|
CHECK_EQ(clone.operand_count(), 1);
|
|
CHECK_EQ(clone.operand(0), 0x01aabbcc);
|
|
CHECK_EQ(clone.source_info(), source_info);
|
|
}
|
|
|
|
} // namespace interpreter
|
|
} // namespace internal
|
|
} // namespace v8
|