f4b5224ae9
Also fix some issues and improve test coverage. TEST=compiler-unittests BUG=v8:3489 LOG=y R=jarin@chromium.org Review URL: https://codereview.chromium.org/469743002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23111 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
257 lines
8.6 KiB
C++
257 lines
8.6 KiB
C++
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/compiler/change-lowering.h"
|
|
#include "src/compiler/common-operator.h"
|
|
#include "src/compiler/graph.h"
|
|
#include "src/compiler/node-properties-inl.h"
|
|
#include "src/compiler/simplified-operator.h"
|
|
#include "src/factory.h"
|
|
#include "test/compiler-unittests/compiler-unittests.h"
|
|
#include "test/compiler-unittests/node-matchers.h"
|
|
|
|
using testing::_;
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace compiler {
|
|
|
|
template <typename T>
|
|
class ChangeLoweringTest : public CompilerTest {
|
|
public:
|
|
static const size_t kPointerSize = sizeof(T);
|
|
|
|
explicit ChangeLoweringTest(int num_parameters = 1)
|
|
: graph_(zone()), common_(zone()), simplified_(zone()) {
|
|
graph()->SetStart(graph()->NewNode(common()->Start(num_parameters)));
|
|
}
|
|
virtual ~ChangeLoweringTest() {}
|
|
|
|
protected:
|
|
Node* Parameter(int32_t index = 0) {
|
|
return graph()->NewNode(common()->Parameter(index), graph()->start());
|
|
}
|
|
|
|
Reduction Reduce(Node* node) {
|
|
CompilationInfo info(isolate(), zone());
|
|
Linkage linkage(&info);
|
|
ChangeLowering<kPointerSize> reducer(graph(), &linkage);
|
|
return reducer.Reduce(node);
|
|
}
|
|
|
|
Graph* graph() { return &graph_; }
|
|
Factory* factory() const { return isolate()->factory(); }
|
|
CommonOperatorBuilder* common() { return &common_; }
|
|
SimplifiedOperatorBuilder* simplified() { return &simplified_; }
|
|
|
|
PrintableUnique<HeapObject> true_unique() {
|
|
return PrintableUnique<HeapObject>::CreateImmovable(
|
|
zone(), factory()->true_value());
|
|
}
|
|
PrintableUnique<HeapObject> false_unique() {
|
|
return PrintableUnique<HeapObject>::CreateImmovable(
|
|
zone(), factory()->false_value());
|
|
}
|
|
|
|
private:
|
|
Graph graph_;
|
|
CommonOperatorBuilder common_;
|
|
SimplifiedOperatorBuilder simplified_;
|
|
};
|
|
|
|
|
|
typedef ::testing::Types<int32_t, int64_t> ChangeLoweringTypes;
|
|
TYPED_TEST_CASE(ChangeLoweringTest, ChangeLoweringTypes);
|
|
|
|
|
|
TARGET_TYPED_TEST(ChangeLoweringTest, ChangeBitToBool) {
|
|
Node* val = this->Parameter(0);
|
|
Node* node =
|
|
this->graph()->NewNode(this->simplified()->ChangeBitToBool(), val);
|
|
Reduction reduction = this->Reduce(node);
|
|
ASSERT_TRUE(reduction.Changed());
|
|
|
|
Node* phi = reduction.replacement();
|
|
EXPECT_THAT(phi, IsPhi(IsHeapConstant(this->true_unique()),
|
|
IsHeapConstant(this->false_unique()), _));
|
|
|
|
Node* merge = NodeProperties::GetControlInput(phi);
|
|
ASSERT_EQ(IrOpcode::kMerge, merge->opcode());
|
|
|
|
Node* if_true = NodeProperties::GetControlInput(merge, 0);
|
|
ASSERT_EQ(IrOpcode::kIfTrue, if_true->opcode());
|
|
|
|
Node* if_false = NodeProperties::GetControlInput(merge, 1);
|
|
ASSERT_EQ(IrOpcode::kIfFalse, if_false->opcode());
|
|
|
|
Node* branch = NodeProperties::GetControlInput(if_true);
|
|
EXPECT_EQ(branch, NodeProperties::GetControlInput(if_false));
|
|
EXPECT_THAT(branch, IsBranch(val, this->graph()->start()));
|
|
}
|
|
|
|
|
|
TARGET_TYPED_TEST(ChangeLoweringTest, StringAdd) {
|
|
Node* node = this->graph()->NewNode(this->simplified()->StringAdd(),
|
|
this->Parameter(0), this->Parameter(1));
|
|
Reduction reduction = this->Reduce(node);
|
|
EXPECT_FALSE(reduction.Changed());
|
|
}
|
|
|
|
|
|
class ChangeLowering32Test : public ChangeLoweringTest<int32_t> {
|
|
public:
|
|
virtual ~ChangeLowering32Test() {}
|
|
};
|
|
|
|
|
|
TARGET_TEST_F(ChangeLowering32Test, ChangeBoolToBit) {
|
|
Node* val = Parameter(0);
|
|
Node* node = graph()->NewNode(simplified()->ChangeBoolToBit(), val);
|
|
Reduction reduction = Reduce(node);
|
|
ASSERT_TRUE(reduction.Changed());
|
|
|
|
EXPECT_THAT(reduction.replacement(),
|
|
IsWord32Equal(val, IsHeapConstant(true_unique())));
|
|
}
|
|
|
|
|
|
TARGET_TEST_F(ChangeLowering32Test, ChangeInt32ToTagged) {
|
|
Node* val = Parameter(0);
|
|
Node* node = graph()->NewNode(simplified()->ChangeInt32ToTagged(), val);
|
|
Reduction reduction = Reduce(node);
|
|
ASSERT_TRUE(reduction.Changed());
|
|
|
|
Node* phi = reduction.replacement();
|
|
ASSERT_EQ(IrOpcode::kPhi, phi->opcode());
|
|
|
|
Node* smi = NodeProperties::GetValueInput(phi, 1);
|
|
ASSERT_THAT(smi, IsProjection(0, IsInt32AddWithOverflow(val, val)));
|
|
|
|
Node* heap_number = NodeProperties::GetValueInput(phi, 0);
|
|
ASSERT_EQ(IrOpcode::kCall, heap_number->opcode());
|
|
|
|
Node* merge = NodeProperties::GetControlInput(phi);
|
|
ASSERT_EQ(IrOpcode::kMerge, merge->opcode());
|
|
|
|
const int32_t kValueOffset = HeapNumber::kValueOffset - kHeapObjectTag;
|
|
EXPECT_THAT(NodeProperties::GetControlInput(merge, 0),
|
|
IsStore(kMachineFloat64, kNoWriteBarrier, heap_number,
|
|
IsInt32Constant(kValueOffset),
|
|
IsChangeInt32ToFloat64(val), _, heap_number));
|
|
|
|
Node* if_true = NodeProperties::GetControlInput(heap_number);
|
|
ASSERT_EQ(IrOpcode::kIfTrue, if_true->opcode());
|
|
|
|
Node* if_false = NodeProperties::GetControlInput(merge, 1);
|
|
ASSERT_EQ(IrOpcode::kIfFalse, if_false->opcode());
|
|
|
|
Node* branch = NodeProperties::GetControlInput(if_true);
|
|
EXPECT_EQ(branch, NodeProperties::GetControlInput(if_false));
|
|
EXPECT_THAT(branch,
|
|
IsBranch(IsProjection(1, IsInt32AddWithOverflow(val, val)),
|
|
graph()->start()));
|
|
}
|
|
|
|
|
|
TARGET_TEST_F(ChangeLowering32Test, ChangeTaggedToFloat64) {
|
|
Node* val = Parameter(0);
|
|
Node* node = graph()->NewNode(simplified()->ChangeTaggedToFloat64(), val);
|
|
Reduction reduction = Reduce(node);
|
|
ASSERT_TRUE(reduction.Changed());
|
|
|
|
const int32_t kShiftAmount =
|
|
kSmiTagSize + SmiTagging<kPointerSize>::kSmiShiftSize;
|
|
const int32_t kValueOffset = HeapNumber::kValueOffset - kHeapObjectTag;
|
|
Node* phi = reduction.replacement();
|
|
ASSERT_THAT(
|
|
phi, IsPhi(IsLoad(kMachineFloat64, val, IsInt32Constant(kValueOffset), _),
|
|
IsChangeInt32ToFloat64(
|
|
IsWord32Sar(val, IsInt32Constant(kShiftAmount))),
|
|
_));
|
|
|
|
Node* merge = NodeProperties::GetControlInput(phi);
|
|
ASSERT_EQ(IrOpcode::kMerge, merge->opcode());
|
|
|
|
Node* if_true = NodeProperties::GetControlInput(merge, 0);
|
|
ASSERT_EQ(IrOpcode::kIfTrue, if_true->opcode());
|
|
|
|
Node* if_false = NodeProperties::GetControlInput(merge, 1);
|
|
ASSERT_EQ(IrOpcode::kIfFalse, if_false->opcode());
|
|
|
|
Node* branch = NodeProperties::GetControlInput(if_true);
|
|
EXPECT_EQ(branch, NodeProperties::GetControlInput(if_false));
|
|
STATIC_ASSERT(kSmiTag == 0);
|
|
STATIC_ASSERT(kSmiTagSize == 1);
|
|
EXPECT_THAT(branch, IsBranch(IsWord32And(val, IsInt32Constant(kSmiTagMask)),
|
|
graph()->start()));
|
|
}
|
|
|
|
|
|
class ChangeLowering64Test : public ChangeLoweringTest<int64_t> {
|
|
public:
|
|
virtual ~ChangeLowering64Test() {}
|
|
};
|
|
|
|
|
|
TARGET_TEST_F(ChangeLowering64Test, ChangeBoolToBit) {
|
|
Node* val = Parameter(0);
|
|
Node* node = graph()->NewNode(simplified()->ChangeBoolToBit(), val);
|
|
Reduction reduction = Reduce(node);
|
|
ASSERT_TRUE(reduction.Changed());
|
|
|
|
EXPECT_THAT(reduction.replacement(),
|
|
IsWord64Equal(val, IsHeapConstant(true_unique())));
|
|
}
|
|
|
|
|
|
TARGET_TEST_F(ChangeLowering64Test, ChangeInt32ToTagged) {
|
|
Node* val = Parameter(0);
|
|
Node* node = graph()->NewNode(simplified()->ChangeInt32ToTagged(), val);
|
|
Reduction reduction = Reduce(node);
|
|
ASSERT_TRUE(reduction.Changed());
|
|
|
|
const int32_t kShiftAmount =
|
|
kSmiTagSize + SmiTagging<kPointerSize>::kSmiShiftSize;
|
|
EXPECT_THAT(reduction.replacement(),
|
|
IsWord64Shl(val, IsInt32Constant(kShiftAmount)));
|
|
}
|
|
|
|
|
|
TARGET_TEST_F(ChangeLowering64Test, ChangeTaggedToFloat64) {
|
|
Node* val = Parameter(0);
|
|
Node* node = graph()->NewNode(simplified()->ChangeTaggedToFloat64(), val);
|
|
Reduction reduction = Reduce(node);
|
|
ASSERT_TRUE(reduction.Changed());
|
|
|
|
const int32_t kShiftAmount =
|
|
kSmiTagSize + SmiTagging<kPointerSize>::kSmiShiftSize;
|
|
const int32_t kValueOffset = HeapNumber::kValueOffset - kHeapObjectTag;
|
|
Node* phi = reduction.replacement();
|
|
ASSERT_THAT(
|
|
phi, IsPhi(IsLoad(kMachineFloat64, val, IsInt32Constant(kValueOffset), _),
|
|
IsChangeInt32ToFloat64(IsConvertInt64ToInt32(
|
|
IsWord64Sar(val, IsInt32Constant(kShiftAmount)))),
|
|
_));
|
|
|
|
Node* merge = NodeProperties::GetControlInput(phi);
|
|
ASSERT_EQ(IrOpcode::kMerge, merge->opcode());
|
|
|
|
Node* if_true = NodeProperties::GetControlInput(merge, 0);
|
|
ASSERT_EQ(IrOpcode::kIfTrue, if_true->opcode());
|
|
|
|
Node* if_false = NodeProperties::GetControlInput(merge, 1);
|
|
ASSERT_EQ(IrOpcode::kIfFalse, if_false->opcode());
|
|
|
|
Node* branch = NodeProperties::GetControlInput(if_true);
|
|
EXPECT_EQ(branch, NodeProperties::GetControlInput(if_false));
|
|
STATIC_ASSERT(kSmiTag == 0);
|
|
STATIC_ASSERT(kSmiTagSize == 1);
|
|
EXPECT_THAT(branch, IsBranch(IsWord64And(val, IsInt32Constant(kSmiTagMask)),
|
|
graph()->start()));
|
|
}
|
|
|
|
} // namespace compiler
|
|
} // namespace internal
|
|
} // namespace v8
|