v8/test/unittests/heap/global-safepoint-unittest.cc
Dominik Inführ 39975b4f33 [heap] Fix remaining test failures with --shared-heap
This CL fixes the remaining test failures when running test with the
--shared-heap flag locally:

* Remove uses of shared_isolate()
* Fix slot recording in Mark-Compact and Scavenger
* Fixes DCHECKs in tests that do not hold with --shared-heap

Bug: v8:13267
Change-Id: I6869ece70f1e6156d9bb1281e6cd876cf8d471eb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3918377
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Jakob Linke <jgruber@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83530}
2022-10-05 08:30:26 +00:00

149 lines
4.5 KiB
C++

// Copyright 2022 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "src/base/platform/mutex.h"
#include "src/base/platform/platform.h"
#include "src/heap/heap.h"
#include "src/heap/local-heap.h"
#include "src/heap/parked-scope.h"
#include "src/heap/safepoint.h"
#include "test/unittests/test-utils.h"
#include "testing/gtest/include/gtest/gtest.h"
#if V8_CAN_CREATE_SHARED_HEAP_BOOL
namespace v8 {
namespace internal {
using GlobalSafepointTest = TestJSSharedMemoryWithNativeContext;
namespace {
class IsolateWithContextWrapper {
public:
IsolateWithContextWrapper()
: isolate_wrapper_(kNoCounters),
isolate_scope_(isolate_wrapper_.isolate()),
handle_scope_(isolate_wrapper_.isolate()),
context_(v8::Context::New(isolate_wrapper_.isolate())),
context_scope_(context_) {}
v8::Isolate* v8_isolate() const { return isolate_wrapper_.isolate(); }
Isolate* isolate() const { return reinterpret_cast<Isolate*>(v8_isolate()); }
private:
IsolateWrapper isolate_wrapper_;
v8::Isolate::Scope isolate_scope_;
v8::HandleScope handle_scope_;
v8::Local<v8::Context> context_;
v8::Context::Scope context_scope_;
};
class ParkingThread : public v8::base::Thread {
public:
explicit ParkingThread(const Options& options) : v8::base::Thread(options) {}
void ParkedJoin(const ParkedScope& scope) {
USE(scope);
Join();
}
private:
using base::Thread::Join;
};
class InfiniteLooperThread final : public ParkingThread {
public:
InfiniteLooperThread(ParkingSemaphore* sema_ready,
ParkingSemaphore* sema_execute_start,
ParkingSemaphore* sema_execute_complete)
: ParkingThread(Options("InfiniteLooperThread")),
sema_ready_(sema_ready),
sema_execute_start_(sema_execute_start),
sema_execute_complete_(sema_execute_complete) {}
void Run() override {
IsolateWithContextWrapper isolate_wrapper;
v8::Isolate* v8_isolate = isolate_wrapper.v8_isolate();
v8::Isolate::Scope isolate_scope(v8_isolate);
v8::HandleScope scope(v8_isolate);
v8::Local<v8::String> source =
v8::String::NewFromUtf8(v8_isolate, "for(;;) {}").ToLocalChecked();
auto context = v8_isolate->GetCurrentContext();
v8::Local<v8::Value> result;
v8::Local<v8::Script> script =
v8::Script::Compile(context, source).ToLocalChecked();
sema_ready_->Signal();
sema_execute_start_->ParkedWait(
isolate_wrapper.isolate()->main_thread_local_isolate());
USE(script->Run(context));
sema_execute_complete_->Signal();
}
private:
ParkingSemaphore* sema_ready_;
ParkingSemaphore* sema_execute_start_;
ParkingSemaphore* sema_execute_complete_;
};
} // namespace
TEST_F(GlobalSafepointTest, Interrupt) {
constexpr int kThreads = 4;
Isolate* i_main_isolate = i_isolate();
ParkingSemaphore sema_ready(0);
ParkingSemaphore sema_execute_start(0);
ParkingSemaphore sema_execute_complete(0);
std::vector<std::unique_ptr<InfiniteLooperThread>> threads;
for (int i = 0; i < kThreads; i++) {
auto thread = std::make_unique<InfiniteLooperThread>(
&sema_ready, &sema_execute_start, &sema_execute_complete);
CHECK(thread->Start());
threads.push_back(std::move(thread));
}
LocalIsolate* local_isolate = i_main_isolate->main_thread_local_isolate();
for (int i = 0; i < kThreads; i++) {
sema_ready.ParkedWait(local_isolate);
}
for (int i = 0; i < kThreads; i++) {
sema_execute_start.Signal();
}
{
// Test that a global safepoint interrupts threads infinitely looping in JS.
// This wait is a big hack to increase the likelihood that the infinite
// looper threads will have entered into a steady state of infinitely
// looping. Otherwise the safepoint may be reached during allocation, such
// as of FeedbackVectors, and we wouldn't be testing the interrupt check.
base::OS::Sleep(base::TimeDelta::FromMilliseconds(500));
GlobalSafepointScope global_safepoint(i_main_isolate);
i_main_isolate->shared_heap_isolate()
->global_safepoint()
->IterateClientIsolates([](Isolate* client) {
client->stack_guard()->RequestTerminateExecution();
});
}
for (int i = 0; i < kThreads; i++) {
sema_execute_complete.ParkedWait(local_isolate);
}
ParkedScope parked(local_isolate);
for (auto& thread : threads) {
thread->ParkedJoin(parked);
}
}
} // namespace internal
} // namespace v8
#endif // V8_CAN_CREATE_SHARED_HEAP