f6450b97ec
1) Computed property keys (esp functions in them) shouldn't be inside the object literal scope. 2) I was using an imprecise "maybe uses super" and storing it to preparse data. This won't fly, since it pollutes sister scopes and leads to confusion wrt whether an object literal needs a home object or not. Made it precise (mostly cancelling changes in the original CL). 3) PreParser::NewSuperPropertyReference was creating a VariableProxy for this_function (which made it used) -> inconsistent scopes between parsing and preparsing. 4) MultipleEntryBlockContextScope was messing up the accumulator Original: https://chromium-review.googlesource.com/c/v8/v8/+/2563275 This saves memory (the home object doesn't need to be stored for each method, but only once per class) and hopefully makes the home object a constant in the optimized code. Detailed documentation of the changes: https://docs.google.com/document/d/1ZVXcoQdf9IdMsnRI9iyUjyq9NDoEyx9nA3XqMgwflMs/edit?usp=sharing Bug: v8:9237, chromium:1167918, chromium:1167981, chromium:1167988, chromium:1168055 Change-Id: I4f53f18cc18762c33e53d8c802909b42f1c33538 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2637220 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#72169}
188 lines
5.4 KiB
Plaintext
188 lines
5.4 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: yes
|
|
|
|
---
|
|
snippet: "
|
|
{
|
|
class A {
|
|
#a() { return 1; }
|
|
}
|
|
}
|
|
"
|
|
frame size: 7
|
|
parameter count: 1
|
|
bytecode array length: 51
|
|
bytecodes: [
|
|
/* 30 E> */ B(CreateBlockContext), U8(0),
|
|
B(PushContext), R(1),
|
|
B(LdaConstant), U8(2),
|
|
B(Star), R(3),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(3), U8(1),
|
|
B(StaCurrentContextSlot), U8(3),
|
|
B(CreateClosure), U8(3), U8(0), U8(2),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
B(LdaTheHole),
|
|
B(Star), R(6),
|
|
B(CreateClosure), U8(4), U8(1), U8(2),
|
|
B(Star), R(2),
|
|
B(LdaConstant), U8(1),
|
|
B(Star), R(4),
|
|
B(Mov), R(2), R(5),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(4), U8(3),
|
|
B(Star), R(4),
|
|
B(PopContext), R(1),
|
|
B(Mov), R(5), R(0),
|
|
B(LdaUndefined),
|
|
/* 77 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["A"],
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
{
|
|
class D {
|
|
#d() { return 1; }
|
|
}
|
|
class E extends D {
|
|
#e() { return 2; }
|
|
}
|
|
}
|
|
"
|
|
frame size: 8
|
|
parameter count: 1
|
|
bytecode array length: 100
|
|
bytecodes: [
|
|
/* 30 E> */ B(CreateBlockContext), U8(0),
|
|
B(PushContext), R(2),
|
|
B(LdaConstant), U8(2),
|
|
B(Star), R(4),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1),
|
|
B(StaCurrentContextSlot), U8(3),
|
|
B(CreateClosure), U8(3), U8(0), U8(2),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
B(LdaTheHole),
|
|
B(Star), R(7),
|
|
B(CreateClosure), U8(4), U8(1), U8(2),
|
|
B(Star), R(3),
|
|
B(LdaConstant), U8(1),
|
|
B(Star), R(5),
|
|
B(Mov), R(3), R(6),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(5), U8(3),
|
|
B(Star), R(5),
|
|
B(PopContext), R(2),
|
|
B(Mov), R(6), R(0),
|
|
/* 38 E> */ B(CreateBlockContext), U8(5),
|
|
B(PushContext), R(2),
|
|
B(LdaConstant), U8(7),
|
|
B(Star), R(4),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1),
|
|
B(StaCurrentContextSlot), U8(3),
|
|
B(CreateClosure), U8(8), U8(2), U8(2),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
/* 93 E> */ B(CreateClosure), U8(9), U8(3), U8(2),
|
|
B(Star), R(3),
|
|
B(LdaConstant), U8(6),
|
|
B(Star), R(5),
|
|
B(Mov), R(3), R(6),
|
|
B(Mov), R(0), R(7),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(5), U8(3),
|
|
B(Star), R(5),
|
|
B(PopContext), R(2),
|
|
B(Mov), R(6), R(1),
|
|
B(LdaUndefined),
|
|
/* 126 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["D"],
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["E"],
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
{
|
|
class A { foo() {} }
|
|
class C extends A {
|
|
#m() { return super.foo; }
|
|
}
|
|
}
|
|
"
|
|
frame size: 8
|
|
parameter count: 1
|
|
bytecode array length: 94
|
|
bytecodes: [
|
|
/* 30 E> */ B(CreateBlockContext), U8(0),
|
|
B(PushContext), R(2),
|
|
B(LdaTheHole),
|
|
B(Star), R(6),
|
|
B(CreateClosure), U8(2), U8(0), U8(2),
|
|
B(Star), R(3),
|
|
B(LdaConstant), U8(1),
|
|
B(Star), R(4),
|
|
B(CreateClosure), U8(3), U8(1), U8(2),
|
|
B(Star), R(7),
|
|
B(Mov), R(3), R(5),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(4), U8(4),
|
|
B(Star), R(4),
|
|
B(PopContext), R(2),
|
|
B(Mov), R(5), R(0),
|
|
/* 38 E> */ B(CreateBlockContext), U8(4),
|
|
B(PushContext), R(2),
|
|
B(LdaConstant), U8(6),
|
|
B(Star), R(4),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1),
|
|
B(StaCurrentContextSlot), U8(3),
|
|
B(CreateClosure), U8(7), U8(2), U8(2),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
/* 77 E> */ B(CreateClosure), U8(8), U8(3), U8(2),
|
|
B(Star), R(3),
|
|
B(LdaConstant), U8(5),
|
|
B(Star), R(5),
|
|
B(Mov), R(3), R(6),
|
|
B(Mov), R(0), R(7),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(5), U8(3),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
B(Star), R(5),
|
|
B(Ldar), R(6),
|
|
B(StaCurrentContextSlot), U8(5),
|
|
B(PopContext), R(2),
|
|
B(Star), R(1),
|
|
B(LdaUndefined),
|
|
/* 118 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["C"],
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|