32fc0acfef
This change implements optimizations for the `in` operator for packed array elements and object properties. It adds a new feedback slot kind and an IC path similar to KeyedLoadIC for handling the lookups. TurboFan uses the feedback to optimize based on the maps and keys. For more details see: https://docs.google.com/document/d/1tIfzywY8AeNVcy_sen-5Xev21MeZwjcU8QhSdzHvXig This can provide 10x performance improvements of on loops of the form: for (let i = 0; i < ary.length; ++i) { if (i in ary) { ... } } Bug: v8:8733 Change-Id: I766bf865a547a059e5bce5399bb6112e5d9a85c8 Reviewed-on: https://chromium-review.googlesource.com/c/1432598 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Matt Gardner <magardn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#59843}
71 lines
1.4 KiB
JavaScript
71 lines
1.4 KiB
JavaScript
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
// MODULE
|
|
|
|
import * as mod from "keyed-has-ic-module-export.js";
|
|
|
|
function testIn(obj, key) {
|
|
return key in obj;
|
|
}
|
|
|
|
function expectTrue(obj, key) {
|
|
assertTrue(testIn(obj, key));
|
|
}
|
|
|
|
function expectFalse(obj, key) {
|
|
assertFalse(testIn(obj, key));
|
|
}
|
|
|
|
var tests = {
|
|
monomporphicTrue: function() {
|
|
expectTrue(mod, "a");
|
|
expectTrue(mod, "a");
|
|
expectTrue(mod, "a");
|
|
},
|
|
|
|
polymprohicKeyTrue: function() {
|
|
expectTrue(mod, "a");
|
|
expectTrue(mod, "b");
|
|
expectTrue(mod, "c");
|
|
},
|
|
|
|
monomorphicFalse: function() {
|
|
expectFalse(mod, "d");
|
|
expectFalse(mod, "d");
|
|
expectFalse(mod, "d");
|
|
},
|
|
|
|
polymorphicKeyFalse: function() {
|
|
expectFalse(mod, "d");
|
|
expectFalse(mod, "e");
|
|
expectFalse(mod, "f");
|
|
},
|
|
|
|
polymorphicTrue: function() {
|
|
var o = {a: "A"};
|
|
expectTrue(mod, "a");
|
|
expectTrue(o, "a");
|
|
expectTrue(mod, "a");
|
|
expectTrue(o, "a");
|
|
},
|
|
|
|
polymorphicFalse: function() {
|
|
var o = {a: "A"};
|
|
expectFalse(mod, "d");
|
|
expectFalse(o, "d");
|
|
expectFalse(mod, "d");
|
|
expectFalse(o, "d");
|
|
}
|
|
};
|
|
|
|
for (let test in tests) {
|
|
%DeoptimizeFunction(testIn);
|
|
%ClearFunctionFeedback(testIn);
|
|
tests[test]();
|
|
%OptimizeFunctionOnNextCall(testIn);
|
|
tests[test]();
|
|
}
|