a8176a530c
Nop bytecodes are required only for break locations in debugger. Since nop bytecode doesn't change program state we can remove all of them. There are at least two changes which this CL produce: - we don't provide break position when we load local variable (still provide when load variable from global), - we don't provide break position for statements without actual break positions (e.g. "a;") - these expressions should be super rare and user always can set breakpoint before or after this statement. More details in one pager: https://docs.google.com/a/google.com/document/d/1JXlQpfMa9vRojbE272b6GMBbrfh6m_00135iAUOJEz8/edit?usp=sharing Bug: v8:6425 Change-Id: I4aee73d497a84f7b5d89caa6dda6d3060567dfda Reviewed-on: https://chromium-review.googlesource.com/543161 Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#46742}
54 lines
1.2 KiB
JavaScript
54 lines
1.2 KiB
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
var Debug = debug.Debug;
|
|
var step_count = 0;
|
|
|
|
function listener(event, execState, eventData, data) {
|
|
if (event != Debug.DebugEvent.Break) return;
|
|
try {
|
|
var line = execState.frame(0).sourceLineText();
|
|
print(line);
|
|
var [match, expected_count, step] = /\/\/ B(\d) (\w+)$/.exec(line);
|
|
assertEquals(step_count++, parseInt(expected_count));
|
|
if (step != "Continue") execState.prepareStep(Debug.StepAction[step]);
|
|
} catch (e) {
|
|
print(e, e.stack);
|
|
quit(1);
|
|
}
|
|
}
|
|
|
|
Debug.setListener(listener);
|
|
|
|
var late_resolve;
|
|
|
|
function g() {
|
|
return new Promise( // B2 StepOut
|
|
function(res, rej) {
|
|
late_resolve = res;
|
|
}
|
|
);
|
|
}
|
|
|
|
async function f() {
|
|
var a = 1;
|
|
debugger; // B0 StepNext
|
|
a +=
|
|
await // B1 StepIn
|
|
g(); // B2 StepIn
|
|
return a; // B4 StepNext
|
|
} // B5 Continue
|
|
|
|
f();
|
|
|
|
// Continuing at an intermediate break point means that we will
|
|
// carry on with the current async step.
|
|
debugger; // B3 Continue
|
|
|
|
late_resolve(3);
|
|
|
|
%RunMicrotasks();
|
|
|
|
assertEquals(6, step_count);
|