a81e8d16f4
Previously the `Debugger.CallFrame`s in `Debugger.paused` events would report locations relative to the surrounding document in case of inline scripts with `//@ sourceURL` annotations (while `Runtime.CallFrame` was already fixed previously as part of crrev.com/c/3069289). With this CL the locations in `Debugger.CallFrame` are also appropriately adjusted. Drive-by-fix: Several inspector tests were (incorrectly) relying on this wrong treatment, and were also unnecessarily using //# sourceURL annotations. So part of this CL also addresses that problem and makes the tests more robust, using addInlineScript() helper. Fixed: chromium:1283049 Bug: chromium:1183990, chromium:578269 Change-Id: I6e3b215d951c3453c0a9cfc9bccf3dc3d5e92fd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3359619 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#78450}
50 lines
1.7 KiB
JavaScript
50 lines
1.7 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
let {session, contextGroup, Protocol} = InspectorTest.start('Checks nested scheduled break in framework code.');
|
|
|
|
contextGroup.addInlineScript(
|
|
`
|
|
function frameworkCall(callback) {
|
|
inspector.callWithScheduledBreak(doFrameworkWork.bind(null, callback),
|
|
'top-framework-scheduled-break',
|
|
JSON.stringify({ data: 'data for top-framework-scheduled-break' }));
|
|
}
|
|
|
|
function doFrameworkWork(callback) {
|
|
inspector.callWithScheduledBreak(doFrameworkBreak, 'should-not-be-a-reason', '');
|
|
callback();
|
|
}
|
|
|
|
function doFrameworkBreak() {
|
|
inspector.breakProgram('framework-break', JSON.stringify({ data: 'data for framework-break' }));
|
|
}`,
|
|
'framework.js');
|
|
|
|
contextGroup.addInlineScript(
|
|
`
|
|
function testFunction() {
|
|
inspector.callWithScheduledBreak(frameworkCall.bind(null, callback),
|
|
'top-scheduled-break', '');
|
|
}
|
|
|
|
function callback() {
|
|
inspector.breakProgram('user-break', JSON.stringify({ data: 'data for user-break' }));
|
|
return 42;
|
|
}`,
|
|
'user.js');
|
|
|
|
session.setupScriptMap();
|
|
Protocol.Debugger.onPaused(message => {
|
|
InspectorTest.log('break reason: ' + message.params.reason);
|
|
InspectorTest.log('break aux data: ' + JSON.stringify(message.params.data || {}, null, ' '));
|
|
session.logCallFrames(message.params.callFrames);
|
|
InspectorTest.log('');
|
|
Protocol.Debugger.resume();
|
|
});
|
|
Protocol.Debugger.enable()
|
|
.then(() => Protocol.Debugger.setBlackboxPatterns({patterns: ['framework\.js']}))
|
|
.then(() => Protocol.Runtime.evaluate({ expression: 'testFunction()//# sourceURL=expr.js'}))
|
|
.then(InspectorTest.completeTest);
|