ffee558e14
With this CL, {CreateDefaultPlatform} returns a unique_ptr to indicate that the caller owns the returned memory. We had several memory leaks where the memory of the DefaultPlatform did not get deallocated. In addition, the {TracingController} of the {DefaultPlatform} also gets received as a unique_ptr. Thereby we document that the {DefaultPlatform} takes ownership of the {TracingController}. Note that the memory of the {TracingController} was already owned by the {DefaultPlatform}, but it was not documented in the interface, and it was used incorrectly in tests. This CL fixes the asan issues in https://chromium-review.googlesource.com/c/v8/v8/+/753583 ([platform] Implement TaskRunners in the DefaultPlatform) R=rmcilroy@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I0d1a6d3b22bb8289dc050b1977e4f58381cec675 Reviewed-on: https://chromium-review.googlesource.com/755033 Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#49349}
62 lines
2.0 KiB
C++
62 lines
2.0 KiB
C++
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
#include "include/libplatform/libplatform.h"
|
|
#include "include/v8.h"
|
|
|
|
int main(int argc, char* argv[]) {
|
|
// Initialize V8.
|
|
v8::V8::InitializeICUDefaultLocation(argv[0]);
|
|
v8::V8::InitializeExternalStartupData(argv[0]);
|
|
std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
|
|
v8::V8::InitializePlatform(platform.get());
|
|
v8::V8::Initialize();
|
|
|
|
// Create a new Isolate and make it the current one.
|
|
v8::Isolate::CreateParams create_params;
|
|
create_params.array_buffer_allocator =
|
|
v8::ArrayBuffer::Allocator::NewDefaultAllocator();
|
|
v8::Isolate* isolate = v8::Isolate::New(create_params);
|
|
{
|
|
v8::Isolate::Scope isolate_scope(isolate);
|
|
|
|
// Create a stack-allocated handle scope.
|
|
v8::HandleScope handle_scope(isolate);
|
|
|
|
// Create a new context.
|
|
v8::Local<v8::Context> context = v8::Context::New(isolate);
|
|
|
|
// Enter the context for compiling and running the hello world script.
|
|
v8::Context::Scope context_scope(context);
|
|
|
|
// Create a string containing the JavaScript source code.
|
|
v8::Local<v8::String> source =
|
|
v8::String::NewFromUtf8(isolate, "'Hello' + ', World!'",
|
|
v8::NewStringType::kNormal)
|
|
.ToLocalChecked();
|
|
|
|
// Compile the source code.
|
|
v8::Local<v8::Script> script =
|
|
v8::Script::Compile(context, source).ToLocalChecked();
|
|
|
|
// Run the script to get the result.
|
|
v8::Local<v8::Value> result = script->Run(context).ToLocalChecked();
|
|
|
|
// Convert the result to an UTF8 string and print it.
|
|
v8::String::Utf8Value utf8(isolate, result);
|
|
printf("%s\n", *utf8);
|
|
}
|
|
|
|
// Dispose the isolate and tear down V8.
|
|
isolate->Dispose();
|
|
v8::V8::Dispose();
|
|
v8::V8::ShutdownPlatform();
|
|
delete create_params.array_buffer_allocator;
|
|
return 0;
|
|
}
|