2b63d5d093
Now that we are able to compact map space, we can also get rid of the map space and allocate maps in the old space instead. This CL introduces a FLAG_map_space for enabling/disabling the map space but the map space remains enabled by default for now. Without a separate space for maps, the GC can't prevent relocation of maps anymore. Therefore this CL always allows compaction of maps when running without a map space. Rename flag to --compact-maps to better fit this scenario. mkgrokdump and debug_helper also need to be updated to look for maps also in the old space. The map space is now optional. Bug: v8:12578 Change-Id: Ic4e4abd0b58bee26e64329b1c92dbccb07d8105a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3424483 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79165}
87 lines
3.1 KiB
Python
87 lines
3.1 KiB
Python
#!/usr/bin/env python
|
|
# Copyright 2019 the V8 project authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
"""This program writes a C++ file that can be used to look up whether a given
|
|
address matches known object locations. The first argument is the directory
|
|
containing the file v8heapconst.py; the second argument is the output .cc file.
|
|
"""
|
|
|
|
import sys
|
|
sys.path.insert(0, sys.argv[1])
|
|
import v8heapconst
|
|
|
|
out = """
|
|
#include <cstdint>
|
|
#include <string>
|
|
|
|
#include "src/common/ptr-compr-inl.h"
|
|
#include "tools/debug_helper/debug-helper-internal.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace debug_helper_internal {
|
|
"""
|
|
|
|
def iterate_objects(target_space, camel_space_name):
|
|
global out
|
|
result = []
|
|
for (space, offset), (instance_type, name) in v8heapconst.KNOWN_MAPS.items():
|
|
if space == target_space:
|
|
result.append((offset, name))
|
|
for (space, offset), name in v8heapconst.KNOWN_OBJECTS.items():
|
|
if space == target_space and (space, offset) not in v8heapconst.KNOWN_MAPS:
|
|
result.append((offset, name))
|
|
out = out + '\nstd::string FindKnownObjectIn' + camel_space_name \
|
|
+ '(uintptr_t offset) {\n switch (offset) {\n'
|
|
for offset, name in result:
|
|
out = out + ' case ' + str(offset) + ': return "' + name + '";\n'
|
|
out = out + ' default: return "";\n }\n}\n'
|
|
|
|
iterate_objects('map_space', 'MapSpace')
|
|
iterate_objects('old_space', 'OldSpace')
|
|
iterate_objects('read_only_space', 'ReadOnlySpace')
|
|
|
|
|
|
def iterate_maps(target_space, camel_space_name):
|
|
global out
|
|
out = out + '\nint FindKnownMapInstanceTypeIn' + camel_space_name \
|
|
+ '(uintptr_t offset) {\n switch (offset) {\n'
|
|
for (space, offset), (instance_type, name) in v8heapconst.KNOWN_MAPS.items():
|
|
if space == target_space:
|
|
out = out + ' case ' + str(offset) + ': return ' + str(instance_type) \
|
|
+ ';\n'
|
|
out = out + ' default: return -1;\n }\n}\n'
|
|
|
|
iterate_maps('map_space', 'MapSpace')
|
|
iterate_maps('old_space', 'OldSpace')
|
|
iterate_maps('read_only_space', 'ReadOnlySpace')
|
|
|
|
out = out + '\nvoid FillInUnknownHeapAddresses(' + \
|
|
'd::HeapAddresses* heap_addresses, uintptr_t any_uncompressed_ptr) {\n'
|
|
if (hasattr(v8heapconst, 'HEAP_FIRST_PAGES')): # Only exists in ptr-compr builds.
|
|
out = out + ' if (heap_addresses->any_heap_pointer == 0) {\n'
|
|
out = out + ' heap_addresses->any_heap_pointer = any_uncompressed_ptr;\n'
|
|
out = out + ' }\n'
|
|
expected_spaces = set(['map_space', 'read_only_space', 'old_space'])
|
|
for offset, space_name in v8heapconst.HEAP_FIRST_PAGES.items():
|
|
if (space_name in expected_spaces):
|
|
out = out + ' if (heap_addresses->' + space_name + '_first_page == 0) {\n'
|
|
out = out + ' heap_addresses->' + space_name + \
|
|
'_first_page = i::DecompressTaggedPointer(any_uncompressed_ptr, ' + \
|
|
str(offset) + ');\n'
|
|
out = out + ' }\n'
|
|
out = out + '}\n'
|
|
|
|
out = out + '\n}\n}\n}\n'
|
|
|
|
try:
|
|
with open(sys.argv[2], "r") as out_file:
|
|
if out == out_file.read():
|
|
sys.exit(0) # No modification needed.
|
|
except:
|
|
pass # File probably doesn't exist; write it.
|
|
with open(sys.argv[2], "w") as out_file:
|
|
out_file.write(out)
|