ceb9c8127f
SharedFunctionInfos store their original function literal's id. This is also their index in the Script's SFI list. Since the function literal id is only needed for lazy compilation and live edit, we can calculate it on-the-fly by linear search in the Script SFI list, and save a field on the SFI. If this regresses compile performance, we could alternatively store the function literal id on the preparsed scope data as future work. Bug: chromium:818642 Change-Id: I5468cea0e115921f1c864d94e567d749a4349882 Reviewed-on: https://chromium-review.googlesource.com/1082480 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#53523}
52 lines
1.7 KiB
C++
52 lines
1.7 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "test/unittests/test-helpers.h"
|
|
|
|
#include "include/v8.h"
|
|
#include "src/api.h"
|
|
#include "src/handles.h"
|
|
#include "src/isolate.h"
|
|
#include "src/objects-inl.h"
|
|
#include "src/objects.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace test {
|
|
|
|
Handle<String> CreateSource(Isolate* isolate,
|
|
ExternalOneByteString::Resource* maybe_resource) {
|
|
static const char test_script[] = "(x) { x*x; }";
|
|
if (maybe_resource) {
|
|
return isolate->factory()
|
|
->NewExternalStringFromOneByte(maybe_resource)
|
|
.ToHandleChecked();
|
|
}
|
|
return isolate->factory()->NewStringFromAsciiChecked(test_script);
|
|
}
|
|
|
|
Handle<SharedFunctionInfo> CreateSharedFunctionInfo(
|
|
Isolate* isolate,
|
|
v8::String::ExternalOneByteStringResource* maybe_resource) {
|
|
HandleScope scope(isolate);
|
|
Handle<String> source = CreateSource(isolate, maybe_resource);
|
|
Handle<Script> script = isolate->factory()->NewScript(source);
|
|
Handle<WeakFixedArray> infos = isolate->factory()->NewWeakFixedArray(3);
|
|
script->set_shared_function_infos(*infos);
|
|
Handle<SharedFunctionInfo> shared =
|
|
isolate->factory()->NewSharedFunctionInfoForBuiltin(
|
|
isolate->factory()->NewStringFromAsciiChecked("f"),
|
|
Builtins::kCompileLazy);
|
|
shared->set_raw_end_position(source->length());
|
|
// Make sure we have an outer scope info, even though it's empty
|
|
shared->set_raw_outer_scope_info_or_feedback_metadata(
|
|
ScopeInfo::Empty(isolate));
|
|
SharedFunctionInfo::SetScript(shared, script, 1);
|
|
return scope.CloseAndEscape(shared);
|
|
}
|
|
|
|
} // namespace test
|
|
} // namespace internal
|
|
} // namespace v8
|