c4113c4705
Changes: - Remove TypeCheckBranchResult. Change TypeCheckBranch() to return bool. Refactor call sites to reflect this (decouple current code reachability check from type check). - Unify TypeCheckBranch(), TypeCheckFallthrough(), and the type-checking part of Return() into TypeCheckStackAgainstMerge(). - Make sure all TypeCheck* functions are only called within VALIDATE. - In graph-builder-interface, rename end_env -> merge_env to reflect its function for loops. - Change expected error messages in some tests. Change-Id: I857edc18db9c2454ad12d539ffe7a10e96367710 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2839560 Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#74100}
68 lines
2.5 KiB
JavaScript
68 lines
2.5 KiB
JavaScript
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be found
|
|
// in the LICENSE file.
|
|
|
|
// Flags: --experimental-wasm-compilation-hints
|
|
|
|
load('test/mjsunit/wasm/wasm-module-builder.js');
|
|
|
|
(function testCompileWithBadLazyHint() {
|
|
print(arguments.callee.name);
|
|
let builder = new WasmModuleBuilder();
|
|
builder.addFunction('id', kSig_i_i)
|
|
.addBody([kExprLocalGet, 0])
|
|
.setCompilationHint(kCompilationHintStrategyLazy,
|
|
kCompilationHintTierOptimized,
|
|
kCompilationHintTierBaseline)
|
|
.exportFunc();
|
|
assertThrows(() => builder.toModule(),
|
|
WebAssembly.CompileError,
|
|
"WebAssembly.Module(): Invalid compilation hint 0x19 " +
|
|
"(forbidden downgrade) @+49");
|
|
})();
|
|
|
|
(function testCompileWithBadLazyFunctionBody() {
|
|
print(arguments.callee.name);
|
|
let builder = new WasmModuleBuilder();
|
|
builder.addFunction('id', kSig_i_l)
|
|
.addBody([kExprLocalGet, 0])
|
|
.setCompilationHint(kCompilationHintStrategyLazy,
|
|
kCompilationHintTierDefault,
|
|
kCompilationHintTierDefault)
|
|
.exportFunc();
|
|
assertThrows(() => builder.toModule(),
|
|
WebAssembly.CompileError,
|
|
"WebAssembly.Module(): Compiling function #0:\"id\" failed: type error " +
|
|
"in fallthru[0] (expected i32, got i64) @+56");
|
|
})();
|
|
|
|
(function testCompileEmptyModule() {
|
|
print(arguments.callee.name);
|
|
let builder = new WasmModuleBuilder();
|
|
builder.toModule();
|
|
})();
|
|
|
|
(function testCompileLazyModule() {
|
|
print(arguments.callee.name);
|
|
let builder = new WasmModuleBuilder();
|
|
builder.addFunction('id', kSig_i_i)
|
|
.addBody([kExprLocalGet, 0])
|
|
.setCompilationHint(kCompilationHintStrategyLazy,
|
|
kCompilationHintTierDefault,
|
|
kCompilationHintTierDefault)
|
|
.exportFunc();
|
|
assertEquals(42, builder.instantiate().exports.id(42));
|
|
})();
|
|
|
|
(function testCompileLazyBaselineEagerTopTierModule() {
|
|
print(arguments.callee.name);
|
|
let builder = new WasmModuleBuilder();
|
|
builder.addFunction('id', kSig_i_i)
|
|
.addBody([kExprLocalGet, 0])
|
|
.setCompilationHint(kCompilationHintStrategyLazyBaselineEagerTopTier,
|
|
kCompilationHintTierDefault,
|
|
kCompilationHintTierDefault)
|
|
.exportFunc();
|
|
assertEquals(42, builder.instantiate().exports.id(42));
|
|
})();
|