e0b18b9022
This is a reland of a0728e869b
Original change's description:
> [d8] Remove maximum workers limitation
>
> This CL refactors the lifetime management of the v8::Worker C++ object
> and in the process lifts the 100 maximum worker limitation. To do this,
> it uses a Managed<v8::Worker> heap object and attaches the managed to
> the API worker object.
>
> R=mstarzinger@chromium.org
> BUG=v8:9524
>
> Change-Id: I279b7aeb6645a87f9108ee6f572105739721cef4
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1715453
> Commit-Queue: Ben Titzer <titzer@chromium.org>
> Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#62932}
Bug: v8:9524
Change-Id: I7d903fb12ddb00909a9429455f46c55db2fd02de
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1722562
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Ben Titzer <titzer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#62974}
110 lines
3.0 KiB
C++
110 lines
3.0 KiB
C++
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
#ifdef V8_INTL_SUPPORT
|
|
#include "src/base/platform/platform.h"
|
|
#include "src/date/date.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
#include "unicode/strenum.h"
|
|
#include "unicode/timezone.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
// A recent time for the test.
|
|
// 2019-05-08T04:16:04.845Z
|
|
static const int64_t kStartTime = 1557288964845;
|
|
|
|
class AdoptDefaultThread final : public base::Thread {
|
|
public:
|
|
AdoptDefaultThread() : base::Thread(Options("AdoptDefault")) {}
|
|
|
|
void Run() override {
|
|
printf("AdoptDefaultThread Start\n");
|
|
std::unique_ptr<icu::StringEnumeration> timezones(
|
|
icu::TimeZone::createEnumeration());
|
|
UErrorCode status = U_ZERO_ERROR;
|
|
const icu::UnicodeString* timezone = timezones->snext(status);
|
|
icu::TimeZone::adoptDefault(icu::TimeZone::createTimeZone(*timezone));
|
|
printf("AdoptDefaultThread End\n");
|
|
}
|
|
};
|
|
|
|
class GetLocalOffsetFromOSThread final : public base::Thread {
|
|
public:
|
|
explicit GetLocalOffsetFromOSThread(bool utc)
|
|
: base::Thread(Options("GetLocalOffsetFromOS")), utc_(utc) {}
|
|
|
|
void Run() override {
|
|
printf("GetLocalOffsetFromOSThread Start\n");
|
|
DateCache date_cache;
|
|
date_cache.GetLocalOffsetFromOS(kStartTime, utc_);
|
|
printf("GetLocalOffsetFromOSThread End\n");
|
|
}
|
|
|
|
private:
|
|
bool utc_;
|
|
};
|
|
|
|
class LocalTimezoneThread final : public base::Thread {
|
|
public:
|
|
LocalTimezoneThread() : base::Thread(Options("LocalTimezone")) {}
|
|
|
|
void Run() override {
|
|
printf("LocalTimezoneThread Start\n");
|
|
DateCache date_cache;
|
|
date_cache.LocalTimezone(kStartTime);
|
|
printf("LocalTimezoneThread End\n");
|
|
}
|
|
};
|
|
|
|
TEST(DateCache, AdoptDefaultFirst) {
|
|
AdoptDefaultThread t1;
|
|
GetLocalOffsetFromOSThread t2(true);
|
|
GetLocalOffsetFromOSThread t3(false);
|
|
LocalTimezoneThread t4;
|
|
|
|
// The AdoptDefaultFirst will always pass. Just a test to ensure
|
|
// our testing code itself is correct.
|
|
// We finish all the operation AdoptDefaultThread before
|
|
// running all other thread so it won't show the problem of
|
|
// AdoptDefault trashing newly create default.
|
|
CHECK(t1.Start());
|
|
t1.Join();
|
|
|
|
CHECK(t2.Start());
|
|
CHECK(t3.Start());
|
|
CHECK(t4.Start());
|
|
|
|
t2.Join();
|
|
t3.Join();
|
|
t4.Join();
|
|
}
|
|
|
|
TEST(DateCache, AdoptDefaultMixed) {
|
|
AdoptDefaultThread t1;
|
|
GetLocalOffsetFromOSThread t2(true);
|
|
GetLocalOffsetFromOSThread t3(false);
|
|
LocalTimezoneThread t4;
|
|
|
|
// The AdoptDefaultMixed run AdoptDefaultThread concurrently
|
|
// with other thread so if the AdoptDefault is not thread safe
|
|
// it will cause crash in other thread because the TimeZone
|
|
// newly created by createDefault could be trashed by AdoptDefault
|
|
// while a deleted DEFAULT_ZONE got cloned.
|
|
CHECK(t1.Start());
|
|
CHECK(t2.Start());
|
|
CHECK(t3.Start());
|
|
CHECK(t4.Start());
|
|
|
|
t1.Join();
|
|
t2.Join();
|
|
t3.Join();
|
|
t4.Join();
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif // V8_INTL_SUPPORT
|