f11a938ad5
With this CL the registers in a register pair get ordered such that the low word register always has a lower register code than the high word register. This should allow easier reasoning about the register allocation, and prevent some register allocation bugs. Background: for many operations in Liftoff, input registers are reused as output registers. With register pairs, input register pairs are reused as output register pairs. Additional reasoning, and sometimes even additional code is needed when the registers of the output register pair are swapped, i.e. when the high word register of the input becomes the low word register of the output. With this CL the additional reasoning is not necessary anymore, as the high word and low word registers would get swapped during register allocation. Additionally this CL fixes the logic of the last_spilled_regs list. This list stored the last spilled registers, but recorded only one of the two registers of a register pair. With this CL, both registers get recorded. This CL does not have a regression test. The regression test was more than 9000 lines long, and quite slow. I was not able to minimize it substantially. The test would be fragile by nature, as it has to create a special register configuration or otherwise does not test anything meaningful. All in all I think it's better not to add the test. R=clemensb@chromium.org Bug: chromium:1074586 Change-Id: I4b2475b0c6537c7ce2e51fee281388cdd85f2953 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2168875 Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#67473}
95 lines
3.5 KiB
JavaScript
95 lines
3.5 KiB
JavaScript
// Copyright 2020 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --wasm-staging
|
|
|
|
load('test/mjsunit/wasm/wasm-module-builder.js');
|
|
|
|
const builder = new WasmModuleBuilder();
|
|
builder.addMemory(1, 1, false, true);
|
|
builder.addGlobal(kWasmI32, 1);
|
|
const sig = builder.addType(makeSig([kWasmI32, kWasmI64, kWasmI64, kWasmI64], [kWasmF32]));
|
|
// Generate function 1 (out of 3).
|
|
builder.addFunction(undefined, sig)
|
|
.addLocals({i32_count: 57}).addLocals({i64_count: 11})
|
|
.addBodyWithEnd([
|
|
// signature: f_illl
|
|
// body:
|
|
kExprLocalGet, 0x1b, // local.get
|
|
kExprLocalSet, 0x1c, // local.set
|
|
kExprI32Const, 0x00, // i32.const
|
|
kExprIf, kWasmStmt, // if @11
|
|
kExprGlobalGet, 0x00, // global.get
|
|
kExprLocalSet, 0x1e, // local.set
|
|
kExprBlock, kWasmStmt, // block @19
|
|
kExprGlobalGet, 0x00, // global.get
|
|
kExprLocalSet, 0x21, // local.set
|
|
kExprBlock, kWasmStmt, // block @25
|
|
kExprBlock, kWasmStmt, // block @27
|
|
kExprBlock, kWasmStmt, // block @29
|
|
kExprGlobalGet, 0x00, // global.get
|
|
kExprLocalSet, 0x0a, // local.set
|
|
kExprI32Const, 0x00, // i32.const
|
|
kExprLocalSet, 0x28, // local.set
|
|
kExprLocalGet, 0x00, // local.get
|
|
kExprLocalSet, 0x0b, // local.set
|
|
kExprI32Const, 0x00, // i32.const
|
|
kExprBrIf, 0x01, // br_if depth=1
|
|
kExprEnd, // end @47
|
|
kExprUnreachable, // unreachable
|
|
kExprEnd, // end @49
|
|
kExprI32Const, 0x01, // i32.const
|
|
kExprLocalSet, 0x36, // local.set
|
|
kExprI32Const, 0x00, // i32.const
|
|
kExprIf, kWasmStmt, // if @56
|
|
kExprEnd, // end @59
|
|
kExprLocalGet, 0x00, // local.get
|
|
kExprLocalSet, 0x10, // local.set
|
|
kExprI32Const, 0x00, // i32.const
|
|
kExprI32Eqz, // i32.eqz
|
|
kExprLocalSet, 0x38, // local.set
|
|
kExprBlock, kWasmStmt, // block @69
|
|
kExprI32Const, 0x7f, // i32.const
|
|
kExprI32Eqz, // i32.eqz
|
|
kExprLocalSet, 0x39, // local.set
|
|
kExprI32Const, 0x01, // i32.const
|
|
kExprIf, kWasmStmt, // if @78
|
|
kExprGlobalGet, 0x00, // global.get
|
|
kExprLocalSet, 0x11, // local.set
|
|
kExprI32Const, 0x00, // i32.const
|
|
kExprI32Eqz, // i32.eqz
|
|
kExprLocalSet, 0x12, // local.set
|
|
kExprGlobalGet, 0x00, // global.get
|
|
kExprLocalSet, 0x13, // local.set
|
|
kExprI32Const, 0x00, // i32.const
|
|
kExprI32Const, 0x01, // i32.const
|
|
kExprI32Sub, // i32.sub
|
|
kExprLocalSet, 0x3a, // local.set
|
|
kExprI32Const, 0x00, // i32.const
|
|
kAtomicPrefix, kExprI64AtomicLoad16U, 0x01, 0x04, // i64.atomic.load16_u
|
|
kExprDrop, // drop
|
|
kExprI64Const, 0x01, // i64.const
|
|
kExprLocalSet, 0x44, // local.set
|
|
kExprI64Const, 0x01, // i64.const
|
|
kExprLocalSet, 0x3e, // local.set
|
|
kExprElse, // else @115
|
|
kExprNop, // nop
|
|
kExprEnd, // end @117
|
|
kExprLocalGet, 0x40, // local.get
|
|
kExprLocalSet, 0x41, // local.set
|
|
kExprLocalGet, 0x41, // local.get
|
|
kExprI64Const, 0x4b, // i64.const
|
|
kExprI64Add, // i64.add
|
|
kExprDrop, // drop
|
|
kExprEnd, // end @128
|
|
kExprEnd, // end @129
|
|
kExprUnreachable, // unreachable
|
|
kExprEnd, // end @132
|
|
kExprUnreachable, // unreachable
|
|
kExprEnd, // end @134
|
|
kExprF32Const, 0x00, 0x00, 0x84, 0x42, // f32.const
|
|
kExprEnd, // end @140
|
|
]);
|
|
const instance = builder.instantiate();
|