d324382e1c
This is a reland of a462a7854a
Original change's description:
> [turboassembler] Introduce hard-abort mode
>
> For checks and assertions (mostly for debug code, like stack alignment
> or zero extension), we had two modes: Emit a call to the {Abort}
> runtime function (the default), and emit a debug break (used for
> testing, enabled via --trap-on-abort).
> In wasm, where we cannot just call a runtime function because code must
> be isolate independent, we always used the trap-on-abort behaviour.
> This causes problems for our fuzzers, which do not catch SIGTRAP, and
> hence do not detect debug code failures.
>
> This CL introduces a third mode ("hard abort"), which calls a C
> function via {ExternalReference}. The C function still outputs the
> abort reason, but does not print the stack trace. It then aborts via
> "OS::Abort", just like the runtime function.
> This will allow fuzzers to detect the crash and even find a nice error
> message.
>
> Even though this looks like a lot of code churn, it is actually not.
> Most added lines are new tests, and other changes are minimal.
>
> R=mstarzinger@chromium.org
>
> Bug: chromium:863799
> Change-Id: I77c58ff72db552d49014614436259ccfb49ba87b
> Reviewed-on: https://chromium-review.googlesource.com/1142163
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#54592}
Bug: chromium:863799
Change-Id: I7729a47b4823a982a8e201df36520aa2b6ef5326
Reviewed-on: https://chromium-review.googlesource.com/1146100
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54656}
148 lines
4.8 KiB
C++
148 lines
4.8 KiB
C++
// Copyright 2013 the V8 project authors. All rights reserved.
|
|
// Rrdistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Rrdistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Rrdistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include "src/v8.h"
|
|
|
|
#include "src/base/platform/platform.h"
|
|
#include "src/code-stubs.h"
|
|
#include "src/heap/factory.h"
|
|
#include "src/macro-assembler.h"
|
|
#include "src/objects-inl.h"
|
|
#include "src/register-configuration.h"
|
|
#include "test/cctest/cctest.h"
|
|
#include "test/cctest/test-code-stubs.h"
|
|
#include "test/common/assembler-tester.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace test_code_stubs_x64 {
|
|
|
|
#define __ masm.
|
|
|
|
ConvertDToIFunc MakeConvertDToIFuncTrampoline(Isolate* isolate,
|
|
Register destination_reg) {
|
|
HandleScope handles(isolate);
|
|
|
|
size_t allocated;
|
|
byte* buffer = AllocateAssemblerBuffer(&allocated);
|
|
MacroAssembler masm(isolate, buffer, static_cast<int>(allocated),
|
|
v8::internal::CodeObjectRequired::kYes);
|
|
|
|
Handle<Code> code = BUILTIN_CODE(isolate, DoubleToI);
|
|
Address start = code->InstructionStart();
|
|
|
|
__ pushq(rbx);
|
|
__ pushq(rcx);
|
|
__ pushq(rdx);
|
|
__ pushq(rsi);
|
|
__ pushq(rdi);
|
|
|
|
const RegisterConfiguration* config = RegisterConfiguration::Default();
|
|
|
|
// Save registers make sure they don't get clobbered.
|
|
int reg_num = 0;
|
|
for (; reg_num < config->num_allocatable_general_registers(); ++reg_num) {
|
|
Register reg =
|
|
Register::from_code(config->GetAllocatableGeneralCode(reg_num));
|
|
if (reg != rsp && reg != rbp && reg != destination_reg) {
|
|
__ pushq(reg);
|
|
}
|
|
}
|
|
|
|
// Put the double argument into the designated double argument slot.
|
|
__ subq(rsp, Immediate(kDoubleSize));
|
|
__ Movsd(MemOperand(rsp, 0), xmm0);
|
|
|
|
// Call through to the actual stub
|
|
__ Call(start, RelocInfo::EXTERNAL_REFERENCE);
|
|
__ movl(destination_reg, MemOperand(rsp, 0));
|
|
|
|
__ addq(rsp, Immediate(kDoubleSize));
|
|
|
|
// Make sure no registers have been unexpectedly clobbered
|
|
for (--reg_num; reg_num >= 0; --reg_num) {
|
|
Register reg =
|
|
Register::from_code(config->GetAllocatableGeneralCode(reg_num));
|
|
if (reg != rsp && reg != rbp && reg != destination_reg) {
|
|
__ cmpq(reg, MemOperand(rsp, 0));
|
|
__ Assert(equal, AbortReason::kRegisterWasClobbered);
|
|
__ addq(rsp, Immediate(kPointerSize));
|
|
}
|
|
}
|
|
|
|
__ movq(rax, destination_reg);
|
|
|
|
__ popq(rdi);
|
|
__ popq(rsi);
|
|
__ popq(rdx);
|
|
__ popq(rcx);
|
|
__ popq(rbx);
|
|
|
|
__ ret(0);
|
|
|
|
CodeDesc desc;
|
|
masm.GetCode(isolate, &desc);
|
|
MakeAssemblerBufferExecutable(buffer, allocated);
|
|
return reinterpret_cast<ConvertDToIFunc>(
|
|
reinterpret_cast<intptr_t>(buffer));
|
|
}
|
|
|
|
#undef __
|
|
|
|
|
|
static Isolate* GetIsolateFrom(LocalContext* context) {
|
|
return reinterpret_cast<Isolate*>((*context)->GetIsolate());
|
|
}
|
|
|
|
|
|
TEST(ConvertDToI) {
|
|
CcTest::InitializeVM();
|
|
LocalContext context;
|
|
Isolate* isolate = GetIsolateFrom(&context);
|
|
HandleScope scope(isolate);
|
|
|
|
#if DEBUG
|
|
// Verify that the tests actually work with the C version. In the release
|
|
// code, the compiler optimizes it away because it's all constant, but does it
|
|
// wrong, triggering an assert on gcc.
|
|
RunAllTruncationTests(&ConvertDToICVersion);
|
|
#endif
|
|
|
|
Register dest_registers[] = {rax, rbx, rcx, rdx, rsi, rdi, r8, r9};
|
|
|
|
for (size_t d = 0; d < sizeof(dest_registers) / sizeof(Register); d++) {
|
|
RunAllTruncationTests(
|
|
MakeConvertDToIFuncTrampoline(isolate, dest_registers[d]));
|
|
}
|
|
}
|
|
|
|
} // namespace test_code_stubs_x64
|
|
} // namespace internal
|
|
} // namespace v8
|