379331b7a4
Previously we'd attach source positions to implicit returns that are generated when leaving an async function with a promise rejection. This was due to the use of `kNoSourcePosition` on the `end_position` in the `ReturnStatement` nodes as indicator to pick the return position from the function literal, instead of really not putting a source position on that specific `Return` bytecode. This CL adds a dedicated marker to `ReturnStatement` to express that the `BytecodeGenerator` should put the return position from the function literal there instead of overloading the meaning of `kNoSourcePosition`. Bug: chromium:901819, chromium:782461 Fixed: chromium:1199919, chromium:1201706 Change-Id: I3647e0c3d711e9c3d6ae44606b70ec92ad82e1cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859945 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#74301}
45 lines
1.8 KiB
JavaScript
45 lines
1.8 KiB
JavaScript
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
const {session, contextGroup, Protocol} =
|
|
InspectorTest.start('Regression test for crbug/1199919');
|
|
|
|
const source = `
|
|
async function defaultParameter(x = 1) {
|
|
return x;
|
|
}
|
|
|
|
async function destructuringParameter({x}) {
|
|
return x;
|
|
}
|
|
`;
|
|
const url = 'v8://test.js';
|
|
|
|
contextGroup.addScript(source, 0, 0, url);
|
|
session.setupScriptMap();
|
|
|
|
InspectorTest.runAsyncTestSuite([
|
|
async function testDefaultParameter() {
|
|
await Promise.all([Protocol.Runtime.enable(), Protocol.Debugger.enable()]);
|
|
const {result: {breakpointId}} = await Protocol.Debugger.setBreakpointByUrl({lineNumber: 2, url});
|
|
const evalPromise = Protocol.Runtime.evaluate({expression: 'defaultParameter()'});
|
|
const {params: {callFrames}} = await Protocol.Debugger.oncePaused();
|
|
session.logCallFrames(callFrames);
|
|
await Protocol.Debugger.removeBreakpoint({breakpointId});
|
|
await Promise.all([Protocol.Debugger.resume(), evalPromise]);
|
|
await Promise.all([Protocol.Runtime.disable(), Protocol.Debugger.disable()]);
|
|
},
|
|
|
|
async function testDestructuringParameter() {
|
|
await Promise.all([Protocol.Runtime.enable(), Protocol.Debugger.enable()]);
|
|
const {result: {breakpointId}} = await Protocol.Debugger.setBreakpointByUrl({lineNumber: 6, url});
|
|
const evalPromise = Protocol.Runtime.evaluate({expression: 'destructuringParameter({x: 5})'});
|
|
const {params: {callFrames}} = await Protocol.Debugger.oncePaused();
|
|
session.logCallFrames(callFrames);
|
|
await Protocol.Debugger.removeBreakpoint({breakpointId});
|
|
await Promise.all([Protocol.Debugger.resume(), evalPromise]);
|
|
await Promise.all([Protocol.Runtime.disable(), Protocol.Debugger.disable()]);
|
|
}
|
|
]);
|