fed41a9235
CallWithArrayLike was optimized in TF only for 'arguments' in inlined functions. Here we add logic to optimize also in non inlined functions, enabling the rewriting of Function.prototype.apply(f, [1, 2, 3]) as f(1, 2, 3). Bug: v8:9974 Change-Id: Icc9ccfc2276f75d06755176b55e7a02ddfdb04ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2805623 Commit-Queue: Paolo Severini <paolosev@microsoft.com> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74723}
49 lines
1.5 KiB
JavaScript
49 lines
1.5 KiB
JavaScript
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --turbo-optimize-apply --opt
|
|
|
|
// These tests do not work well if this script is run more than once (e.g.
|
|
// --stress-opt); after a few runs the whole function is immediately compiled
|
|
// and assertions would fail. We prevent re-runs.
|
|
// Flags: --nostress-opt --no-always-opt
|
|
|
|
// Tests for optimization of CallWithSpread and CallWithArrayLike.
|
|
// This test is in a separate file because it invalidates protectors.
|
|
|
|
// Test with array prototype modified after compilation.
|
|
(function () {
|
|
"use strict";
|
|
|
|
var sum_js3_got_interpreted = true;
|
|
function sum_js3(a, b, c) {
|
|
sum_js3_got_interpreted = %IsBeingInterpreted();
|
|
return a + b + c;
|
|
}
|
|
function foo(x, y) {
|
|
return sum_js3.apply(null, [x, , y]);
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(sum_js3);
|
|
%PrepareFunctionForOptimization(foo);
|
|
assertEquals('AundefinedB', foo('A', 'B'));
|
|
assertTrue(sum_js3_got_interpreted);
|
|
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertEquals('AundefinedB', foo('A', 'B'));
|
|
assertFalse(sum_js3_got_interpreted);
|
|
assertOptimized(foo);
|
|
|
|
// Modify the array prototype, define a default value for element [1].
|
|
Array.prototype[1] = 'x';
|
|
assertUnoptimized(foo);
|
|
|
|
// Now the call will not be inlined.
|
|
%PrepareFunctionForOptimization(foo);
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertEquals('AxB', foo('A', 'B'));
|
|
assertTrue(sum_js3_got_interpreted);
|
|
assertOptimized(foo);
|
|
})();
|