f6f8062fca
Reason for revert: Breaks: https://build.chromium.org/p/client.v8.fyi/builders/V8%20Android%20GN%20%28dbg%29/builds/4590 And also the trybot: https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/99806 Original issue's description: > Fix double-building of v8 in GN builds when setting just v8_target_cpu. > > Because of the somewhat strange way default toolchains and custom > toolchains and user-specified arguments work in GN, if you did a v8 > build that just set v8_target_cpu, you could end up building two > identical copies of v8 (see the comments in the change for more). > > This CL identifies that case and fixes it. > > R=machenbach@chromium.org > BUG=629825 > > Committed: https://crrev.com/3536db45c9409c9aadc4eee6004cf337c0588cdb > Cr-Commit-Position: refs/heads/master@{#37926} TBR=dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=629825 Review-Url: https://codereview.chromium.org/2167113002 Cr-Commit-Position: refs/heads/master@{#37936}
70 lines
3.0 KiB
Plaintext
70 lines
3.0 KiB
Plaintext
# Copyright 2015 the V8 project authors. All rights reserved.
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions are
|
|
# met:
|
|
#
|
|
# * Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
# * Redistributions in binary form must reproduce the above
|
|
# copyright notice, this list of conditions and the following
|
|
# disclaimer in the documentation and/or other materials provided
|
|
# with the distribution.
|
|
# * Neither the name of Google Inc. nor the names of its
|
|
# contributors may be used to endorse or promote products derived
|
|
# from this software without specific prior written permission.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
import("//build/config/v8_target_cpu.gni")
|
|
|
|
declare_args() {
|
|
# The snapshot needs to be compiled for the host, but compiled with
|
|
# a toolchain that matches the bit-width of the target.
|
|
v8_snapshot_toolchain = ""
|
|
}
|
|
|
|
# TODO(GYP): For now we only support 32-bit little-endian target builds from an
|
|
# x64 Linux host. Eventually we need to support all of the host/target
|
|
# configurations v8 runs on.
|
|
if (v8_snapshot_toolchain == "") {
|
|
if (host_cpu == "x64" && host_os == "linux") {
|
|
if (current_cpu == "arm" || current_cpu == "mipsel" ||
|
|
current_cpu == "x86") {
|
|
_snapshot_cpu = "x86"
|
|
} else {
|
|
assert(current_cpu == "arm64" || current_cpu == "x64" ||
|
|
current_cpu == "mipsel64",
|
|
"Need environment for this arch: $current_cpu")
|
|
_snapshot_cpu = "x64"
|
|
}
|
|
|
|
if (v8_current_cpu != _snapshot_cpu) {
|
|
_cpus = "${_snapshot_cpu}_v8_${v8_current_cpu}"
|
|
} else {
|
|
_cpus = _snapshot_cpu
|
|
}
|
|
|
|
if ((host_os == "linux" && current_os == "android") || is_clang) {
|
|
v8_snapshot_toolchain = "//build/toolchain/linux:clang_${_cpus}"
|
|
} else {
|
|
v8_snapshot_toolchain = "//build/toolchain/linux:${_cpus}"
|
|
}
|
|
} else if (host_os == "mac" && current_os == "win") {
|
|
assert(v8_current_cpu == current_cpu,
|
|
"v8 target must match the regular target on this platform")
|
|
v8_snapshot_toolchain = "//build/toolchain/mac:clang_$current_cpu"
|
|
} else {
|
|
v8_snapshot_toolchain = default_toolchain
|
|
}
|
|
}
|