baa8c6e5de
Lite-mode builds were broken by https://chromium-review.googlesource.com/c/v8/v8/+/2805623 [compiler] Generalize CallWithArrayLike optimization This patch fixes the build. Bug: v8:9974 Change-Id: I07530307e321a260a5d8ff59ab2c440764ebfc41 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2915678 Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Paolo Severini <paolosev@microsoft.com> Cr-Commit-Position: refs/heads/master@{#74726}
132 lines
4.3 KiB
C++
132 lines
4.3 KiB
C++
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/flags/flags.h"
|
|
#include "test/cctest/compiler/node-observer-tester.h"
|
|
#include "test/cctest/test-api.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace compiler {
|
|
|
|
void CompileRunWithNodeObserver(const std::string& js_code,
|
|
int32_t expected_result,
|
|
IrOpcode::Value initial_call_opcode,
|
|
IrOpcode::Value updated_call_opcode1,
|
|
IrOpcode::Value updated_call_opcode2) {
|
|
LocalContext env;
|
|
v8::Isolate* isolate = env->GetIsolate();
|
|
v8::HandleScope scope(isolate);
|
|
|
|
FLAG_allow_natives_syntax = true;
|
|
FLAG_turbo_optimize_apply = true;
|
|
|
|
// Note: Make sure to not capture stack locations (e.g. `this`) here since
|
|
// these lambdas are executed on another thread.
|
|
ModificationObserver apply_call_observer(
|
|
[initial_call_opcode](const Node* node) {
|
|
CHECK_EQ(initial_call_opcode, node->opcode());
|
|
},
|
|
[updated_call_opcode1, updated_call_opcode2](
|
|
const Node* node,
|
|
const ObservableNodeState& old_state) -> NodeObserver::Observation {
|
|
if (updated_call_opcode1 == node->opcode()) {
|
|
return NodeObserver::Observation::kContinue;
|
|
} else {
|
|
CHECK(updated_call_opcode2 == node->opcode());
|
|
return NodeObserver::Observation::kStop;
|
|
}
|
|
});
|
|
|
|
{
|
|
ObserveNodeScope scope(reinterpret_cast<i::Isolate*>(isolate),
|
|
&apply_call_observer);
|
|
|
|
v8::Local<v8::Value> result_value = CompileRun(js_code.c_str());
|
|
|
|
CHECK(result_value->IsNumber());
|
|
int32_t result =
|
|
ConvertJSValue<int32_t>::Get(result_value, env.local()).ToChecked();
|
|
CHECK_EQ(result, expected_result);
|
|
}
|
|
}
|
|
|
|
TEST(ReduceJSCallWithArrayLike) {
|
|
CompileRunWithNodeObserver(
|
|
"function sum_js3(a, b, c) { return a + b + c; }"
|
|
"function foo(x, y, z) {"
|
|
" return %ObserveNode(sum_js3.apply(null, [x, y, z]));"
|
|
"}"
|
|
"%PrepareFunctionForOptimization(sum_js3);"
|
|
"%PrepareFunctionForOptimization(foo);"
|
|
"foo(41, 42, 43);"
|
|
"%OptimizeFunctionOnNextCall(foo);"
|
|
"foo(41, 42, 43);",
|
|
126, IrOpcode::kJSCall,
|
|
IrOpcode::kJSCall, // not JSCallWithArrayLike
|
|
IrOpcode::kPhi); // JSCall => Phi when the call is inlined.
|
|
}
|
|
|
|
TEST(ReduceJSCallWithSpread) {
|
|
CompileRunWithNodeObserver(
|
|
"function sum_js3(a, b, c) { return a + b + c; }"
|
|
"function foo(x, y, z) {"
|
|
" const numbers = [x, y, z];"
|
|
" return %ObserveNode(sum_js3(...numbers));"
|
|
"}"
|
|
"%PrepareFunctionForOptimization(sum_js3);"
|
|
"%PrepareFunctionForOptimization(foo);"
|
|
"foo(41, 42, 43);"
|
|
"%OptimizeFunctionOnNextCall(foo);"
|
|
"foo(41, 42, 43)",
|
|
126, IrOpcode::kJSCallWithSpread,
|
|
IrOpcode::kJSCall, // not JSCallWithSpread
|
|
IrOpcode::kPhi);
|
|
}
|
|
|
|
TEST(ReduceJSCreateClosure) {
|
|
CompileRunWithNodeObserver(
|
|
"function foo_closure() {"
|
|
" return function(a, b, c) {"
|
|
" return a + b + c;"
|
|
" }"
|
|
"}"
|
|
"const _foo_closure = foo_closure();"
|
|
"%PrepareFunctionForOptimization(_foo_closure);"
|
|
"function foo(x, y, z) {"
|
|
" return %ObserveNode(foo_closure().apply(null, [x, y, z]));"
|
|
"}"
|
|
"%PrepareFunctionForOptimization(foo_closure);"
|
|
"%PrepareFunctionForOptimization(foo);"
|
|
"foo(41, 42, 43);"
|
|
"%OptimizeFunctionOnNextCall(foo_closure);"
|
|
"%OptimizeFunctionOnNextCall(foo);"
|
|
"foo(41, 42, 43)",
|
|
126, IrOpcode::kJSCall,
|
|
IrOpcode::kJSCall, // not JSCallWithArrayLike
|
|
IrOpcode::kPhi);
|
|
}
|
|
|
|
TEST(ReduceJSCreateBoundFunction) {
|
|
CompileRunWithNodeObserver(
|
|
"function sum_js3(a, b, c) {"
|
|
" return this.x + a + b + c;"
|
|
"}"
|
|
"function foo(x, y ,z) {"
|
|
" return %ObserveNode(sum_js3.bind({x : 42}).apply(null, [ x, y, z ]));"
|
|
"}"
|
|
"%PrepareFunctionForOptimization(sum_js3);"
|
|
"%PrepareFunctionForOptimization(foo);"
|
|
"foo(41, 42, 43);"
|
|
"%OptimizeFunctionOnNextCall(foo);"
|
|
"foo(41, 42, 43)",
|
|
168, IrOpcode::kJSCall,
|
|
IrOpcode::kJSCall, // not JSCallWithArrayLike
|
|
IrOpcode::kPhi);
|
|
}
|
|
|
|
} // namespace compiler
|
|
} // namespace internal
|
|
} // namespace v8
|